Incompatible with Wynntils NPC Dialogues in 1.19.3

[opal wind]

The latest 1.19.3 Fabric version of Voices of Wynn (beta 1.2) does not play recordings when the "NPC Dialogues" feature is enabled in Wynntils/Artemis (0.0.2-alpha.18). Disabling the feature in Wynntils' settings immediately restores VoW recordings.

I'm not a Fabric modder so I don't know for sure if this is actually how it works, but it seems like Wynntils is canceling the system chat packet event and VoW is listening to that same same event.

wynntils cancels the packet: https://github.com/Wynntils/Artemis/blob/main/common/src/main/java/com/wynntils/handlers/chat/ChatHandler.java#L100
wynntils injects their mixin: https://github.com/Wynntils/Artemis/blob/main/common/src/main/java/com/wynntils/mc/mixin/ClientPacketListenerMixin.java#L297
vow injects its mixin: https://github.com/Team-VoW/WynncraftVoiceProject/blob/main/1.18/src/main/java/com/wynnvp/wynncraftvp/events/mixins/MixinChatListener.java#L15

[radiant bear]

@shadow delta

[shadow delta]

yup! Looking into it 😉

[radiant bear]

Lmao Wynntils Team breaking our mod

[shadow delta]

yeah, they just changed the mixin

[silk wren]

steal their mixin!

[shadow delta]

can't

[silk wren]

Well hmm

[shadow delta]

Ya able to jump into vc?

[round talon]

@shadow delta I don't think your fixes are working. I haven't tested, but it shouldn't

Give me a sec to explain

If you check, there are 2 chat mixins

https://github.com/Wynntils/Artemis/blob/67a0b79bd48a1d362c955060fde637d83c44baf8/common/src/main/java/com/wynntils/mc/mixin/ClientPacketListenerMixin.java#L299

Player Chat mixin. This is not actually used by Wynncraft (proving chat signing is non-existant in Wynn)

The chat packet wynn uses to send everything is https://github.com/Wynntils/Artemis/blob/67a0b79bd48a1d362c955060fde637d83c44baf8/common/src/main/java/com/wynntils/mc/mixin/ClientPacketListenerMixin.java#L349

Given that system packets dont do signing

[round talon]

oh the commit message "The chat received mixin does not work yet"

Well, here is your problem 😉

(also meaning a simple hook into the correct mixin will fix your issues, no incompatibility here)

although, I am not fully sure how disabling NPC dialogue processing in Wynntils fixes the issue, given that you are using the wrong mixin

[shadow delta]

Thanks a ton 😁

[shadow delta]

I just committed it because I had to catch a train and won't be on my pc over the holidays, but with it being commited I can fix the last thinga from my laptop

[shadow delta]

It's the version before that code change

As our mixin was somewhere later in chat recieved

[round talon]

oh

[shadow delta]

ok. I have replaced it with that now, but it still doesn't get through if dialogue overlay is enabled

I guess the order which things are triggered is random?

And Wynntils just happen to land first

wait, I just need to increase the priority

[round talon]

you can increase mixin priority

[shadow delta]

Will just set it to 1001 then

[round talon]

not sure if you need to decrease or increase it, because idk what it does internally

[shadow delta]

yeah, gonna have to test I guess xD

I really net to set up something to be able to hotswap

[round talon]

do you use windows?

[shadow delta]

yep

[round talon]

oh right it doesnt matter for you, vow is fabric only

use hotswapagent, like artemis does

artemis readme has the full process

[shadow delta]

Okay! Gonna take a look into that

[shadow delta]

Alright, I needed to decrease it

[round talon]

works now?

[shadow delta]

yep! Now just got to test a cutscene as someone said there was an issue with that