updating embeds per server | disnake | Page 1

soft parrot Jan 30, 2023, 12:34 AM

#

I am trying to create a loop to update an embed per discord of stored information, but I am running into an issue where other servers information makes it way into the wrong server. Is there a better method than using for loops?

The picture attached shows 3 things that should be showing up but instead it is showing one (wrong) thing

#

I will grab the code soon as I’m back home and at my pc

atomic swallow Jan 30, 2023, 12:39 AM

#

update the embed info for each server

soft parrot Jan 30, 2023, 12:48 AM

#

@tasks.loop(minutes = 1)
async def update_pop_embed(self):
    await bot.wait_until_ready()
    for guild in bot.guild:
        now1 = datetime.now()
        start_time1= now1.strftime('%I:%M %p')
        embed = disnake.Embed(title=f'**__Pop Tracking__**', color=color)
        embed.set_thumbnail(url=bot.user.display_avatar.url)
        embed.set_footer(text=f'{bot.user.name} v{ver} | Updated {start_time1}', icon_url=bot.user.display_avatar.url)
        servers = await bot.db.fetch(f"SELECT * FROM pop_embed")
            for i in servers:
                if i[0] == guild.id and i[7] != None:
                    channel = bot.get_channel(i[7])
                    message = await channel.fetch_message(i[8])
                if i[0] == guild.id: 
                    if i[2] == 'Xbox':
                        emoji = xbox
                    if i[2] == 'PlayStation':
                        emoji = ps
                    if i[1] != None and i[0] == guild.id:
                        embed.add_field(name=f"{emoji} **{i[1].upper()}**", value=f"Players Online: {i[4]}/{i[5]}\nMaps Online: {i[6]}\nVersion: {i[3]}", inline=False)
                    if message.author == bot.user:
                        await message.edit(embed=embed)```

atomic swallow Jan 30, 2023, 12:52 AM

#

The picture attached shows 3 things that should be showing up but instead it is showing one (wrong) thing
what wrong thing?

soft parrot Jan 30, 2023, 12:53 AM

#

the edited embed shows royalty of ark instead of the three servers listed in the ephemeral message

#

the command setup view (the ephemeral one) is there for me to see what is supposed to show up

atomic swallow Jan 30, 2023, 12:54 AM

#

well, you're editing the message in a for loop

#

move the message.edit to the guild loop rather than the server loop

soft parrot Jan 30, 2023, 12:55 AM

#

if memory serves me well, i tried that earlier and it told me message wasnt defined

atomic swallow Jan 30, 2023, 12:56 AM

#

So, there's a few issues.

soft parrot Jan 30, 2023, 12:56 AM

#

But I can try it again

atomic swallow Jan 30, 2023, 12:58 AM

#

you're querying the db for ALL servers, for each guild. Seems unnecessary to do it more than once. (ie, if you have 10 guilds, you're querying all data 10x)
you're potentially fetching a message multiple times if the guild_id and message ID exist more than once. (ie, if a guild and message combo exists 3 times, you're fetching 3 times, ratelimits could become an issue)
You're editing a message each time the guild.id appears in the query results. (same as 2, still ratelimits could be an issue)

soft parrot Jan 30, 2023, 1:02 AM

#

Ok so

move db request outside of for guilds loop
guild id + message id combo only exists 1x
what is the rate limit id be hitting?

atomic swallow Jan 30, 2023, 1:02 AM

#

also it should be bot.guilds

atomic swallow Jan 30, 2023, 1:02 AM

#

soft parrot Ok so 1) move db request outside of for guilds loop 2) guild id + message id com...

Well, fetching and editing are API calls. Do that too fast, you'll hit ratelimits

soft parrot Jan 30, 2023, 1:02 AM

#

atomic swallow also it should be `bot.guilds`

I think it is, typo on my part

soft parrot Jan 30, 2023, 1:02 AM

#

atomic swallow Well, fetching and editing are API calls. Do that too fast, you'll hit ratelimi...

Ah ok

#

Also time can be adjusted it’s at a minute rn to make testing easier

#

so i updated it to this:

#

    @tasks.loop(minutes = 1)
    async def update_pop_embed(self):
        await bot.wait_until_ready()
        servers = await bot.db.fetch(f"SELECT * FROM pop_embed")
        for guild in bot.guilds:
            now1 = datetime.now()
            start_time1= now1.strftime('%I:%M %p')
            embed = disnake.Embed(title=f'**__Pop Tracking__**', color=color)
            embed.set_thumbnail(url=bot.user.display_avatar.url)
            embed.set_footer(text=f'{bot.user.name} v{ver} | Updated {start_time1}', icon_url=bot.user.display_avatar.url)

            for i in servers:
                if i[0] == guild.id and i[7] != None:
                    channel = bot.get_channel(i[7])
                    message = await channel.fetch_message(i[8])
                if i[0] == guild.id: 
                    if i[2] == 'Xbox':
                        emoji = xbox
                    if i[2] == 'PlayStation':
                        emoji = ps
                    if i[1] != None and i[0] == guild.id:
                        embed.add_field(name=f"{emoji} **{i[1].upper()}**", value=f"Players Online: {i[4]}/{i[5]}\nMaps Online: {i[6]}\nVersion: {i[3]}", inline=False)
            if message.author == bot.user:
                await message.edit(embed=embed)```

#

and get this error: line 129, in update_pop_embed if message.author == bot.user: UnboundLocalError: local variable 'message' referenced before assignment

atomic swallow Jan 30, 2023, 1:19 AM

#

right, because message will not exist until it's created

soft parrot Jan 30, 2023, 1:20 AM

#

Message is created in the for i in servers loop though

atomic swallow Jan 30, 2023, 1:30 AM

#

soft parrot Message is created in the for i in servers loop though

True, but not every time.

#

Let's say, current guild is Disnake.

While on the current iteration of guilds, (disnake)
it's trying to compare all the db data as long as the ID matches the guild (disnake) id.
But each time it doesn't match, it's skipping that loop, so message isn't created.

#

So if you have 10 servers in the db, only one matches the disnake guild id, right?
So, 9 other times, it doesn't and message isn't created.

#

@tasks.loop(minutes=1)
async def update_pop_embed(self) -> None:

    emojis = {"Playstation": ps, "Xbox": xbox}
    servers = await bot.db.fetch(f"SELECT * FROM pop_embed")

    for guild in bot.guilds:
        now = datetime.now().strftime("%I:%M %p")
        embed = disnake.Embed(title="**__Pop Tracking__**", color=color)
        embed.set_thumbnail(url=bot.user.display_avatar.url)
        embed.set_footer(
            text=f"{bot.user.name} v{ver} | Updated {now}", icon_url=bot.user.display_avatar.url
        )
        message = None  # set the default to None in case it's not found later
        for server in servers:
            if guild.id != server[0]:
                continue

            channel = self.bot.get_partial_messageable(server[7], type=disnake.TextChannel)
            if channel is None:
                continue

            message = self.bot.get_message(server[8]) or await channel.fetch_message(server[8])
            if message is None:
                continue

            emoji = emojis.get(server[2], "")
            if server[1] is not None:
                embed.add_field(
                    name=f"{emoji} **{i[1].upper()}**",
                    value=f"Players Online: {server[4]}/{server[5]}\nMaps Online: {server[6]}\nVersion: {server[3]}",
                    inline=False,
                )

        if message:
            # tries to edit the message, if it fails for any reason it will continue 
            # to the next guild
            try:
                await message.edit(embed=embed)
            except disnake.HTTPException:
                pass

used a PartialMessage rather than fetching a message since you're just editing.

soft parrot Jan 30, 2023, 1:37 AM

#

so that gave this error: line 129, in update_pop_embed message = channel.get_message(server[8]) or channel.get_partial_message(server[8]) AttributeError: 'TextChannel' object has no attribute 'get_message'

atomic swallow Jan 30, 2023, 1:37 AM

#

wait.

#

oh duh

soft parrot Jan 30, 2023, 1:38 AM

#

isnt it channel.fetch_message

#

not get_message

atomic swallow Jan 30, 2023, 1:38 AM

#

Removing the need to fetch.

#

updated

#

so now the only API call should be the message.edit

soft parrot Jan 30, 2023, 1:39 AM

#

you also need this await bot.wait_until_ready() before servers = db connection

atomic swallow Jan 30, 2023, 1:39 AM

#

Oh.

soft parrot Jan 30, 2023, 1:40 AM

#

since iits in a cog

#

adding that line fixes the bot has no attribute db error

#

    @tasks.loop(minutes=1)
    async def update_pop_embed(self) -> None:
        await bot.wait_until_ready()
        servers = await bot.db.fetch(f"SELECT * FROM pop_embed")
        emojis = {"playstation": ps, "xbox": xbox}```

atomic swallow Jan 30, 2023, 1:40 AM

#

added that part, too.. Forgot

#

did it as a before_loop

soft parrot Jan 30, 2023, 1:40 AM

#

ah fair

atomic swallow Jan 30, 2023, 1:41 AM

#

so it only happens once, rather than every time the loop runs

#

since you only need to wait the first time

soft parrot Jan 30, 2023, 1:41 AM

#

makes sense

#

TypeError: Expected TextChannel, DMChannel, VoiceChannel, Thread, or PartialMessageable with a valid type, not <class 'disnake.channel.PartialMessageable'> (type: None)```

atomic swallow Jan 30, 2023, 1:42 AM

#

umm

soft parrot Jan 30, 2023, 1:42 AM

#

message = channel.get_partial_message(server[8])

#

thats the line its referring to

atomic swallow Jan 30, 2023, 1:43 AM

#

oh

#

I got the number messed up

#

channel is [7]

#

no

#

oh.

soft parrot Jan 30, 2023, 1:43 AM

#

message id is 8

#

channel id is 7

atomic swallow Jan 30, 2023, 1:44 AM

#

channel = self.bot.get_partial_messageable(server[7], type=disnake.TextChannel)

#

Just need to define the type of channel.

#

I've used partial_message before. First time playing with partial_messageable (channels)

soft parrot Jan 30, 2023, 1:46 AM

#

Wouldn’t it still be 8 not 7

atomic swallow Jan 30, 2023, 1:46 AM

#

The issue is getting the channel correctly.

#

So, update that line

#

message should work afterwards

soft parrot Jan 30, 2023, 1:47 AM

#

    emoji = emojis.get(server[2].lower(), "")
AttributeError: 'NoneType' object has no attribute 'lower'```

#

progress lol

atomic swallow Jan 30, 2023, 1:48 AM

#

so server[2] can be None?

soft parrot Jan 30, 2023, 1:48 AM

#

Rarely but yes

atomic swallow Jan 30, 2023, 1:48 AM

#

OK.

#

updated above

soft parrot Jan 30, 2023, 1:49 AM

#

so i did this

atomic swallow Jan 30, 2023, 1:49 AM

#

Just need to make it match the case then

soft parrot Jan 30, 2023, 1:49 AM

#

      emoji = emojis.get(server[2].lower(), "")
else:
    emoji = ''```

atomic swallow Jan 30, 2023, 1:49 AM

#

and remove the lower()

#

or that

#

but you need emoji to have a default of ''

#

that way if it is None, it will just give emoji a value of ''

#

You could do that, too

#

I'd just probably give it a default under message = None

soft parrot Jan 30, 2023, 1:51 AM

#

ah ok

atomic swallow Jan 30, 2023, 1:51 AM

#

...
message = None
emoji = ''

#

then update as needed

#

but doesn't matter

soft parrot Jan 30, 2023, 1:51 AM

#

gotcha

#

now this

#

    await message.edit(embed=embed)
AttributeError: 'PartialMessageable' object has no attribute 'edit'```

atomic swallow Jan 30, 2023, 1:52 AM

#

well that's not true..

#

it is.

#

Shit

#

message = self.bot.get_message(server[8]) or await channel.fetch_message(server[8])

#

should work.

#

get the message from cache, or fetch if it's not available.

#

Assuming you have message cache enabled (via intents)

soft parrot Jan 30, 2023, 1:57 AM

#

intents are defined as disnake.default()

#

and i think it has member as well

atomic swallow Jan 30, 2023, 1:58 AM

#

default is all but presences, members, and message_content

#

intents = disnake.Intents.default()
intents.members = True

bot = commands.Bot(intents=intents, ...)

Is that what you have?

soft parrot Jan 30, 2023, 1:59 AM

#

yes

atomic swallow Jan 30, 2023, 1:59 AM

#

Then yes.

#

That should work. If it can't get the message from cache, it will fetch it

soft parrot Jan 30, 2023, 1:59 AM

#

ok i will try running it again'

atomic swallow Jan 30, 2023, 1:59 AM

#

better than fetching 100% of the time.

soft parrot Jan 30, 2023, 2:00 AM

#

true and the bot rarely goes down unless im messing with it lol

#

how often would you suggest the loop run, to update as often as possible but avoid rate limits?

atomic swallow Jan 30, 2023, 2:02 AM

#

Depends on how often you need it to.

#

And how many messages you'll be updating.

soft parrot Jan 30, 2023, 2:02 AM

#

bot is in 1000 servers

#

assuming 100 people use the feature

#

and i know some people want every min

#

but thats unrealistic

#

i was thinking 2-3 mins

atomic swallow Jan 30, 2023, 2:03 AM

#

you COULD, store that config info and run the task every minute, but only update the ones that want to be updated every minute

#

But, that sounds like a nightmare.

soft parrot Jan 30, 2023, 2:04 AM

#

yea...

#

no one gets special treatment lol

atomic swallow Jan 30, 2023, 2:04 AM

#

Disnake is good about handling rate limits, but the less often it happens the better

soft parrot Jan 30, 2023, 2:04 AM

#

ill stick with 2 mins and if it becomes an issue ill slow it down

#

it is working

#

so much appreciated, thank you

atomic swallow Jan 30, 2023, 2:06 AM

#

working AND giving you the correct info in the right places?

soft parrot Jan 30, 2023, 2:06 AM

#

yes

atomic swallow Jan 30, 2023, 2:06 AM

#

Sweet.

soft parrot Jan 30, 2023, 2:06 AM

#

and i learned something

#

never knew about get_partial_messageable

atomic swallow Jan 30, 2023, 2:06 AM

#

We eventually got there. I haven't written any code in over a week and my memory of disnake is a tad rusty 😄

soft parrot Jan 30, 2023, 2:07 AM

#

lmao i am still impressed and thankful

atomic swallow Jan 30, 2023, 2:07 AM

#

Yeah. It definitely comes in handy

soft parrot Jan 30, 2023, 2:34 AM

#

well

#

things were good

#

atomic swallow Jan 30, 2023, 2:35 AM

#

Hmm

#

Oh..

#

Easy fix.

soft parrot Jan 30, 2023, 2:37 AM

#

Those are my favorite kind of fixes

atomic swallow Jan 30, 2023, 2:38 AM

#

for server in servers:
  if guild.id != server[0]:
    continue
  if server[7] is None or server[8] is None:
    continue
  channel = self.bot.get_partial_messageable(server[7], type=disnake.TextChannel)
  message = self.bot.get_message(server[8]) or await channel.fetch_message(server[8])

#

because they are partial_messageable, they won't return None.

#

so we need to check if the value is None before creating the objects

soft parrot Jan 30, 2023, 2:39 AM

#

Ah

#

Added and restarting now

#

Looks like that fixed it

atomic swallow Jan 30, 2023, 3:01 AM

#

Nice

soft parrot Jan 30, 2023, 3:13 AM

#

One more question

#

Someone is having theirs update, but nothing is in the embed

#

It’s just an empty embed

#

atomic swallow Jan 30, 2023, 3:15 AM

#

if server[1] is not None:

#

if the 2nd index is None, embed field isn't added

soft parrot Jan 30, 2023, 3:16 AM

#

Hm he said he got 4 updates in a row with nothing

#

Despite having 6 servers set to be shown

atomic swallow Jan 30, 2023, 3:17 AM

#

check your data in the db

#

That's the only thing that would prevent the add_field from executing

soft parrot Jan 30, 2023, 3:17 AM

#

There is currently 4 servers in the db with the second index not none

#updating embeds per server