[0.11.5.11] (Modding) Upper Bound does not work as intended | Quest Master | Page 1

tough marten Apr 10, 2025, 6:17 AM

#

After extensive testing, it seems Upper Bound does in fact not work for the attribute it's applied to. It does correctly limit the effect duration to whatever the highest value is you received from an item, but not the intensity. I thought this might be due to "Multiple upper bounds are additive" but even setting the upper bound lower than the attribute (2 -> "<=1") had no effect.

**Tested with: **

Swimming Speed (60sec, 50%)
SwimmingSpeed: 50% Upper Bound: "<=50%"
InvincibilityDuration (60sec, 2)
InvincibilityDuration: 2 Upper Bound: "<=2"

tough marten Apr 10, 2025, 6:33 AM

#

(Modding) Upper Bound does not work as intended

#

[0.11.5.11] (Modding) Upper Bound does not work as intended

shy maple Apr 10, 2025, 8:52 AM

#

Uhh... I don't think that's how you code Upper Bounds.

#

SwimmingSpeed: "<=1.5" (I don't know the exact base value of this)
InvincibilityDuration: "<=2"

Wouldn't this just enough?

tough marten Apr 10, 2025, 9:16 AM

#

That doesn't do anything

#

Swimming Speed Default is 3 (tiles per second), 4.5 would be 50% faster
Ingame the potion doesn't do anything now

#

Tried it with a different attribute that doesn't use %-based value, can't load mod due to formatting error in input string

#

Failed to load mod Aetheria Essentials due to exception: System.FormatException: Input string was not in a correct format.

#

Wait nevermind, that was because of something else. Trying again

#

No still doesn't work. Same as the swimming potion—just has no effect at all

#

Also tried changing "Upper Bound:" to "Upper Bounds:", didn't do anything (the effect still stacks)

shy maple Apr 10, 2025, 9:48 AM

#

I have one question.

#

Where did you learn this?

#

I still really think you don't have to code the... Upper Bound like this.

#

Also I just noticed Now, that you are using "<="

tough marten Apr 10, 2025, 9:51 AM

#

shy maple Where did you learn this?

There is no example given for how to do it, so I tried it multiple ways until one worked.

shy maple Apr 10, 2025, 9:51 AM

#

The Lower Bound and Upper Bound is used to change the value that is dependent on the original base value.

I believe if you do InvincibilityDuration: ">=2"
It would mean, the value will always be "2"
Unless you have another item that tries to stack.

tough marten Apr 10, 2025, 9:51 AM

#

shy maple Also I just noticed *Now*, that you are using "<="

Yes that's how it's in the example mod.

shy maple Apr 10, 2025, 9:52 AM

#

Hmmm, InvincibilityDuration has a base value of 1, if we made <=2, there's nothing changed because it is lower than 2.

tough marten Apr 10, 2025, 9:52 AM

#

shy maple The Lower Bound and Upper Bound is used to change the value that is dependent on...

No, ">=2" would be setting the Lower Bound.

#

shy maple Apr 10, 2025, 9:53 AM

#

Interesting interesting, but before I explain further, may I ask for confirmation, what do you intend to do again?

#

I'm actually at lost at the moment xd

tough marten Apr 10, 2025, 9:55 AM

#

I don't know what you don't understand, I think I made it as clear as it can be

tough marten Apr 10, 2025, 9:55 AM

#

shy maple Hmmm, InvincibilityDuration has a base value of 1, if we made `<=2`, there's not...

Also, this makes no sense

#

Did you even read the explanations for Lower Bounds and Upper Bounds given in the example mod? It seems like you were confused about the difference of "<=x" and ">=x"

shy maple Apr 10, 2025, 9:58 AM

#

I suppose xd.

#

But...

shy maple Apr 10, 2025, 10:48 AM

#

Alright, I suppose I should ask better questions.
What does your potion even supposedly do? I really don't follow people's mod really, forgive me on that but still. (Though if you want, we could continue having this conversation in #🤖│mod-chat xd)
I made tests, it works as intended, I'm simply confused right now.

tough marten Apr 10, 2025, 10:51 AM

#

They do what it says in the example

#

Mermaids Potion makes you swim 50% faster for example

shy maple Apr 10, 2025, 10:55 AM

#

And you mentioned "Stack", what does that mean?
I tried with the same modded item that gives the same SwimmingSpeed, it doesn't stack, unless it meant something else?

tough marten Apr 10, 2025, 10:56 AM

#

Because you only tested it with 1 item. In the mod every potion has 3 variants. They all have the same effect, but different durations (60, 30, 15 secs). The effect stacks when you use all 3. Now with the Upper Bound the effect *duration * doesn't stack anymore (it used to), but the effect still stacks.

shy maple Apr 10, 2025, 10:57 AM

#

Ah, now that's an interesting usecase with the current modding.

#

Hmmmm...

shy maple Apr 10, 2025, 11:16 AM

#

Alright, here's what you need to know about using Upper Bound (Even Lower Bound) as a value...
It is meant to give a "rule", it sounds weird, but it is what it is.
Here's my tests,
First Item SwimmingSpeed: "<=5" Duration: 10
Second Item SwimmingSpeed: +10 Duration: 30
Third Item SwimmingSpeed: +10 Duration 50

I took the Second and Third, yes it stacks, however the duration is separate for both, so in reality, I would have 30 Seconds of +10 SwimmingSpeed and 50 Seconds of +10 SwimmingSpeed (That means I'll be having +20 SwimmingSpeed for 30 Seconds)
Then I took the First item, since it has a rule of SwimmingSpeed to be not higher than 5, my SwimmingSpeed now is actually higher than 5, so during that 10 seconds, I would be having +5 SwimmingSpeed
After 10 Seconds, I would then have a SwimmingSpeed of +20 again.
Once the Second Item buff expires, SwimmingSpeed of +10

From this test alone, the feature works as intended, however, from your use case, it needs a new feature.

#

A single item can't have two same attributes at the same time, I tried :(.

tough marten Apr 10, 2025, 11:18 AM

#

shy maple A single item can't have two same attributes at the same time, I tried :(.

What

shy maple Apr 10, 2025, 11:18 AM

#

I tried giving an item having two same attribute.
SwimmingSpeed: +5
SwimmingSpeed: "<=5"

tough marten Apr 10, 2025, 11:19 AM

#

tes_tomthink

#

Why would that be how it works

#

Of course that doesnt work

shy maple Apr 10, 2025, 11:19 AM

#

It doesn't break surprisingly 😏

#

But instead choose the newest attribute in the code, haha, who knows, whatever works.

#

You'll never know...

tough marten Apr 10, 2025, 11:20 AM

#

shy maple Alright, here's what you need to know about using Upper Bound (Even Lower Bound)...

Show me the code for the first swimming potion. It did not work for me ingame and I tried the same formatting as you.

shy maple Apr 10, 2025, 11:21 AM

#

Type: Consumable

Icon: Textures/DoubleHeart_Icon
Gizmo: Textures/DoubleHeart_Gizmo

# Optionally specify a custom animation for the item to display.
# Animation:
#   SpriteSheet:
#     Texture: Textures/DoubleHeart
#     Width: 16
#   Speed: 10

Name: Double Heart
Description: Replenishes {Highlighted:two} hearts.
Message: 
  - You got a {Highlighted:double heart}!
  - It replenishes two hearts.

Health: 16

# Uncomment this to play the eat voice clip when consuming this item. (This is used by food)
# Eat: true

# If set, attributes will apply as a buff with the given duration. Otherwise, the attributes are permanent.
Duration: 15

# You can optionally add attributes that are given to the player upon consumption.
Attributes:
  SwimmingSpeed: "<=5"

tough marten Apr 10, 2025, 11:21 AM

#

Also why did you only specify for one potion? There wont be an Upper Bound if you drink just the other two

tough marten Apr 10, 2025, 11:22 AM

#

shy maple ``` Type: Consumable Icon: Textures/DoubleHeart_Icon Gizmo: Textures/DoubleHear...

Ok im gonna test this again after eating

shy maple Apr 10, 2025, 11:23 AM

#

tough marten Also why did you only specify for one potion? There wont be an Upper Bound if yo...

That's because that is how it works 😔
I know what you want for your potion, it just doesn't work for the current features we have given.

tough marten Apr 10, 2025, 11:23 AM

#

shy maple That's because that is how it works 😔 I know what you want for your potion, it...

What do you mean? That makes no sense

shy maple Apr 10, 2025, 11:23 AM

#

Like I said, Upper Bound and Lower Bound values are just "rules" you'll be giving

tough marten Apr 10, 2025, 11:23 AM

#

If it worked for one potion, has to work for the other two

shy maple Apr 10, 2025, 11:24 AM

#

If you give three of those potion Upper Bound.

#

You're not giving any additions to your SwimmingSpeed.

#

It would just stayed at base value.

tough marten Apr 10, 2025, 11:24 AM

#

Ok let me ask you directly: Did you test the first potion individually

shy maple Apr 10, 2025, 11:24 AM

#

Yes

tough marten Apr 10, 2025, 11:24 AM

#

And it increased your swimming speed?

shy maple Apr 10, 2025, 11:24 AM

#

It does not, because my "Base Value: is 4.

tough marten Apr 10, 2025, 11:25 AM

#

3 actually, but yes

#

So what you just told me is it doesnt work

shy maple Apr 10, 2025, 11:26 AM

#

Hmmm, we'll be going circles honestly, I stand by my tests really.
Where's Julian 😏

#

Like really.
When I read this, it just basically gives a rule to not go over that value.

tough marten Apr 10, 2025, 11:27 AM

#

You just said the the 1st potion did not increase your swimming speed. It only works as Upper Bound for the other potions. That's what you're telling me right?

shy maple Apr 10, 2025, 11:27 AM

#

Yes.

tough marten Apr 10, 2025, 11:28 AM

#

So it does in fact not work as intended, since you need 2 items to apply an Upper Bound to 1 item, which makes no sense because then you'd need an extra item just for this one rule to add to every item that needs it.

shy maple Apr 10, 2025, 11:29 AM

#

Well, to be fair, it could be used for Rings.

#

Think about "Cursed" Rings.

tough marten Apr 10, 2025, 11:29 AM

#

You'd still need 2 rings for that

#

Unless you mean a ring that specifically prevents you from getting positive effects from potions and stuff

shy maple Apr 10, 2025, 11:30 AM

#

Umm, no, like, a single ring could just prevent you giving any buffs from items and such.

#

I can see the applications for the Upper Bound being like this, though we still need Julian thoughts about this, since he is the one who made the system xd

tough marten Apr 10, 2025, 11:31 AM

#

Oh hold on, now I get it. The feature was probably never intended for items. Its to make debuff and buff rings

#

No wonder it doesn't work

#

Lets wait for Julian to confirm it

#

myy_BunnyTired

shy maple Apr 10, 2025, 11:32 AM

#

Lucky

#[0.11.5.11] (Modding) Upper Bound does not work as intended