#ModernFix Test Build Discussion Thread

1 messages · Page 1 of 1 (latest)

final sail
lilac rune
#

Game is definitely loading a lot faster

#

like WAY faster, i think usually it took about 1 ish minute before i got to the main menu

#

but with this I got to the main menu within like, 15 seconds

#

tho this was without the dynamic resources thing

#

it feels like fps dropped but ill check by removing the mod first before saying that

#

wait no nevermind it feels better

#

guess that was just loading lag

#

world and game definitely loaded significantly faster i can confirm that

#

game loads even faster with the mixin thing

#

well

#

haha

#

this is what happened with the mixin thing

#

it did not happen when the mixin thing wasn't enabled

#

these blocks are all grass blocks too

#

anvil grindstone brewingstand candles grass and vines

#

are immediately noticeable

#

as being glitched

#

heres a log attached

#

in case the dev can spot any immediate and obvious errors

final sail
#

@hoary thistle ^

hoary thistle
#

if so, does the issue occur without them?

final sail
#

several

#

Continuity & LambdBetterGrass are also installed

hoary thistle
#

try without those, continuity won't work correctly out of the box

final sail
#

I see

hoary thistle
#

although I dont think it should brick rendering altogether

#

usually the textures just stop connecting

final sail
#

is it possible to make them still connect

#

@lilac rune read above and also is your profile picture Killjoy from valorant? lmao

hoary thistle
#

there is no standard API on fabric for modifying models

#

which means mods that wish to do it inject into the model code directly

#

I have no way of supporting that except on a one by one basis

final sail
#

i think most people just use Continuity

hoary thistle
#

I'll see how feasible it is to reimplement the necessary hooks for it

final sail
#

that & ConnectedTexturesMod on Forge are the only ones we use

hoary thistle
#

CTM is supported

final sail
#

okay good

hoary thistle
#

can confirm the model issues are caused by lambdabettergrass

hoary thistle
#

I'd recommend not using dynamic resources on Fabric for now, for versions below 1.19.4

#

more investigation is needed to see if it's possible to develop a solution for 1.19.2 that will work properly with Fabric mods, but I don't have the energy atm

lilac rune
#

thanks for your effort, even without dynamic resources the performance boost is very noticeable!

hoary thistle
#

I think it can be safely removed/readded as it's just a visual mod afaik

final sail
#

correct

hoary thistle
#

betternether/betterend/edenring block/item textures dont load

#

everything else in REI doesn't appear glitched from a cursory scan

final sail
#

bclib momento

hoary thistle
#

ok, latest dev build has some improvements

#

lambdabettergrass now works correctly

hoary thistle
#

a side effect is that dynamic resources on fabric will not help for launch time nearly as much as it does for forge

#

continuity is not functional and will likely remain that way for some time

waxen pumice
#

torches, fences and fence gates, anvils, polished blackstone walls, blue castle doors, basically all grass, oak doors, glass panes, and lanterns are all not loading properly (just thought id list everything in my main base, not sure if that helps much, but thats what i got so far lol)

final sail
#

@hoary thistle ^

we use the Excalibur resourcepack for textures, mainly. likely the only one out of the several that'd modify these blocks

waxen pumice
#

i kinda like how the castle door looks now tbh lol

waxen pumice
#

on a good note, where i was essentially able to outrun the world loading by just flying on my bird, that does not seem to happen now

waxen pumice
#

just read through most of this discussion thread, so should i turn off lambdabettergrass for now?

final sail
#

its fixed now

waxen pumice
#

oh, so i need to update something?

#

or redownload possibly

final sail
#

the build that is linked is the fixed one

#

assuming you downloaded it in the last 6-8 hours

waxen pumice
#

ok cool

#

i did not, but i will!

#

looks like theres 2 jars, do i need both of them?

#

oh i see the difference now, nevermind lol

#

yay grass! do i need to do the mixin again?

hoary thistle
#

no, unless you deleted the config

waxen pumice
#

nope, thats what i figured would be the case

#

cool, yup, grass is no longer pink and black unless its supposed to be

hoary thistle
#

nice

waxen pumice
#

yeah, the world renders super fast now, thats awesome

hoary thistle
#

hopefully I can find a better solution than the horrendous hack I used to fix it

waxen pumice
hoary thistle
#

I wonder what I did that's speeding up chunk loading

#

but I'm not complaining

#

@final sail I'm not sure the crash you mentioned was actually modernfix

waxen pumice
#

yeah, before, just flying in a straight line essentially on my bird, eventually i would outrun the world render and just freeze for a few seconds, none of that now

final sail
#

so ur likely right

hoary thistle
#

might be a corrupt structure

#

they have tons of ram allocated based on the crash log

#

so I dont know why it would OOM

waxen pumice
#

yeah, whatever you did, everythings good now! cool

#

exploring the nether now, no issues so far

hoary thistle
#

what's memory usage like

waxen pumice
#

seems pretty good. definitely not worse. used to be sitting around 80-100 fps, right now hanging around 110

hoary thistle
#

i have just pushed support for continuity

#

build should be updated in 10 minutes or so

waxen pumice
#

assuming its updated now? ill give it a try if so

hoary thistle
waxen pumice
#

Okay I'll give it a try a couple hours here, ive got some stuff I got to take care of first haHAA

final sail
waxen pumice
#

Real life obligations

final sail
lilac rune
#

can relate

waxen pumice
#

playin with the new build now, anything i should be looking for?

final sail
#

not really

#

its pretty stable afaik

waxen pumice
#

seems to be, running great, no missing textures

hoary thistle
#

thanks for testing!

#

oh and I assume that is with dynamic resources?