Entities without a bucket item stack crash client | Supplementaries | Page 1

granite pond Aug 28, 2025, 1:31 AM

#

Hi, apparently trying to bucket item from Deeper And Darker mod it crashes a client due to their AnglerFish returns null - https://github.com/KyaniteMods/DeeperAndDarker/blob/forge-1.20/src/main/java/com/kyanite/deeperdarker/content/entities/AnglerFish.java#L94
Is it possible to prevent a crash?

📎 crash-2025-08-27_04.04.40-client.txt

#

Entities without a bucket item stack crash client

lost flame Aug 28, 2025, 5:10 PM

#

They should not return null

#

It's their fault, they are breaking a method contract

#

Empty item should be returned instead

granite pond Aug 28, 2025, 5:10 PM

#

Ooooh, okay, will do PR myself then.
Thanks!

granite pond Aug 28, 2025, 8:05 PM

#

One more question, how it supposed to work?
Apparently, your code will still remove that entity even if there is an empty item returned https://github.com/KyaniteMods/DeeperAndDarker/pull/494/files

lost flame Aug 28, 2025, 8:06 PM

#

hm

#

id have to check

#Entities without a bucket item stack crash client