[Polytone 1.21-2.2.0+] Incorrectly counting IDs in Optifine Grid-format colormaps

[sullen osprey]

As of Polytone 2.2.0, and persisting through 2.2.1 and 2.2.0, legacy colormaps in Optifine's Grid format seem to be starting at Biome ID 1, not Biome ID 0. This means that all biomes are shifted one pixel left on the grid, rendering all of them incorrectly and breaking any pack that uses Grid colormaps for grass.

I.e. Meadow, which is numeric ID 29, now corresponds to the pixel at position 28 (previously corresponding to Wooded Badlands), not 29, making Meadow grasses brown. Similarly, Plains, which is numeric ID 1, now corresponds to the pixel at position 0 (previously corresponding to The Void), not 1, making Plains grasses bluer.

[viscid sand]

actually i corrected an off by one error that was there before

there was a random +1

this was brought to my attention after i got an issue report identical to this related to conquest texture pack. I then tested it against that and fixed the issue

also this is the very reason why one should use those biome id mapper instead

so you must have your texture off by one

still i suggest using the id mappers

[sullen osprey]

Wouldn't the random +1 have accounted for the fact that Minecraft's internal Biome IDs start at zero, not at 1? And so now the IDs no longer line up with the coordinates in the default mapper? My texture is lined up exactly with the vanilla IDs, so I don't understand what would make it "off by one." With regards to biome mappers, refresh my memory, is that a Polytone feature pr a legacy Optifine feature?

[viscid sand]

everything in code starts at 0

first column is void, 17 is acacia according to optifine arbitrary and completely made up biomelist

that matched with conquest colormap i tried

[sullen osprey]

Yeah, zero is void internally, at least per https://minecraft.wiki/w/Biome/ID. However, in the above screenshots, the pixel at coordinate 0 is coloring Plains, which should be colored by coordinate 1, not 0

[viscid sand]

this is what i tested, red was on acacia biome

i can double check again

[sullen osprey]

Would it help if I sent the colormap I'm using?

Yeah I just checked that image, that red line's on coordinate 16, not 17; 16 corresponds to Snowy Taiga, not Savanna

[sullen osprey]

Also, while I understand that this is arbitrary, it's not optifine's biomelist, it's based on the internal IDs attached to each biome in the Vanilla game according to the wiki

[viscid sand]

ok i checked and you are right. I'll undo the "fix"

conquest colormap must have been wrong then

[sullen osprey]

Gotcha, thanks for following up

[viscid sand]

darn i hope this stuff settles now. dont want to touch that again

also tye y level mapping for those is completely made up since optifine had no documentation on that

i made mine map from 0 to 128 y level i believe

[sullen osprey]

Ah, gotcha; I thought you were referring to the base x coordinate mapping, my mistake. Thanks for all the work you've done with Polytone, it really is a great mod

[viscid sand]

yeah what i unfixed was the x mapping

but me thinking biomes from conquest were misaligned could be because the y wasnt what optifine used