EveryComp empty tag issues with Chipped and BOP leaves (1.20.1 Forge) | Supplementaries | Page 1

jagged oracle Jun 18, 2024, 8:42 PM

#

Currently using on 1.20.1:
BOP 18.0.0.598 (and related Terrablender 3.0.1.7)
Chipped 3.0.6 (and related Resourcefullib 2.1.25 and Athena 3.1.2)
EveryComp 2.6.61 (and related Moonlightlib 2.11.41)
Quark 4.0-458 (and related Zeta 1.0-19)
(All mods here should be the latest version for 1.20.1)

The Quark recipe for leaf hedges throws out empty tags since it can't find woodlogs tied to leaf variants. Issues are cropping up with the chipped variants of vanilla leaf blocks aswell as BOP trees that use vanilla woods.

Latest.log is attached.

📎 latest.log

crisp elk Jun 19, 2024, 2:09 AM

#

@maiden rampart

maiden rampart Jun 19, 2024, 7:38 AM

#

alright, i'm going to take a look at this

#

oh wow. i know what's the problem. interesting!!

#

The problem is white_flower_acacia_leaves from Chipped doesn't have its own logs. it use Acacia logs

#

and the origin_leaves use oak_log and it also don't have its own log, too. (from Biomes O Plenty)

#

this make the second time i've seen a problem like this before.

robust bay Jun 19, 2024, 8:58 AM

#

You should add that to required children

#

Or condition

#

So they don't get generated

maiden rampart Jun 19, 2024, 9:01 AM

#

maiden rampart this make the second time i've seen a problem like this before.

☝️ i can't recall the name of mod but that won't be the first time that a mod won't have a log for its leaves.

#

but yea i'll add that

#

will fix that tomorrow

#

@jagged oracle
would you like u to not have the hedge from Chipped not included?
or just have the recipe for hedge be fixed?

jagged oracle Jun 19, 2024, 9:35 AM

#

I mean, if it’s possible to have it generate the proper recipe for the different leaves, that would be preferable but if not then I’m not opposed to removing the recipes.

maiden rampart Jun 19, 2024, 9:36 AM

#

jagged oracle I mean, if it’s possible to have it generate the proper recipe for the different...

U know if you are not opposed to removing the recipes.

that mean the block of hedge from chipped & quark will be removed. and won't be included.

#

but I could fix the recipes. what i am asking is are you planning to use them or not?

#

if you never planned to use them. I recommend that the block to be not included. otherwise. yea

jagged oracle Jun 19, 2024, 9:38 AM

#

Oh, as in just all the hedge recipes be removed entirely? Or just the ones including the incompatible leaf variants

maiden rampart Jun 19, 2024, 9:41 AM

#

jagged oracle Oh, as in just all the hedge recipes be removed entirely? Or just the ones inclu...

all leaf_carpet will be included from quark & chipped

but hedge will not be included becasue they required to use vanilla logs

maiden rampart Jun 19, 2024, 9:56 AM

#

@jagged oracle ☝️ i haven't got your reply?

jagged oracle Jun 19, 2024, 9:57 AM

#

Ah sorry, I thought you were going to go look at some things. But yeah, in the interest of better build variety, I would like if we could keep the hedges as long as you’re able to make the recipes work.

maiden rampart Jun 19, 2024, 10:00 AM

#

gotcha. it is easy to fix

jagged oracle Jun 19, 2024, 10:01 AM

#

Fantastic, thank you so much for looking into this. I originally tried using “Load my F’ing Tags” to see if that would resolve it but alas

maiden rampart Jun 19, 2024, 10:04 AM

#

you haven't asnwered my question, tho
which is if you never planned to use them. I recommend that the block to be not included.

jagged oracle Jun 19, 2024, 10:04 AM

#

Well, as I mentioned, for better build variety, I do plan to use them.

maiden rampart Jun 19, 2024, 10:11 AM

#

oh ok.

#

alright, i'll let u know when you can mark this as "solved"

maiden rampart Jun 19, 2024, 10:20 AM

#

jagged oracle Well, as I mentioned, for better build variety, I do plan to use them.

about the BOP, are you familiar with the leaves from BOP?

if you are. then you tell me which logs are they from?

#

for some reasons why i can't grow up Rainbow Birch Sapling

jagged oracle Jun 19, 2024, 10:21 AM

#

I could go into a test world and try and grow each of the trees. But I haven’t quite gotten onto my Pc Yet

maiden rampart Jun 19, 2024, 10:22 AM

#

i see. Most of Saplings from BOP i can't grow them.

it's because I am trying to find out which log they are using.

they all are using vanillla

robust bay Jun 19, 2024, 11:22 AM

#

so the proper solution would be adding a wood type finder for those specific woods, one that gives them the correct wood type. SInce they are leaves types they dont need to have a unique wood type each, they are indipendent

jagged oracle Jun 19, 2024, 11:27 AM

#

Should I still go ahead and find the wood types for those trees?

crisp elk Jun 19, 2024, 1:34 PM

#

The two that were sent have wood types that are vanilla, so it would just need a wood type finder defined

robust bay Jun 19, 2024, 1:40 PM

#

yup

jagged oracle Jun 19, 2024, 2:19 PM

#

So I suppose that would come with a later update then and I should wait?

maiden rampart Jun 19, 2024, 5:56 PM

#

i'm currently working on this.

maiden rampart Jun 19, 2024, 5:56 PM

#

robust bay so the proper solution would be adding a wood type finder for those specific woo...

that's a better solution

#

i did not think of this.

maiden rampart Jun 19, 2024, 11:11 PM

#

robust bay so the proper solution would be adding a wood type finder for those specific woo...

which class is wood type finder in? I can't recall

robust bay Jun 19, 2024, 11:11 PM

#

WoodType

#

i think

maiden rampart Jun 19, 2024, 11:14 PM

#

Moonlight??? alright

#

@robust bay
is this the one:

#

so the best place to use that code is in ChippedModule?

#

if i am wrong, what's the correct place to use that code. I'll have to do same with Biomes O' Plenty and its leaves

robust bay Jun 20, 2024, 8:00 AM

#

any place works

maiden rampart Jun 21, 2024, 1:22 AM

#

@jagged oracle
you can add the tag to here (the thread) with "solved"

it's fixed. and will be in v2.6.62

#EveryComp empty tag issues with Chipped and BOP leaves (1.20.1 Forge)