In the compiler core, what is ModuleInterface? | The Gleam Programming Language | Page 1

daring knoll Oct 4, 2024, 6:51 PM

#

I don't know if this is the correct place to ask, but I was doing hayleigh's bug bounty and I was fixing this TODO https://github.com/gleam-lang/gleam/blob/176334cd31dffd07c857db7a7066b6a032d5086f/compiler-core/src/build/package_compiler.rs#L85-L89. What is the difference between Module and ModuleInterface?

GitHub

gleam/compiler-core/src/build/package_compiler.rs at 176334cd31dffd...

⭐️ A friendly language for building type-safe, scalable systems! - gleam-lang/gleam

mental obsidian Oct 4, 2024, 7:02 PM

#

module probably contains everything, module interface probably only contains the stuff thats public

daring knoll Oct 4, 2024, 7:22 PM

#

For now, the only way I find to convert from one to the other would be to re-analyse the cached modules

#

Which I think is wrong

desert spindle Oct 4, 2024, 9:12 PM

#

That todo comment might be burying the lead on what the underlying issue here is. The ModuleInterface is essentially everything that is cached on compilation while the Module is the raw ast + the ModuleInterface. So the Module is the raw output of a fresh compile whereas a cache load will only have enough to create a ModuleInterface. The issue that hayleigh was asking about should theoretically be solved by changing how the package interface is created to use ModuleInterface information only instead of raw Module information plus whatever wiring you need to make sure you have all the ModuleInterfaces at the right time/spot

daring knoll Oct 4, 2024, 9:23 PM

#

desert spindle That todo comment might be burying the lead on what the underlying issue here is...

I'm basically making this

#

Also, why are there so many different types with the same names despair

winged ember Oct 4, 2024, 9:29 PM

#

Real

#

Good luck with this, I tried at one point but didn't get very far

daring knoll Oct 4, 2024, 9:30 PM

#

Maybe I need to add some info to the cache

#

hope it doesn't make it too bad

winged ember Oct 4, 2024, 9:31 PM

#

The main problem I ran into is type aliases

daring knoll Oct 4, 2024, 9:31 PM

#

Tbf I have basically no idea what I'm doing lol

winged ember Oct 4, 2024, 9:31 PM

#

Since those aren't really recorded anywhere in the ModuleInterface

daring knoll Oct 4, 2024, 9:32 PM

#

Which of the ModuleInterfaces? 🙂

#

I thought I had it done, then I saw they were from different modules

winged ember Oct 4, 2024, 9:33 PM

#

Oh right

#

The one that gets cached

#

Not the one that's part of PackageInterface

daring knoll Oct 4, 2024, 9:34 PM

#

The type_ one I think then

winged ember Oct 4, 2024, 9:34 PM

#

yeah

#

Basically you need to convert type_::ModuleInterface to package_interface::ModuleInterface, instead of type_::Module to package_interface::ModuleInterface

#

Or that's how I would do it anyway

#

But yeah, type aliases are annoying since the compiler mostly forgets about those after analysis

daring knoll Oct 4, 2024, 10:04 PM

#

I'm 99% it's done

#

Just hope I didn't quadruple the cache size

winged ember Oct 4, 2024, 10:05 PM

#

daring knoll I'm 99% it's done

Exciting! I was really hoping this issue would get fixed soon as it affects one of my projects as well

mental obsidian Oct 4, 2024, 10:06 PM

#

yeah i noticed

daring knoll Oct 4, 2024, 10:08 PM

#

Also, I think everyone will need to do a gleam clean if this is pushed

#

🙂

winged ember Oct 4, 2024, 10:08 PM

#

I believe it automatically cleans outdated cache now

daring knoll Oct 4, 2024, 10:09 PM

#

Well, I tried running it without cleaning the cache and it gave an error lol

#

Also, I need to remove a println!, it's spamming my console

#

It doesn't work despair

#


    Bincode does not support the serde::Deserializer::deserialize_any method```

#

So close

#

I wonder which type requires the deserialize_any

#

Found it, it's TypeInterface, as it's a enum

#In the compiler core, what is ModuleInterface?