Falling Damage for RPGB Third Person Controller

[neon bluff]

I've seen during the last few months many requests for this feature, so here's my solution, made of a single component you add to the character prefab(s).
UPDATED #1021444621882101780 message

It has tooltips in editor but there are a few things worth mentioning.

1. This addon requires the standard RPGB controller

2. Falling Damage Formula
Character Mass x Falling Velocity / Falling Damage Resistance.

"Character Mass" and "Falling Damage Resistance" can optionally be set via RPGB Stats, but doing so (while interesting) will likely increase the complexity of your setup exponentially. You should think carefully before going that route.

Stats if present have priority (you could change the mass at runtime but it would be reset)

By default, Character Mass is set at 70 (overrideable in the editor) and Falling Damage Resistance is set to the value of Jump Speed in RPGBThirdPersonController. 70 kgs seemed a reasonable default value and I figured the stronger you jump the better you land.

Falling Velocity is the vertical speed of the character as defined by RPGBThirdPersonController. I am not touching it since my goal was to make a component that would work with RPGB out of the box, and to toy with it I should ask you to modify at least one of the core files.

3. Falling Time Threshold
I wanted to add a threshold below which your character is able to ignore any falling damage. My first thought was a distance, but I found out a timer would be functionally equivalent and MUCH simpler to setup and use.

4. Falling Effect
Create and add an Effect in the RPGB Editor for when the character takes falling damage but doesn't die. Use this to trigger anything you wish.

Quality
The code works, but is to be considered little more than a proof of concept. It could be refactored and improved, feel free to share tips, they're all welcome.

[fathom ocean]

this is only for the build in controllers or is this also for the John Stairs MMO Controllers

[neon bluff]

Currently only RPGB default controller. I suppose I can work on a MMO Controller version in the near future, since the code is not that complicated.

That is, unless John reads this and decides to integrate it himself (probably doing a better job tbh)

[plush agate]

Interesting. I tried it out and character take damage when jumping of a 50m high cliff when timer set to .5 instead of 1.5. The effect of falling and not dying, does not play though...will experiment. Thanks

Also, can mass be left as none?

FallingDamage.OnStatsChangeUpdateMassAndResistance (BLINK.RPGBuilder.Combat.CombatEntity entity) (at Assets/Scripts/FallingDamage.cs:66)
CombatEvents.OnStatsChanged (BLINK.RPGBuilder.Combat.CombatEntity entity) (at Assets/Blink/Tools/RPGBuilder/Scripts/Events/CombatEvents.cs:122)
BLINK.RPGBuilder.Combat.CombatUtilities.UpdateCurrentStatValue (BLINK.RPGBuilder.Combat.CombatEntity entity, System.Int32 statID, System.Single amount) (at Assets/Blink/Tools/RPGBuilder/Scripts/Combat/CombatUtilities.cs:115)```

if optional, it should not gen an error right?

Suggest you add a soundtemplate we can set to let player cry out in pain or something?

[neon bluff]

Yes, in theory; but since I implemented the events later on, apparently I forgot to check whether it is null in those lines.

So thanks for pointing this out, I'll correct it

[neon bluff]

As for this, can you confirm you got damaged without dying? 'cause if you die, it won't trigger.

[plush agate]

Yep i got damaged down to 10% carried on running and did not die.

I like it though, so thanks for doing it 🙂

[neon bluff]

Weird, but I'll check it, thanks for notifying me

Meanwhile updated version upcoming, it should solve the errors festival... it does for me at least

OMG I deleted the original version, silly me

[neon bluff]

Thanks to you for checking it out ^_^

[neon bluff]

Btw, at least for me the falling effect works (as long as I don't die from falling) and I even tried that same effect for good measure. I'd love to find out what might have happened, so if you find any clue please let me know @plush agate 🙂

[plush agate]

I certainly will experiment more with it. Please ping me if you make any code changes/enhancements. So even with 0.5 delay you get your Shout effect to play then?

[neon bluff]

Well to be honest I didn’t test 0.5 delay, but I’d be very surprised to find out it makes any difference.

I’ll be home in… idk 1/2 hour or so, and will let you know the result.

I cannot be 100% certain I won’t find a weird bug or a silly mistake. 😅

Does it work for you if you extend the delay to something higher (like the default value)?

[plush agate]

will try, but can't right now

[neon bluff]

No worries, take your time of course; btw 0.5 threshold changes nothing for me

[plush agate]

I tried with .75 delay and two effects, none play for me, just fyi. i do get the falling damage of course.

[plush agate]

Another odd thing for me is that with your script active, npc cannot actually kill me, my health go to 0 but player still stands there and can move. when i disable your script, player does die as it should by npc attacks.

so i disabled it for now since it also throws a bunch of errors for the NONE slots as you know.

[neon bluff]

Mmm. Weird, since the errors should be corrected after the last change. Have you replaced the script with the last version?

Btw, I can’t imagine the reason for these bugs. None of those is even remotely expected, but I guess you live and learn. I haven’t tried fighting with the script on but I’ll try within an hour or two to double check.

Just to be sure: are you on the latest RPGB version?

[neon bluff]

As I imagined, I cannot replicate any of the issues. I now suspect there's a bug due to the interaction of the script with something else. Which MIGHT be fixable on my end, but I have honestly no clue what it could be.

[plush agate]

Version 2.0.6 and most current unity lts version. let me know how the fighting goes with script on yes.

[neon bluff]

Fight goes exactly as shown in the above video 😅
I can be hit and die, no problem.
Also I can take damage and trigger an effect.

[plush agate]

Well, not sure why mine is not working. show a screenshot of your settings please.

and which values/effects you used.

[neon bluff]

It works exactly the same with literally any combination of settings and effects I've tested, including the one you shared, that's why I'm very surprised

[neon bluff]

For example, this works

For me at least

[plush agate]

it is weird for sure.

could be a tag/layer issue?

on my side

[neon bluff]

Mmmm... idk, but seems unlikely.
Is there anything non-default about your Health Stat?

[plush agate]

and do you get console errors for the ones that are none?

no not at all, health stat is normal

[neon bluff]

This version I shared yesterday should correct those errors

#1021444621882101780 message

[plush agate]

ok let me get that version now, thanks

i am going to test the updated version now.

[neon bluff]

Great let me know, and if you have errors (new or old lol) pls share them so that I can have a look

[plush agate]

Hooray! The new version works and effects plays! with 1.5 delay.

[neon bluff]

That's relieving, does 0.5 delay work tho? I would expect it to work, but never say never 🙂

[plush agate]

I will try a bit later with 0.5 as well, but works with 1.5 for sure.

Yep 0.5 works fine as well 🙂

UnityEngine.Debug:Log (object)
FallingDamage:OnControllerColliderHit (UnityEngine.ControllerColliderHit) (at Assets/Scripts/FallingDamage.cs:135)
UnityEngine.CharacterController:Move (UnityEngine.Vector3)
BLINK.Controller.RPGBThirdPersonController:UpdateState () (at Assets/Blink/Tools/RPGBuilder/Scripts/Controller/RPGBThirdPersonController.cs:203)
BLINK.Controller.RPGBThirdPersonController:LateUpdate () (at Assets/Blink/Tools/RPGBuilder/Scripts/Controller/RPGBThirdPersonController.cs:183)```

so it looks like there are no issues any longer. Thanks again for support.

[neon bluff]

No worries, I'm happy to hear it's working for you.
It is unlikely that I'll ever publish major changes to it, unless the RPGB controller gets wildly modified.
Minor changes or refactors will be posted here of course.

[plush agate]

excellent. hope you come up with many other enhancements to rpgb. one thing I wish for is that my pet/companion would follow me from Scene A to Scene B and be persistent, but that is not currently possible as far as I know...

[neon bluff]

That sounds beyond my current level but we’ll see 😅

Anyway tbh I am more likely to share scripts that won’t require changes to the core code, or minimal changes (like adding one line)

[plush agate]

I understand, it is a pain to keep track of core code changes and might not work in future versions, so make perfect sense.

[neon bluff]

That, AND the fact that asking people to copy paste code (and possibly customising bits of it) could go south FAST.

I’d realistically need to override core files with new versions and the deeper the changes, the more chances of bugs I’d have over time.

It should be worth it; if I’ll ever make something cool enough to be worth the hassle, I’ll think of it 🙂

[neon bluff]

I’m looking into that now, I’ve never messed with his code but it seems to be a relatively simple job, let me toy around with some code and MAYBE I’ll have something by the end of the week 🙂

My main issue (considering the low complexity of the task) is time, but I’ll do it 💪

[solemn nova]

@neon bluff
I hope this is the correct post :).

So I was testing John's controller and your fall dmg script. This is about jumping so it's not directly connected to your script but I was wondering if it could be added nonetheless since you already have a RPGB stat connection in it :).

John has a preset parameter for midair speed. (picture 1)
Currently you can only preset it to X. If you walk or run ingame and increase those movement stats you move quicker. However this midair setting will always be the preset amount. So you can run at speed 100 but if you jump you will slow down to this preset speed of 5. That looks weird/clunky.

So I was wondering if it would be possible to also make this midair setting into an RPGB stat like you did with jump height (picture 2 as a simple example).

[neon bluff]

it is possible, it is also going to be simple is that value is public rather than just serialised, this is something I'll need to check

As for the general clunkiness you were describing, is there anything specific I should check/improve in your opinion? 🙂

[solemn nova]

There is no general clunkiness :). At least not that I found up to now. 🙂 Just the running and then slowing down clunkiness haha.

[solemn nova]

Great to hear that it it's maybe possible. Of course this is the easy fix. It would still give a static number.
If walk is 5 and run is 10.
You could either set midair speed to 5 or 10. It won't be dynamic based on the current movement speed. I know this would make it way more complex. So I would already be happy with the first option where it would be static ;).

[neon bluff]

Ok I was worrying a bit there XD

[neon bluff]

Theoretically, any numerical value can be tied to a stat, and that includes walking speed, midair speed, and more. So it could be made dynamic.

The only thing I need is to check whether or not that value is public or not. If it's not, I can still modify it with some black magic but I'd rather ask John to set it to public instead

Give me some time since I masochistically started a project that is taking away all of my free time, and then this is going to be added to my todo list 🙂

[solemn nova]

okay awesome! Please keep me posted when you can 🙂

[neon bluff]

Sure. And look, I know myself, if you don't hear anything for more than a few weeks, chances are I've forgot this. Ping me in that case, ok?

[solemn nova]

xD will do!
And might I find some other things that would be cool to add also I will let you know too. Getting all the basics down for the game atm, so who knows what other things I might be missing (or wish I had haha) 😛

[neon bluff]

I will always listen to suggestions. Sometimes I'll make promises, sometimes I'll just promise that I'll try.
Very rarely I've said no, for one reason or another. But this should be so simple that there would be no point in denying you it 🙂

[solemn nova]

"so simple" I like the sound of that 😄

[neon bluff]

And this is the story of Min finding out it took 7 years to do it

[solemn nova]

HAHA

[solemn nova]

@neon bluff I thought of an addition. Simular to my other request.
A way to change the max times a player can jump. Now John has a predefined way to do this in the controller. It would be awesome if it would be possible to set default to 1 in the controller and then be able to use an RPGB stat to make it 2 or 3 etc. This is more a nice to have for me, but I would surely use it in my game if I would have it 😉.

[neon bluff]

Should be doable, when I’ll be back to these older scripts I’ll check if it’s going to take five minutes (as I think) or five hours 🤣

[solemn nova]

Awesome, hope 5 haha! 😄

[solemn nova]

@neon bluff 1 other thing I found out today (possibly a bug) is that the speed of falling is different if you fall from an object compare to when you jump.

The available options in your script don't allow me to change that fall speed or am I missing something? (Did a few tests but nothing seemed to changed).

If I remove your script it does work as intended, so it has to be something in your script I guess?

[neon bluff]

I can’t remember having done something actively to the falling speed but I can surely check and let you know.

[solemn nova]

Cool thanks 🙂

[fathom ocean]

isn't the mass a factor here if you have mass will that not also effect the gravity

m just saying

i have no clue

may be this can be set to lower numbers to see if it dos anything @solemn nova

[solemn nova]

I would expect that also. But changing those settings to 1000 or 1 doesn't seem to effect the jumping (not the regular jumping nor the falling from an object).

[neon bluff]

no

IIRC that is

But mass should only be used to calculate damage

I'll check asap guys, I'm finishing a BIG thing, please be patient 🙂

In fact I just quick checked the script directly from discord and I can't even see any reason why the script should do something to the fall speed. It reads it, but never changes it.

@solemn nova do you also have something else in your project that could interfere?
@fathom ocean have you experienced the same thing?

[solemn nova]

It's okay take your time 🙂

[neon bluff]

Wait since you use John's controller, you used THIS ==> #1027958068362879066 message
Right? Because this chat is the one about the falling damage for RPGBThirdPersonController and I realised that only now

[solemn nova]

Doing some more test now. 1 quick test made it look like the character with John's controller but without your script made the falling look normal. I'll do some more tests

[neon bluff]

On that script there might be something, the jump strenght stat. If John changed anything in the controller, since my script is a bit dated, there might be a bug potentially

[solemn nova]

Didn't know there are 2 almost the same addon channels haha.

This is the script so it's from the other channel 🙂

So the requests are also for the other script and not this 1 🙂

My bad

[neon bluff]

No worries, anyway I think I'll start checking the jump stat

[solemn nova]

Hmm did some more tests, and now it looks like it's this way always (so also in John's basic controller).

[fathom ocean]

np no rush for me, like i sad i was just trying to help him with his problems, how it is set up right now, is what i need works fine for me

😅

[solemn nova]

When your on a platform and you jump off it's a normal falling speed? (compare to a regular jump and fall speed)?

HMMM think I might have found something. 1 sec gonna do a little more testing.

I can consistently fall normally and also not normally.

Normal =
Walk to the very last millilitre from the platform and give a minor left/right button tab so you fall off.

Not normal =
Just walk off pressing+hold left/right

Did test it with 3 characters.
John's basic character and John's basic + your script give the same results. As described above.

Blink character controller = always normal.

@neon bluff
So I don't think it's something caused by your script but in John's script. Still makes me wonder how can it work properly with @fathom ocean . Since hes using John's + your script if I recall correct.

[fathom ocean]

i have no problem the way it works right now i am fine with it, this is cos you dont like the way the jumping works in this controllers for me its fine the way it is

[solemn nova]

I like the jumping and the plugin made by Min. But I don't like the falling when I walk from a platform or something. That speed should be similar to the regular jump + fall speed if you ask me :).

[flat ore]

@solemn nova just reached level 7!

[fathom ocean]

@solemn nova try play around with the settings also the character controllers gravity can be a factor here

[solemn nova]

Thanks for the video. However if I move like you do in the video it also works 100% for me. The problem occurs when you walk off a elevated platform (not when you jump off). Could you also try that for a sec plz?

[fathom ocean]

here from longer falling distance

[fathom ocean]

@solemn nova i have a question did this work before the new Patch cos i also experience some ode stuff happening when John updated the last patch, but its not with jumping more other stuff, but maybe this can be the problem

[solemn nova]

No idea, I just started to use John's controller. Used RPGB before. But since I wanted to be able to modify jump height I moved to John's and Min's script :).

[fathom ocean]

dos this also happen with out the falling damage script

[solemn nova]

yeah

[solemn nova]

It doesn't happen with RPGB's controller. Only with John's (with or without Min's script).

[fathom ocean]

k i found the problem

i will recode to show

[solemn nova]

nice! Also know a way to fix it? 🙂

[fathom ocean]

this is the problem like i tried to explain to you before

[solemn nova]

I'm gonna test it right now awesome! 😄

[fathom ocean]

pls don't get up on those numbers this will pull you right down

[solemn nova]

Lol something so simple. You rock!! Thanks a lot, mine was on 100 lol. Adjusted to 10 now, and works just fine!

[fathom ocean]

@solemn nova if you had listen first time when i try to help would save you like hours #1008698695656689788 message 😀

[solemn nova]

@neon bluff sorry to have bothered you with this none problem.

[fathom ocean]

i tryd to help but you must have missed the post

😅

[solemn nova]

Yeah I kinda did lol dumb me :(. Really sorry about that

[fathom ocean]

hey it happens to me all the time no bigey

dont be sorry

it happens

so much stuff to keep track of some time it will blow up or faces

😅

its normal

[solemn nova]

yeah for sure haha. But I must say seeing a little into your game is also awesome! Your kicking it! 😄

[fathom ocean]

a thanks buddy, just started to work on this map

[solemn nova]

I can only say keep up with this great work! Looking forward to a release to see the full content!

[neon bluff]

Thanks @fathom ocean I was starting to lowkey worry about this XD

[solemn nova]

You want me to move my 2 request to the correct post/channel?

[fathom ocean]

np falling damage script works as attended, m enjoying it so much cant tank you so much 💪 you rock

[solemn nova]

Agree even though I'm using the falling script to keep falling dmg on 0 and use it for it's other functions 😄

[fathom ocean]

yepo amazing scripts, he is good like that min taking time to help out community ❤️

[solemn nova]

But same goes for you, aiding the community!

[neon bluff]

I don't think it's necessary 😄

And thanks to both for the kind words, I hope to get better and better. Sharing helps in this 😄

[solemn nova]

True, having other ppl test your stuff makes it better for sure.

[fathom ocean]

@neon bluff sorry to bother, when you find some time, can you look in to the falling damage script you made, here is the question would it be possible for you to ad falling damage on distance, what i mean by that you already have added it only one part missing is the damage is always the same no meter the distance falling, Like lets say i fall from 30 meter's or 10 meters that would have a huge impact on my HP, but now no meter how tall my fall is i always take same damage, so if i am falling from 30 Meters Or 10 Meters the damage is the same

anyway as always not rush TY 💪

[neon bluff]

It could be done, right now iirc it’s based on impact velocity. (not at my pc and I haven’t looked at it in a while so I’ll check)

Which is ALMOST the same in theory, except when you hit terminal velocity the damage stops increasing.

I could probably add a selection for how to calculate it. Distance, velocity, time… and that’s it, those are pretty much the only three ways to calculate it 😂

BTW please try to use the right chat, this is for the RPGB controller (which BADLY needs an update asap anyway lol)

No problem of course, just a tip for the future 🙂

[fathom ocean]

its giving me this so i tooth its the right channel

is that not the addon

[neon bluff]

TADAAAN 🤣

[fathom ocean]

so you are saying its already possible, but how is it not working for me then if i just form higher ground its same damage i get

[neon bluff]

I’ll rename this chat to make it clearer, it’s my responsibility to keep it simple 🙂

[neon bluff]

No I’m saying this is going to be a thing since it doesn’t sound hard to achieve 🙂

BUT

[fathom ocean]

aha

now i get it

😅

[neon bluff]

If there’s a field like “maximum falling speed” in John’s controller, try messing with that, it should also affect falling damage

[fathom ocean]

i think we are aloud to talk about it in here if m correct

[neon bluff]

Don’t overdo it, or if you fall from high enough you’ll go fast enough to pass through colliders

[fathom ocean]

this is bean added by support

[neon bluff]

Of course we are, but for organisational reasons I’ll ping you in the “right” chat

The script here has about half the functionality and is for the default controller, I’d like to avoid confusion for other users

[fathom ocean]

understood 🤘

makes sense

[solemn nova]

ping 😉

Or am I to quick?

[neon bluff]

Only slightly 😂
I’m almost done with most other things, I think I might have a look at this

[neon bluff]

Falling Damage for RPGB Third Person Controller