Localisation Framework

[serene basin]

just a few

guess i'll make a PR to swine's fork, cus i havent seen tge online in a millenia

[gleaming shale]

wanna point out this too

its used by compiler if you dont put the exact name of the encoding

[serene basin]

yeah i realized they exist now so im updating

[gleaming shale]

as an aside, i noticed these presumably wrong characters when posting this event to tumblr but idk enough japanese to know what they should be

[serene basin]

should be all i think

https://github.com/AnimatedSwine37/Atlus-Script-Tools/pull/2

my pc did the "funny" thing where the gpu craps out and restarts the whole system, can someone double check this for me in the meantime

[serene basin]

unnecessary lore yap, I was working on this earlier https://github.com/DeathChaos25/P5NameTBLEditor/issues/2 which is why I noticed all the missing enum values and then the power went out for a bit while i was in the middle of working on it

[serene basin]

apparently i missed p5_korean

[whole lagoon]

I just made P5R_Korean too which didn't exist but I didn't post it anywhere but here. (see above)

also idk if this is a bug with your tool or the script tools in general but it still happened

though my request I was initially thinking of allowing for custom charsets too just based on filename

[glacial parcel]

its a really easy fix on astgui's part, just change the hardcoded options to match the names of the actual ast options

which is what i did, i just cloned astgui and changed the options

opened an issue on astgui's gh as well but it is most definitely not an ast compiler issue

[gleaming shale]

it literally is, it just passes commands to script compiler

[glacial parcel]

yes and the problem is its passing the wrong command

[gleaming shale]

that doesnt make it not a wrapper

[serene basin]

unfortunately that complicates things a bit more

thats beyond my pay grade

[glacial parcel]

okay but now this is just semantics

which doesnt matter

[serene basin]

although i can add p5r_korean tomorrow

if you need more you'll have to replace p5_korean or something i guess

[whole lagoon]

Yeah don’t worry about it

[glacial parcel]

atp im not sure if tge is ever going to accept the PRs for AST so would it be worthwhile to just have someone active in the modding community fork it and merge the PRs and then use that as submodule for bmd merging/whatever

i've been sitting on the CHS localization for protag sumi for about a year now

[gleaming shale]

i pinged them like last week bc i made another pr lol and so far nothing,,

so...

[glacial parcel]

idt theyre interested in maintaining it anymore

@gleaming shoal

also ideally multiple trusted modders should have push access to the fork

[gleaming shale]

should it be under the persona-modding org then?

[glacial parcel]

yeah that seems like a good idea

[gleaming shoal]

Yeah, I agree. I'll see if I can make a fork under the persona modding organisation tonight and we can go from there

[glacial parcel]

Awesome!!

[gleaming shoal]

You can just fork to an organisation which is nice. Here it is https://github.com/Persona-Modding/Atlus-Script-Tools

I didn't realise it'd been over a year since tge touched his, it's definitely fair to just move away from it at that point imo

[gleaming shale]

should i just make my prs again to this one or

[gleaming shoal]

Yeah

[gleaming shale]

alr went and did that

[glacial parcel]

CHS might finally work 🥹

[gleaming shale]

@upper wren and @alpine latch since you also have open prs on upstream

[gleaming shoal]

Cool, I don't really want to review it rn but I will at some point soon. Or someone else could if they want to

Never done this before, but I've set it up so prs require at least one person to review before they can be merged. Rn the only peeople are you and me but I'm happy to add more people who know stuff and can be trusted. That way hopefully there's never a point where a single person can just hold up everything for a huge amount of time/forever

[alpine latch]

I haven't used github a lot so might be a skill issue but i think it only lets me fork the repo?

[gleaming shale]

youre not directly pushing to repo, you want to pr again but to persona-modding repo

[gleaming shale]

ill prolly make a femulator pr too once those are merged, i already made a branch to test the procedure/message one with bf emulator

[glacial parcel]

Yeah I was gonna ask if someone could change the submodule from tge's ast to the new fork

[upper wren]

Done https://github.com/Persona-Modding/Atlus-Script-Tools/pull/4

[alpine latch]

yeah, but to pr didnt you have to make a new branch and then request to merge it with main?

[gleaming shale]

didnt you already make a branch

[alpine latch]

i tried but it told me i didnt have write permission or something, and kept prompting me to fork it

unless it did work lol

[gleaming shale]

you already have a fork

[upper wren]

all you need to do @alpine latch is click the new pull request button on the pull requests page, then change the head repository to yours, then set it to compare against your P4G-Spanish-Fix branch, then change the base repository to the Persona-Modding one and you can create the pull request

(screencrops for refrence)

[gleaming shale]

motherfucker i was trying to assign myself to review #4 but github freaked out and i accidentally requested it from swine instead

gonna be honest ive never done review through github before

nvm got it

[upper wren]

oceanstuck trying to commit identity fraud.... say it ain't so /j

[glacial parcel]

[gleaming shale]

oh i was hoping for swine to merge my prs first, i can do it now though

[glacial parcel]

honestly as long as a release gets pushed out soon that includes the new ast that'd be nice

just really want zh-hans to actually work 😭

[gleaming shale]

https://github.com/Sewer56/FileEmulationFramework/pull/35 alr i think sewer just has to merge i think

[glacial parcel]

[alpine latch]

ohhh thank you!!

[upper wren]

Lol and of course tge finally becomes active and reviews all the PR's on upstream AST after all this 😭

[alpine latch]

my email is funny asf rn bc theres one saying that the pr on the new one got merged followed by tge replying to the original one asking what its for

[gleaming shale]

i was about to fucking say

lmao

whos gonna tell him

[upper wren]

loool

At least in my PR's case he did have some pretty good points about it though so assuming he stays active I'll probably try and work out the quirks for hopefully a better version of what I was attempting to fix

After all the pmodding fork is a fork so the changes to tge's original repo can always just be downstreamed

[upper wren]

(Which is to say he brought up the idea of versioning the libraries which in the case of the name/alias conflict issue I found when I was updating the P3P library would actually be a cleaner solution albeit one that I might lack the skill to just Do myself)

[gleaming shale]

yeah he did do a review of my value equality pr, i didnt realize i had a bunch of commented out unused code idk how they got there

though he does bug me about turning an interface into an abstract class when i couldnt get the behavior i needed to work as an interface lol

inb4 i look at it with fresh eyes and immediately see a cleaner way

[upper wren]

On this note if TGE's not already in the pmodding org on github maybe he could just be added to it and then everyone can for sure migrate over to that fork as the "main" repo... It would still give us the advantage of not having development stall when he's inactive and it would make it less likely for people to get confused on which version to use (since the one that's more active would naturally be the one people gravitate to over time)

[gleaming shale]

lmao bro asking what the procedure overwrite pr is for when i literally explain it

[gleaming shale]

i left a comment reexplaining the "two mods hooking same procedure" issue, im too tired rn to go through the whole review for the value equality pr though

[glacial parcel]

is anyone able to push a release for fileemulationframework bf/bmd emulator containing the new prs 👉 👈 im not sure if only sewer is able to

i think itd also be nice for the new ast prs to get merged too

having no procedure overwriting is pretty miserable

[serene basin]

wouldnt it be bf emulator specifically

[glacial parcel]

itd be bf, bmd, and maybe localization framework

[gleaming shale]

i will when theyre merged into script tools 🫠

[gleaming shoal]

that's on tge now isn't it, or were you waiting for me to merge to the fork?

[gleaming shale]

he requested changes for the value equality pr and is suggesting some shit i dont know how to do for the procedure overwriting

[gleaming shoal]

Also, yes I think sewer is the only one with write access to the file emulation framework repo. I only have the persona essentials one afaik

[gleaming shoal]

Ah, ok 🫠

[glacial parcel]

@sacred vapor

[sacred vapor]

Aight

[glacial parcel]