Game crashes when singular mod is enabled despite lack of changes between previous launches | Persona Modding | Page 1

fading saddle Apr 20, 2024, 1:47 AM

#

This is a repost of @hybrid gulch's issue on Github so we don't need to try and talk through github comments 😄
https://github.com/Reloaded-Project/Reloaded-II/issues/363

GitHub

Bug: Game crashes when singular mod is enabled despite lack of chan...

Describe the Bug Game crashing due to singular mod despite lack of changes between testing. To Reproduce Steps to reproduce the behaviour: Go to (https://github.com/BonQerss/p3ppc.expandedsubmenu) ...

#

So when is it actually crashing? Does the game actually load or is it before that?

hybrid gulch Apr 20, 2024, 1:48 AM

#

it loads slightly

#

never gets to the loading icon though

#

but it loads some files

fading saddle Apr 20, 2024, 1:48 AM

#

So it gets to a black window for a second?

hybrid gulch Apr 20, 2024, 1:48 AM

#

yeah yeah

#

my working theory is that its dying on init_free.bin or some other init.bin file

fading saddle Apr 20, 2024, 1:49 AM

#

Possibly

hybrid gulch Apr 20, 2024, 1:49 AM

#

the annoying thing is that it appears to be working fine for moddaman and brawler soooooooo

fading saddle Apr 20, 2024, 1:49 AM

#

I just noticeed the log has P5R Library loading

hybrid gulch Apr 20, 2024, 1:49 AM

#

oh is that not normal

fading saddle Apr 20, 2024, 1:49 AM

#

I doubt it's the problem but could you try and make it not do that

#

Well this is p3p so idk why you'd load p5r lib

#

Is it a bgme thing or something?

hybrid gulch Apr 20, 2024, 1:50 AM

#

i feel like its always done that

#

maybe

#

might be because of persona essentials

#

one second

fading saddle Apr 20, 2024, 1:50 AM

#

Nah, it's not a dependency of persona essentials

hybrid gulch Apr 20, 2024, 1:51 AM

#

this is my entire enabled mod list so i'm not sure what else it could be

fading saddle Apr 20, 2024, 1:51 AM

#

I'm pretty sure it'd be bgme

hybrid gulch Apr 20, 2024, 1:52 AM

#

ok expanded bgm collection off

📎 2024-04-20_01.51.32__P3P.txt

fading saddle Apr 20, 2024, 1:52 AM

#

Like I said it's most likely not a problem but it's worth checking just in case

#

I assume that means it still crashed?

hybrid gulch Apr 20, 2024, 1:52 AM

#

yup 😔

fading saddle Apr 20, 2024, 1:52 AM

#

alright

hybrid gulch Apr 20, 2024, 1:52 AM

#

it only stops crashing when i disable ESM

fading saddle Apr 20, 2024, 1:52 AM

#

does the game produce a crash dump?

hybrid gulch Apr 20, 2024, 1:53 AM

#

it should....

#

where are those again?

#

in the game folder?

fading saddle Apr 20, 2024, 1:53 AM

#

Yeah

#

crashdat/bd/reports

hybrid gulch Apr 20, 2024, 1:53 AM

#

📎 8bf355e1-c4d1-4c0b-8f0e-07aab51cd776.dmp

fading saddle Apr 20, 2024, 1:53 AM

#

nice

#

Oh cool, it crashes for me as well

#

That should make things easier

hybrid gulch Apr 20, 2024, 1:57 AM

#

:OOOOO

#

ITS NOT A BONQ ISSUE

#

fading saddle Apr 20, 2024, 2:06 AM

#

It is dying trying to load some file, I think it's probably init_free.bin

#

This might be the same issue as before that I just never fixed

hybrid gulch Apr 20, 2024, 2:08 AM

#

oh wow

#

so it's related to the pac merging bug

#

because fixing that would be uber cool too 😎

#

can't add Auto Heal to ESM without it

fading saddle Apr 20, 2024, 2:09 AM

#

Yeah it's definitely a problem with init_free.bin

hybrid gulch Apr 20, 2024, 2:12 AM

#

man so question

#

the fact that its working for brawler and moddaman is because of them not clearing their cache, yeah?

fading saddle Apr 20, 2024, 2:13 AM

#

Maybe naotoshrug

#

Could we get them to clear the cache and try

hybrid gulch Apr 20, 2024, 2:15 AM

#

@serene sage hey pookie, come clear your cache

serene sage Apr 20, 2024, 2:19 AM

#

hybrid gulch <@229072191746998272> hey pookie, come clear your cache

fading saddle Apr 20, 2024, 2:19 AM

#

🙃

serene sage Apr 20, 2024, 2:20 AM

#

made sure I pulled the latest changes from the repo, built the mod and made sure my cache was cleared and it just worked for me 🫠

fading saddle Apr 20, 2024, 2:22 AM

#

That's weird but at least it's crashing for me, it would be a real pain if it wasn't

woeful stream Apr 20, 2024, 3:11 AM

#

i have not tested in a while. i will take a look soon(TM)

#

i need to pull the latest changes and rebuild

fading saddle Apr 20, 2024, 3:27 AM

#

I think I've found the problem, it seems some extra 0s need to be appended to the end of a pak file

#

Basically it seems like the game tries to read the header of the next entry but dies because that memory isn't initialised

hybrid gulch Apr 20, 2024, 3:28 AM

#

wasnt that the solution moddaman said about the dng_init.pac thing

serene sage Apr 20, 2024, 3:28 AM

#

^^

fading saddle Apr 20, 2024, 3:28 AM

#

If I am correct about that then it's pure luck that any emulated pak file works at all

#

Oh was it?

hybrid gulch Apr 20, 2024, 3:28 AM

#

yeah like

fading saddle Apr 20, 2024, 3:28 AM

#

lol

#

I don't remember

hybrid gulch Apr 20, 2024, 3:28 AM

#

they told you back in mid march 😭

#

maybe earlier.....

velvet mantleBOT Apr 20, 2024, 3:28 AM

#

Some Schmuck

didn't seem to be the issue in P3P PC from my testing

literally all i did was just:

enable PAK Dumping in PAK EMU
test loading it through the CPK folder to see if the file itself is bad (it was)
add 0x100 padding bytes at the end of the dumped file
re-test loading it to see if that fixed anything (which it did; i literally didn't touch any of the other bytes, so if the version number is different on p3p pc that doesn't seem to actually matter funny enough)

Jump

[Go to message!](#p3-modding-chat message)

fading saddle Apr 20, 2024, 3:29 AM

#

Did I try doing that?

hybrid gulch Apr 20, 2024, 3:29 AM

#

LATE JANUARY

fading saddle Apr 20, 2024, 3:29 AM

#

Sorry...

#

Well I've independently come to the same conclusion by reverse engineering some of the pak loading code 🫠

serene sage Apr 20, 2024, 3:30 AM

#

It's alright man we all forget to get around to things sometimes haha 😅

#

And hey since you did some RE on the actual code you probably have a better idea of how it's supposed to work anyways (hopefully lol)

fading saddle Apr 20, 2024, 3:32 AM

#

It is just meant to be a bunch of 0s at the end it seems. I think what you said back then is exactly right

hybrid gulch Apr 20, 2024, 3:32 AM

#

i can add auto healing now 😭

#

bob bless

fading saddle Apr 20, 2024, 3:32 AM

#

Well at least it should be an easy fix

hybrid gulch Apr 20, 2024, 3:33 AM

#

still doesn't explain why it works why it works fine for moddaman naothink

fading saddle Apr 20, 2024, 3:33 AM

#

Pure luck

hybrid gulch Apr 20, 2024, 3:33 AM

#

he's got that anti bonq curse

fading saddle Apr 20, 2024, 3:33 AM

#

The memory after the file just happens to be allocated with something

#

The fact that any emulated pak file worked is complete luck

hybrid gulch Apr 20, 2024, 3:34 AM

#

its crazy that it just decided to break on me now

serene sage Apr 20, 2024, 3:34 AM

#

Honestly that would explain that from what i remember even files that did cause crashes in the past could still have a small chance of working rarely; if it's just pure luck eventually the memory will just happen to align correctly 😅

hybrid gulch Apr 20, 2024, 3:35 AM

#

crazy that out of all the mods i ever made

#

this one finally broke it

#

well besides FER

fading saddle Apr 20, 2024, 3:36 AM

#

velvet mantle

Looking back at my reply to this it seems like I really should've fixed the problem. I guess I just never tried appending the padding for some reason

woeful stream Apr 20, 2024, 3:55 AM

#

hybrid gulch he's got that anti bonq curse

#

well it's good that this has been fixed. i was about to go take a look and see if it crashed for me but it seems there's no need for me to test rn

hybrid gulch Apr 20, 2024, 3:57 AM

#

well thank god it got fixed now

#

got a long weekend ahead of me

#

so i can actually devote some time to working on this

fading saddle Apr 20, 2024, 4:02 AM

#

It's not actually fixed yet, I still have to work out how to add the stuff at the end (the pak emulator code is confusing)

#

There we go, I think I've fixed it

#

Could you try using this pak emulator

📎 reloaded.universal.fileemulationframework.pak.zip

#

With it I no longer crash

hybrid gulch Apr 20, 2024, 4:19 AM

#

uh did you mean to leave debugging on lol

#

fading saddle Apr 20, 2024, 4:20 AM

#

Oh woops

#

📎 reloaded.universal.fileemulationframework.pak_2.zip

#

You'll need to clear the cache from the previous version so the files actually rebuild

hybrid gulch Apr 20, 2024, 4:21 AM

#

WERE IN

fading saddle Apr 20, 2024, 4:21 AM

#

Nice

#

I wonder if this fixes those other crashes with p3p as well

hybrid gulch Apr 20, 2024, 4:22 AM

#

#

yeah i probably should test auto healing

fading saddle Apr 20, 2024, 4:22 AM

#

That still says custom sub menu btw

hybrid gulch Apr 20, 2024, 4:22 AM

#

im deadass fixing that rn 😭

fading saddle Apr 20, 2024, 4:22 AM

#

You could've used the name if you wanted but I see you switched to expanded sub menu

hybrid gulch Apr 20, 2024, 4:23 AM

#

yeah i felt weird copying the name

fading saddle Apr 20, 2024, 4:24 AM

#

I wouldn't care, it does do essentially the same thing

#

I guess the other people who worked on it might feel different but I kinda doubt it

hybrid gulch Apr 20, 2024, 4:24 AM

#

ok time to test auto healing before we close this

#

bruh why is it dying on a mod i publicly released

fading saddle Apr 20, 2024, 4:26 AM

#

What's breaking now?

hybrid gulch Apr 20, 2024, 4:26 AM

#

something about a stream offset pair

#

📎 2024-04-20_04.26.27__P3P.txt

#

the error is like

#

half red and half blue lol

#

goes away when i disable ESM so i probably fuuked something up

#

oh wait

#

i know

#

field.flow shenanigans

#

we gucci

#

testing time

fading saddle Apr 20, 2024, 4:28 AM

#

Ok good

hybrid gulch Apr 20, 2024, 4:28 AM

#

also i have to ask

#

sewer mentioned it

#

but it's not normal for the controller to return null in all of my logs?

fading saddle Apr 20, 2024, 4:28 AM

#

No it shouldn't

#

Idk what that's about

hybrid gulch Apr 20, 2024, 4:28 AM

#

yeah idk either

fading saddle Apr 20, 2024, 4:28 AM

#

It's completely unrelated to this though

hybrid gulch Apr 20, 2024, 4:28 AM

#

hasn't broke anything yet

fading saddle Apr 20, 2024, 4:29 AM

#

I've seen it in people's logs before but it never seems to actually cause problems so I haven't bothered trying to find the cause

hybrid gulch Apr 20, 2024, 4:29 AM

#

seems like it didn't fix the dng_init.pac bug 💀

#

either that or party organize is broken

fading saddle Apr 20, 2024, 4:30 AM

#

What was that bug again? Does it just crash when loading the file?

hybrid gulch Apr 20, 2024, 4:31 AM

#

yeah randomly

#

not even sure if its when it loads the file

#

seemingly only when it loads "check_party_member"

fading saddle Apr 20, 2024, 4:33 AM

#

Yeah I vaguely remember it. I don't think I really had any notes on it though

#

I think I came to some kind of conclusion but I don't remember what exactly

hybrid gulch Apr 20, 2024, 4:34 AM

#

no.....

#

still crashes

#

just went up the stairs and the game crashed

#

do you want the crash dump?

#

that's super weird

fading saddle Apr 20, 2024, 4:35 AM

#

Sure

hybrid gulch Apr 20, 2024, 4:35 AM

#

📎 db3476bd-e02a-4c72-8c43-2c7373e1ba26.dmp

#

weird stuff

#

moddaman came to that conclusion while fixing auto healing so i'm surprised it isn't working

fading saddle Apr 20, 2024, 4:36 AM

#

Huh, interesting

#

I'll see if I get the crash as well

#

Seems fine to me

#

What specifically did you do to make it crash?

hybrid gulch Apr 20, 2024, 4:39 AM

#

climbed stairs after warping from a tartarus guardian floor

#

fought 5 battles

#

climbed stairs again

#

crash

fading saddle Apr 20, 2024, 4:39 AM

#

Oh I just crashed at the end of a battle

hybrid gulch Apr 20, 2024, 4:39 AM

#

oh

#

well that too

fading saddle Apr 20, 2024, 4:39 AM

#

Is that when it's happening?

#

Oh is that different?

hybrid gulch Apr 20, 2024, 4:39 AM

#

that's how most people reported the issue

#

that it was crashing after battles

fading saddle Apr 20, 2024, 4:40 AM

#

ok

hybrid gulch Apr 20, 2024, 4:40 AM

#

but that didn't happen to me just now

#

the auto healing actually worked and healed people

fading saddle Apr 20, 2024, 4:40 AM

#

I guess I'll see if I can fix that too

hybrid gulch Apr 20, 2024, 4:40 AM

#

so it's definitely not something about the file being loaded

#

its something to do with a specific procedure

#

i think at least

fading saddle Apr 20, 2024, 4:42 AM

#

My crash is something to do with starting bgm if I've got this function labelled right. It's dying on that string format

#

I didn't check your crashdump but presumably it's the same

hybrid gulch Apr 20, 2024, 4:44 AM

#

starting bgm?

#

i don't think my mod touches anything about BGM

#

lemme see

fading saddle Apr 20, 2024, 4:44 AM

#

naotoshrug

#

That's just where my game is crashing, it could be something unrelated

hybrid gulch Apr 20, 2024, 4:45 AM

#

i think its the BGM call for checking what music to play depending on the floor lol

#

so probably unrelated

#

weird that it's dying on that though

fading saddle Apr 20, 2024, 4:46 AM

#

Ok it didn't crash that time

hybrid gulch Apr 20, 2024, 4:46 AM

#

yeah it's weird that it doesn't crash everytime

#

but it still heals you when you need it to

fading saddle Apr 20, 2024, 4:48 AM

#

It doesn't want to crash now 😔

#

Oh wait that did it

#

I think I didn't have your esm stuff enabled yet since I hadn't opened the menu

hybrid gulch Apr 20, 2024, 4:51 AM

#

wdym

#

like ESM is causing the crash now?

fading saddle Apr 20, 2024, 4:51 AM

#

Maybe

#

It could be a coincidence though

hybrid gulch Apr 20, 2024, 4:51 AM

#

pain_snap

#

it crashed for me when using dungeon party organize

#

so if you want an easy way of switching floors just remove and add a party member

fading saddle Apr 20, 2024, 4:53 AM

#

Oh I see a problem

#

The bgm id is getting set to a crazy high number

#

0x95A4 (38308)

hybrid gulch Apr 20, 2024, 4:53 AM

#

😭

#

why?>?????

fading saddle Apr 20, 2024, 4:54 AM

#

Does your thing change the bgm in some way?

hybrid gulch Apr 20, 2024, 4:54 AM

#

it shouldn't

#

one sec

#

no it doesn't

fading saddle Apr 20, 2024, 4:55 AM

#

Well so far it's only happened with esm on

hybrid gulch Apr 20, 2024, 4:55 AM

#

but

#

it was crashing for people way before ESM

fading saddle Apr 20, 2024, 4:55 AM

#

Oh ok

hybrid gulch Apr 20, 2024, 4:55 AM

#

lemme see if i can get a crash dump without ESM

#

i don't think there's any BGM stuff whatsoever in ESM

#

besides mod menu

#

ok it's ESM's fault 😔

#

climbed 10 floors and no crash

fading saddle Apr 20, 2024, 5:00 AM

#

You must be changing count 1 somewhere in it since this is where the problem is occuring

#

The value of count 1 is being set as the bgm id

hybrid gulch Apr 20, 2024, 5:02 AM

#

if we are i can't seem to find it

#

📎 message.txt

#

all references to count

fading saddle Apr 20, 2024, 5:03 AM

#

You could just check for SET_COUNT

#

How'd you do that btw?

hybrid gulch Apr 20, 2024, 5:03 AM

#

notepad++

#

opened all documents

#

searched all documents

fading saddle Apr 20, 2024, 5:04 AM

#

Oh

#

That's smart

hybrid gulch Apr 20, 2024, 5:04 AM

#

set count is only ever used in Mod Menu for the favorites system

#

Search "SET_COUNT" (18 hits in 1 file of 63 searched) [Normal]
C:\Users\airin\OneDrive\Desktop\Mod Making\Temp 2\p3ppc.expandedsubmenu\p3ppc.expandedsubmenu\FEmulator\BF\ModMenu\Utilities.flow (18 hits)
Line 420: case 0: SET_COUNT( 24, SelectNumber(4) ); break;
Line 421: case 1: SET_COUNT( 25, SelectNumber(4) ); break;
Line 422: case 2: SET_COUNT( 26, SelectNumber(4) ); break;
Line 423: case 3: SET_COUNT( 27, SelectNumber(4) ); break;
Line 424: case 4: SET_COUNT( 28, SelectNumber(4) ); break;
Line 425: case 5: SET_COUNT( 29, SelectNumber(4) ); break;
Line 460: case 0: SET_COUNT( 30, SelectNumber(4) ); break;
Line 461: case 1: SET_COUNT( 31, SelectNumber(4) ); break;
Line 462: case 2: SET_COUNT( 32, SelectNumber(4) ); break;
Line 463: case 3: SET_COUNT( 33, SelectNumber(4) ); break;
Line 464: case 4: SET_COUNT( 34, SelectNumber(4) ); break;
Line 465: case 5: SET_COUNT( 35, SelectNumber(4) ); break;
Line 493: case 0: SET_COUNT( 36, SelectNumber(4) ); break;
Line 494: case 1: SET_COUNT( 37, SelectNumber(4) ); break;
Line 495: case 2: SET_COUNT( 38, SelectNumber(4) ); break;
Line 496: case 3: SET_COUNT( 39, SelectNumber(4) ); break;
Line 497: case 4: SET_COUNT( 40, SelectNumber(4) ); break;
Line 498: case 5: SET_COUNT( 41, SelectNumber(4) ); break;

fading saddle Apr 20, 2024, 5:05 AM

#

Weird

#

Something is changing it

hybrid gulch Apr 20, 2024, 5:05 AM

#

is the band aid solution rn to set a dependecy on BGME haha

#

nah i'm kidding

#

really weird

#

such a strange number too

fading saddle Apr 20, 2024, 5:06 AM

#

Ah the number is actually 0x4000. I got that part wrong

#

Still definitely not right though

hybrid gulch Apr 20, 2024, 5:07 AM

#

yeah no

fading saddle Apr 20, 2024, 5:08 AM

#

I just watched it happen, when the esm menu opens up for the first time that count does change

#

I'll record it so you can see exactly when it case it might help

hybrid gulch Apr 20, 2024, 5:09 AM

#

oh for real?

#

so it's part of the firsttimesetup.flow then huh

fading saddle Apr 20, 2024, 5:09 AM

#

I would guess so

#

This is in FindAFriend.flow

#

I don't think that'd be it though

hybrid gulch Apr 20, 2024, 5:10 AM

#

weird that it'd be doing that in the dungeon

fading saddle Apr 20, 2024, 5:10 AM

#

That makes no sense

hybrid gulch Apr 20, 2024, 5:10 AM

#

i just fixed that though

fading saddle Apr 20, 2024, 5:10 AM

#

That shouldn't be the problem anyway

hybrid gulch Apr 20, 2024, 5:11 AM

#

yeah two different numbers

fading saddle Apr 20, 2024, 5:11 AM

#

no way that code is getting called

#

that too

hybrid gulch Apr 20, 2024, 5:11 AM

#

adachi_true

fading saddle Apr 20, 2024, 5:11 AM

#

What bf would the code that's being called be in?

hybrid gulch Apr 20, 2024, 5:12 AM

#

field.bf

#

so just field.flow and all it's imports

#

or actually

#

field.bf and dungeonat.bf

#

but nothing in ESM modifies that second one

fading saddle Apr 20, 2024, 5:14 AM

#

Can you try decompiling the dumped bf

hybrid gulch Apr 20, 2024, 5:15 AM

#

for field.bf? sure

fading saddle Apr 20, 2024, 5:15 AM

#

I wanted to but my script compiler is broken for some reason and idk where you can get the latest build

#

(Without having to actually search for it, I'm sure I could find it)

hybrid gulch Apr 20, 2024, 5:16 AM

#

here's dungeonat too

📎 dungeonat.dmp.bf.flow 📎 dungeonat.dmp.bf.msg

#

wait that one doesn't have ESM compiled into it, one sec

#

that's more like it

📎 field.dmp.bf.msg 📎 field.dmp.bf.flow

#

206 kb gaw damn

#

C:\Program Files (x86)\Steam\steamapps\common\P3P\FEmulator-Dumps\BFEmulator\init_free.bin\field\script\field.dmp.bf.flow (17 hits)
Line 213: SET_COUNT( 1, 0 );
Line 801: if ( GET_COUNT( 1 ) == 0 )
Line 805: else if ( GET_COUNT( 1 ) == 102 )
Line 809: else if ( GET_COUNT( 1 ) == 103 )
Line 813: else if ( GET_COUNT( 1 ) == 104 )
Line 817: else if ( GET_COUNT( 1 ) == 105 )
Line 841: SET_COUNT( 1, 102 );
Line 846: SET_COUNT( 1, 103 );
Line 851: SET_COUNT( 1, 104 );
Line 856: SET_COUNT( 1, 105 );
Line 873: SET_COUNT( 1, 0 );
Line 976: SET_COUNT( 1, 0 );
Line 1310: SET_COUNT( 1, 0 );
Line 2299: var38 = GET_COUNT( 12 );
Line 3292: SET_COUNT( 12, var38 );
Line 3355: SET_COUNT( 1, 0 );
Line 3437: SET_COUNT( 1, 0 );

fading saddle Apr 20, 2024, 5:18 AM

#

Still nothing in there that would be changing it

#

I wonder if it's an out of bounds bit instead...

hybrid gulch Apr 20, 2024, 5:18 AM

#

is that within my control 😭

fading saddle Apr 20, 2024, 5:18 AM

#

I mean you might be using a bit that is actually referencing that count

hybrid gulch Apr 20, 2024, 5:19 AM

#

oh that would make sense

#

i have uh

#

a lot of bit flags

#

i can send you the list of bit flags i use lol

fading saddle Apr 20, 2024, 5:19 AM

#

No need, I should be able to work out which one it is myself if any

hybrid gulch Apr 20, 2024, 5:19 AM

#

ok

#

well if you need em lemme know

#

i would start with the turn on recommended ones if that helps

#

since those are enabled by default when you press the square button

fading saddle Apr 20, 2024, 5:20 AM

#

I was right

hybrid gulch Apr 20, 2024, 5:21 AM

#

ohhhhhh

#

how fuuked am i

fading saddle Apr 20, 2024, 5:21 AM

#

I'm not sure, I need to work out what bit it actually is

#

I set a break point and it gets changed inside of the BitSet function

#

0x162e (5678)

#

You're actually editing a lot of counts lol

hybrid gulch Apr 20, 2024, 5:24 AM

#

oh am i

fading saddle Apr 20, 2024, 5:24 AM

#

There are quite a few higher than that

hybrid gulch Apr 20, 2024, 5:25 AM

#

First Time Setup
6320

Mod Menu
6321

Quick Travel plus
6322

View Calendar
6323

Dungeon Options
6324

Find a Friend
6325

Find a friend spoiler free mode
5678

Save Anywhere
6326

Save Everyday
6327

Filler Events
6328

Remove Lunchtime Invites
6340

ENABLE OPTION
6329

DUNGEON
Call the Clock
6330

Auto Healing
6331

Change Party
6332

Change Floor
6333

Use Traesto Gems
6334

Default Direct Commands
6335

Game Over Skip
6336

CALL CLOCK USES TRAESTO
6360

#

flag list

#

5679 - 6360 an unsafe range lmaooooo

fading saddle Apr 20, 2024, 5:25 AM

#

Changing any of those is editing counts

hybrid gulch Apr 20, 2024, 5:25 AM

#

DDD:

#

its a miracle this shit worked

fading saddle Apr 20, 2024, 5:26 AM

#

Does mod menu not have something for editing counts?

hybrid gulch Apr 20, 2024, 5:27 AM

#

no it does not

#

but it probably could be added

fading saddle Apr 20, 2024, 5:27 AM

#

😔

serene sage Apr 20, 2024, 5:28 AM

#

hybrid gulch 5679 - 6360 an unsafe range lmaooooo

Probably more like 5632 and up would be unsafe (since the very last valid bitflag id going by the list on amicitia is 5631); seems like P3P doesn't do any checks for making sure the bit if you pass in is within that valid range so it

Goes ahead and edits the bit at whatever memory address the id would equate to which are not bitflags :'3

Amicitia Wiki

Flags

hybrid gulch Apr 20, 2024, 5:28 AM

#

oh well that's not fun

serene sage Apr 20, 2024, 5:29 AM

#

I was actually worried about this from the start tbh but I just figured that if it was working then maybe there wouldn't be any issues, guess not unfortunately

hybrid gulch Apr 20, 2024, 5:30 AM

#

do you want me to draft up a count editor swine

#

shouldn't be too hard

fading saddle Apr 20, 2024, 5:31 AM

#

That would be nice but I don't really need it. I'm confident that I'm right

fading saddle Apr 20, 2024, 5:33 AM

#

serene sage Probably more like 5632 and up would be unsafe (since the very last valid [bitfl...

It does actually have a check, it just doesn't stop you. Presumably the program would break into a debugger whatever was doing out of bounds checks could be fixed during development. That function wasn't included when it was compiled for release

#

(That xor turns to 0x15FF/5631)

serene sage Apr 20, 2024, 5:33 AM

#

fading saddle It does actually have a check, it just doesn't stop you. Presumably the program ...

Huh, neat

#

Makes sense why it's not there since itd be odd to include a debugger of some sort with the release but obviously that uhhh is an issue for us since that makes it easy to do OOB memory writes without realizing you're doing that since it just works lol

hybrid gulch Apr 20, 2024, 5:35 AM

#

fading saddle That would be nice but I don't really need it. I'm confident that I'm right

🥹

#

totally didn't just copy paste this from time travel

#

fading saddle Apr 20, 2024, 5:35 AM

#

lol

#

nice

hybrid gulch Apr 20, 2024, 5:37 AM

#

so i have to find a chunk of unused bit flags

#

where 2% of the game bit flags are documented......

serene sage Apr 20, 2024, 5:37 AM

#

serene sage Makes sense why it's not there since itd be odd to include a debugger of some so...

Would be neat thinking about it if we could basically reimplement this by just hooking that code with a c# mod or smth that'd basically just throw an error warning message or something (window or printing to log, either works)

Would be kinda helpful for mod makers at least haha

fading saddle Apr 20, 2024, 5:38 AM

#

That could be easily done

#

I feel like it might end up spamming the console though, there are a lot of these (2661 calls to it)

#

I guess it'd be interesting to see

serene sage Apr 20, 2024, 5:42 AM

#

fading saddle I feel like it might end up spamming the console though, there are a lot of thes...

Well in theory if it only would print anything if there's an actual attempt at setting an OOB bit it wouldn't actually print that much tbf, although ig that's hard to be certain about without it being a thing yet lol

fading saddle Apr 20, 2024, 5:44 AM

#

I mean it's not just for out of bounds bits, it's anything they decided to use it for and seemingly that's a lot of places.

#

Although what you're saying does make sense. Presumably stuff shouldn't break during normal gameplay

#

#

That's from opening esm for the first time 😄

#

It passes in some number to the function that I assume is some kind of error code. Idk if there's any strings to relate them to though

#

Neat, there's one when the game tries to load the nonsense bgm and dies too

[ERROR] 707 at d:\projects\p3p-pc\p3p_steam\p3p\sdk\src\sound\sdksnd.c

#

Actually maybe that number could be a line number

#

Not that it would be of any use without the source

#

Well anyway I think it's safe to call this problem fixed. I'll make a pr with the fix soon and hopefully everything will be good then

serene sage Apr 20, 2024, 5:59 AM

#

~~inb4 things break even more bc of the fix troll_smile ~~

#

But yeah does seem like everything's good to go on this basically 👍

#Game crashes when singular mod is enabled despite lack of changes between previous launches