Unhardcode P3P BGM Ids

[dreamy saffron]

In P3P you are unable to call BGM with an id greater than 126 and you can't add any new bgm, only existing ADXs will work because instead of just using the id there's a big list of adx names (see my small rant if you're curious ).
I'm going to try and make it so you can use ids greater than 126 (up to 65535 probably). Because of some weirdness with the existing ids (such as id 2 calling 26.ADX) I will leave the code for ids <= 126 unchanged and only make it work for bigger ones.

Hopefully this is relatively simple to do but in case it is more difficult I figured it was better to have a dedicated post than to spam #p3-modding-chat or #mod-sharing

AnimatedSwine37

Why tf is there literally a list of adx names that it pulls from?
I'm going to guess this is the reason

Jump

[Go to message!](#mod-sharing message)

#mod-sharing

[ashen berry]

Tis done, I am just copy and rename one of the existing files but this is indeed calling 200.ADX which normally wouldn't be possible 🙂
The game does crash if you try to call one that doesn't exist although that sort of already happened so I'm not too concerned about it. If there's an easy way to check if a file exists in the cpks then I'll probably do that

Here's a build of it if anyone wants to test it out, just make it a dependency of your mod, have an ADX in \data\sound\bgm with an id greater than 126 and then call it with the normal BGM flow functions.

[half thunder]

@gusty marlin

[ashen berry]

If there is more hardcoded bgm stuff I wouldn't mind looking into it btw. Idk what is and isn't hardcoded and what people would actually care about though

[half thunder]

I think me and pixel (and purpa probably) would be most interested in allowing new music (not in existing slots) to play in events, and have per-encounter music like we did in P4G

Is this enough for encounter-specific music?

[ashen berry]

I think this covers the first part, I have no idea how music is determined in encounters though. Would I be right in assuming it's hardoced in some way? 🙃

[north notch]

Besides encounter BGM, iirc trying to call BGM in 2D fields has similar issues

(i.e. if I wanted to make the dorm TV call any of the newly added music files)

Ngl though if I had to pick one, I moreso just want IDs below 126 to work lol

Actually never mind, I'll just make a list and shift the ADXs/calls around

[idle sable]

you cant anymore in p4g

p4g is hardcoded on top of acb/awb shit

[north notch]

[north notch]

@ashen berry I'm like halfway through lol. I'll sort it out

[idle sable]

Latter

[half thunder]

There must be a way to say "if player is currently in encounter X, play music track Y", surely? 😦

[idle sable]

Iirc hard-coded like p5 but the bgm id's are still hard-coded to actual music

So you can't add more

[idle sable]

In p5 only certain bgm can be called

I think it's like that in p4g

And even if it isn't

You still have only existing music tracks

Not the entire xwb like 32bit

only the music ids inside the awb and acb

So no room for you to add

[half thunder]

I'm waiting for a second opinion

[idle sable]

no need for one check yourself

open up the awb, check wave + cue id against what's called in encount.tbl and flow

it doesn't use wave id, uses cue id

and because there's cue id categories you can't expand with ace

so

was hardcoded in 32 as well but didnt have to deal with acb

[idle sable]

yup like p5 im guessing

I dont have bgm on me but I'm pretty sure these do not match up with wave or cue ids

[ashen berry]

I can't really do that, the ids don't always match up with the adx numbers that are called so if I were to just use the id for the adx name it'd probably end up with the incorrect bgm playing in places. Well, I could I guess but I don't really see any reason to, you there's more than enough space above 126

Is it just that you'd already put stuff in ones less than 126 and would have to rename and edit whatever calls all them? That is a pain if so but I think it's worth it

[north notch]

Yeah I had started with the lowest ids possible since with Calc's PSP implementation they worked, and Calc had wanted to use something around the 150 range for something of their own iirc (I would've just started my whole list after the base game music otherwise)

I pinged you earlier tho to say that I already realized what you were saying, and started to rearrange the calls/adx names to be above 126

[ashen berry]

Yeah, I saw that I just wanted to let you know why that was the case

[north notch]

Ah ok

[orchid rivet]

how differently does flowscript work in portable vs FES? if it's similar enough i might be able to port fuuka's expanded bgm over for some more tartarus songs

[ashen berry]

Flowscript's the same between games afaik, the difference is the functions that exist although generally it's similar between games as well. That being said I think portable's functions aren't particularly well documented although there'd probably be enough for what you want to do

[orchid rivet]

as long as all the same function hooks and the like exist I might just be able to copy paste the mod over to portable

[north notch]

@ashen berry would you mind letting me know when you feel like the BGM fix is ready? I got all the rearranging for em to start after 126 sorted out

I'm just eager to test and proceed lol

[ashen berry]

I'm pretty sure it's already ready. I sent a build of it up here, I was just going to wait for someone to test it out a bit more before I actually release it

[north notch]

👁️

[north notch]

leave testing to your buddy Purpa Frost, if so

I guess I missed you sending it

[half thunder]

@north notch download here?