mod pack works for me but not for others. please help!

[sterile brook]

i made a modpack for my gf and i but whenever she tries loading it up she gets this error code. i thought it was just her but when i downloaded the exported modpack the same thing happened to me although the original save of the modpack works. why is this happening?

[runic glade]

can you post the whole log on https://mclo.gs/

[vernal echo]

@sterile brook ^
also looking at that error it looks like minecraft wants java 21 but its only finding 17

[sterile brook]

Yea one second

https://mclo.gs/RrwG1fB

[sterile brook]

how could i fix that

[vernal echo]

what launcher is she using

[sterile brook]

modrinth

[vernal echo]

uhh normally in settings you set your java versions

see if they are correct

[sterile brook]

C:\Users\thebi\AppData\Roaming\ModrinthApp\meta\java_versions\zulu17.60.17-ca-jre17.0.16-win_x64\bin\javaw.exe

[vernal echo]

whats for 21

[sterile brook]

this is the java installation if thats what you mean

[vernal echo]

there is 3 fields

whats for java 21

[sterile brook]

where would i find that?

[vernal echo]

uhh send a screenshot i cant check since i dont have the app installed

[runic glade]

mines set to the default java version and its using java 21

[vernal echo]

as in global settings

not instance settings

[sterile brook]

i had ait on default before but swapped to custom to try to fix

[vernal echo]

java installations

[vernal echo]

copy and paste whats in the 21 field

[sterile brook]

C:\Users\thebi\AppData\Roaming\ModrinthApp\meta\java_versions\zulu21.44.17-ca-jre21.0.8-win_x64\bin\javaw.exe

[vernal echo]

it looks like it is using 21

[runic glade]

put it in the spot where you got this

[vernal echo]

ait

is ur minecraft version 1.20.1?

[runic glade]

yeah the modrinth project is set to 1.20.1 and i think the log said the mod is 1.20.1 too

[vernal echo]

so why on earth is it wanting 21

1.20.1 uses 17

[sterile brook]

im trying that rn

it worked

[frosty turtle]

-# Command suggestion: </solved:1379505438407528477>

[sterile brook]

lol

thank you guys

[frosty turtle]

-# Command suggestion: </solved:1379505438407528477>

[sterile brook]

oh wait it didnt work

[vernal echo]

yea i figured

[sterile brook]

im wrong i was on a different pack and didnt realize @runic glade @vernal echo

[vernal echo]

😔

[runic glade]

you said you made this mod right?

[sterile brook]

just a modpack not individual mods

the pack worked fine but when i shared it wouldnt work

and then i downloaded that and that version didnt work but the original does

[runic glade]

ok the problem is with the visible traders mod so removing that would fix it

its possible that mod has the wrong java level set

[sterile brook]

ill try that

[runic glade]

theres two versions of it that are released for 1.20.1, try version 0.0.4

actually i looked at the source code for the mod and it looks like all versions need java 21

[sterile brook]

okay so using java 21 did work, i just tried it on the wrong modpack but doing it on the correct one also fixed it

[frosty turtle]

-# Command suggestion: </solved:1379505438407528477>

[runic glade]

he hard coded java 21 into the mod settings

[sterile brook]

my gf has no issues now and neither do i

[runic glade]

even better

[sterile brook]

so thank you your suggestions did work

you guys are geniuses

my goats

[runic glade]

have fun

[sterile brook]

thank you bro