does the url have an empty hash?
#Failed to execute 'querySelector' on 'Document': '#' is not a valid selector.
winged fern
not even something like <A href="/hello#">?
Well, then we probably need a repro, on a related note I don't think it should fail with an empty hash
Yes, anything live to see that behavior?
Not that I'm an expert, but I've read solid router code a few times
Yep, but need actual repro to figure out what's causing this
I believe this is used for scroll restoration for hash links
winged fern
not even something like `<A href="/hello#">`?
Yes I just guessed but you said you don't have anything like it in your app so
You have pause on uncaught exceptions checked
It's already wrapped with try catch
It could fail if you actually passed an invalid selector through url or A link
i don't know how document.querySelector is implemented but if it doesn't check if the selector is empty, this could surely save us some cycles
winged fern
You have pause on uncaught exceptions checked
well, with this, i'm sure you'll find something similar for solid-js or any other libraries that rely on try catch
why did you turn it on though?
solid uses try catch for error boundary, you can also ignore node_modules
not sure if it also ignores caught errors though
winged fern
i don't know how `document.querySelector` is implemented but if it doesn't check...
sure