gentle cypress
Hi guys! I was trying out Tanstack Router examples for SolidJS:
I wonder why when navigating pages in example 1 the entire page seems to be flickering but it does not happen in example 2. Can anyone give me explanation ? thanks!
oblique fiber
cc @radiant umbra @granite grail
radiant umbra
Hi guys! I was trying out Tanstack Router examples for SolidJS:
1. https://tanst...
Can you try wrapping <Outlet /> in the __root.tsx with Suspense? I think that would fix it. If so, we can update the example
oblique fiber
Can you try wrapping <Outlet /> in the `__root.tsx` with Suspense? I think that ...
why would that be required? is this still that bug with the lazy loaded modules?
radiant umbra
why would that be required? is this still that bug with the lazy loaded modules?
I think its just a difference in how Solid's resources work when there is no explicit Suspense boundary
Like it treats it like there is one empty Suspense boundary around everything, so then its falling back to an empty page which causes the flicker
gentle cypress
Hi thank you ,tried adding it into my personal project, it worked. I also tried to set autoCodeSplititng to false in vite.config.ts and the flicker gone.
mint acorn
Im having the same problem, autoCodeSplititng to false also fixed the flickering, im also seeing this warnings
radiant umbra
Im having the same problem, `autoCodeSplititng` to `false` also fixed the flicke...
Instead of turning code splitting off does adding the suspense around outlet work?
mint acorn
Not completely, it's like it fixes some of the behaviour and i also would need to add a suspense every time i have a navigation level.
Also, this started happening when i went from "@tanstack/solid-router": "^1.111.3" to "@tanstack/solid-router": "^1.114.23" prior to that i had no warnings nor any flickering
mint acorn
@radiant umbra just tracked down when the flicker started, it began happening in 1.111.13 https://github.com/TanStack/router/releases/tag/v1.111.13
radiant umbra
<@303173621717794816> just tracked down when the flicker started, it began happe...
I think I have a fix up. Can you try installing this version:
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@3813
