If I do something like this
<Link to="/$profile" params={{ profile: `@user` }>Name</Link>
the element is being formed as
<a href="/%40user">Name</a>
How it can be fixed?
#@ in param
timber geyser
On navigating by this link, the browser's address bar also displays not @user, but %40user
brazen gorge
@fervent rain I think you were involved in uri component encoding decoding, right?
timber geyser
Link is a component from tanstack router
fervent rain
<@400901742268645387> I think you were involved in uri component encoding decod...
Yea, this got changed so all path params got decoded. Because of the conflicts between their font view vs Unicode view.
brazen gorge
whats that conflict about?
fervent rain
URL matching fails.
For example, matching an emoji vs the Unicode version of the same emoji would cause route matching to fail.
Not at my computer right now, but we had a closed issue on it
brazen gorge
should we make this configurable?
so by default, decode everything, but if user wants to provide his own logic (that may then exclude certain chars) he can?
fervent rain
🤷🏼♂️ Haven't thought too much into it to be honest.
Yea maybe a strict: true kind of situation is what you mean yes? Or allow the user to pass in a function?
Just keep in mind the whole configuration surface thingy 😅
brazen gorge
Or allow the user to pass in a function?
that's what I meant
Just keep in mind the whole configuration surface thingy 😅
absolutely, but in this case I think we don't know better than the user
fervent rain
👍🏼