[SOLVED] Add Custom Alphas/Base on Miryoku ZMK for Rollow

[plush smelt]

I'm attempting to compile firmware forked from Miryoku ZMK using Github Actions for the Rollow with Nice!Nano v2's. This is my first attempt with both Miryoku and ZMK. Here's my fork: https://github.com/samjolley/miryoku_zmk

My goal is to change the Base layer to the Hands Down Gold layout and keep the rest of the Miryoku layers as is for now, but I keep getting code 1 errors:

-- Configuring incomplete, errors occurred!
FATAL ERROR: command exited with status 1: /usr/local/bin/cmake -DWEST_PYTHON=/usr/bin/python3 -B/__w/miryoku_zmk/miryoku_zmk/zmk/app/build -S/__w/miryoku_zmk/miryoku_zmk/zmk/app -GNinja -DBOARD=nice_nano_v2 -DSHIELD=rollow_left -DZMK_CONFIG=/__w/miryoku_zmk/miryoku_zmk/miryoku_zmk/config
Error: Build failed with exit code 1.
Error: Process completed with exit code 1.

I've tried adding Hands Down Gold as an alternative layout in the miryoku_babel miryoku_layer_alternatives.h and miryoku_layer_selection.h files, as well as in custom_config.h

Any help would be greatly appreciated!

Disclaimer: I am not a programmer, but I'm doing my best with reviewing the documentation, Discord searches, etc.

I'm working through the errors in the build log.

[plush smelt]

Attempting another build

https://github.com/samjolley/miryoku_zmk/actions/runs/4255177409/jobs/7402450659#step:6:713

New errors

[plush raptor]

I think you'd need to set the five column transform in rollow.keymap or custom_config.h in order to be able to use the 36 variant here: https://github.com/manna-harbour/miryoku_zmk/compare/master...samjolley:miryoku_zmk:master#diff-32c9139d91bbf0aa07ce08cf94cb52a9aed0b62ad5f53aec3433c05223d7a110R7

I couldn't see it in your case

Actually it is probably better that you just remove that change, Miryoku should automatically handle the key count conversion

It doesn't look like that Rollow shield's 5 column transform is properly set up anyway

[plush smelt]

So switch back to the default 42 corne?

[plush raptor]

Yes

Also the emoji layer seems to be undefined but I don't know if that will cause any issues yet

[plush smelt]

Awesome

Yeah, good call. The emoji layer is really just a fun future idea

Alright, running another build. And thank you for the help!

Working through fresh errors:

https://github.com/samjolley/miryoku_zmk/actions/runs/4255445451/jobs/7403070221#step:6:707

Running attempt #9

[plush raptor]

I guess you don't have MIRYOKU_ALTERNATIVES_TAP_HANDSDOWNGOLD (without FLIP) defined

[plush smelt]

Ah, good catch

Seems like progress:

https://github.com/samjolley/miryoku_zmk/actions/runs/4255611397/jobs/7403450640#step:6:701

[plush raptor]

You are missing backslashes in this definition: https://github.com/manna-harbour/miryoku_zmk/compare/master...samjolley:miryoku_zmk:master#diff-954aa649b4b0e9b27056d5386287fc9770aa2a2f298e2d5bf5fbcb80cdaf6649R75

[plush smelt]

Ok, that one is confusing based on this error message:

/__w/miryoku_zmk/miryoku_zmk/miryoku_zmk/config/../miryoku/miryoku_babel/miryoku_layer_alternatives.h:407:37: warning: backslash-newline at end of file
407 | #define MIRYOKU_ALTERNATIVES_BUTTON
|

[plush raptor]

That is a warning, I am assuming it is not breaking

[plush smelt]

Ah

[plush raptor]

The issue is more that your layer definition ends having 10 elements rather than 36 because of the lack of backslashes for continuation

[plush smelt]

Ooooh

[plush raptor]

I don't know if you were doing those intentionally, but you didn't need to remove the blank lines at the end of files as well 😅

Sometimes editors are weird and does that themselves but it usually goes the other way (add blank lines at EOF if doesn't exist)

But it shouldn't break anything, just makes the diffs noisier

[plush smelt]

Lol, yeah, that's just me trying to seem like I'm making progress

[plush smelt]

Holy moly, it worked!

Thank you so much for your help!!

[plush raptor]

no problem!

[plush smelt]

[SOLVED] Add Custom Alphas/Base on Miryoku ZMK for Rollow

[pseudo roost]

Glad you got it working!
The simplest change is just to substitute a custom Base layer via custom_config.h as described at https://github.com/manna-harbour/miryoku/discussions/85. In particular, you don't need to touch the workflow or the miryoku_babel/ files. E.g., based on your changes, add the following to custom_config.h:

#define MIRYOKU_LAYER_BASE \
&kp J,             &kp G,             &kp M,             &kp P,             &kp V,             &kp SEMI,          &kp COMMA,         &kp DOT,           &kp SLASH,         &kp BSLH,           \
U_MT(LCTRL, R),    U_MT(LALT, S),     U_MT(LGUI, N),     U_MT(LSHFT, D),    &kp B,             &kp AMPS,          U_MT(LSHFT, A),    U_MT(LGUI, E),    U_MT(LALT, I),      U_MT(LCTRL, H),     \
U_LT(U_BUTTON, X), U_MT(RALT, F),     &kp L,             &kp C,             &kp W,             &kp MINUS,         &kp U,             &kp O,            U_MT(RALT, Y),      U_LT(U_BUTTON, K),  \
U_NP,              U_NP,              U_LT(U_NUM, DEL),  U_LT(U_SYM, BSPC), U_LT(U_NAV, T),    U_LT(U_SYM, TAB),  U_LT(U_NAV, SPACE),U_LT(U_FUN, DEL), U_NP,               U_NP

However, the layers on the thumbs are messed up. And ' takes the place of ; on Base, so if you want to keep that you'll also need to substitute custom Num and Sym. Also, since you've changed the mods order you'll want to make the same change to the other layers, which would be easier to do via Miryoku Babel instead.

[plush smelt]

Thank you! I'm pretty new to this so I appreciate the help!

[plush smelt]

So for any people finding this in the future, I corrected the thumb keys to standard Miryoku, added the "T" for Hands Down Gold to the far right thumb/TAB key on the left side keyboard, and added a combo for TAB:

[pseudo roost]

Oh, I didn't notice the thumb alpha! Here's an example of moving things around to accommodate that (for RSTHD): https://github.com/manna-harbour/miryoku_babel/commits/rsthd-tmp.