#FYI @Erik Sipsma @vito I roped @
1 messages ยท Page 1 of 1 (latest)
What's the priority on lockfile for you? I'd prefer to go all out on finishing theseus first, which also entails finishing dockerfile2dagger that Alex CB has been working on. So asking because the answer determines what Alex should focus on first.
I also don't ideally want another thing to rebase theseus on, there's risk of getting stuck in permanent rebase hell
It's a blocker for the workspace configuration UX, because the new .dagger/config.toml file doesn't carry pins... So if there's no lockfile, you lose the ability to pin dependencies with the new UX
In any case, I implicitly meant "... as the next item on his queue after dockerfile2dagger"
I also don't ideally want another thing to rebase theseus on, there's risk of getting stuck in permanent rebase hell
Ah, well if we're getting so close to merging theseus that you need a freeze window, that's totally fine, lockfile is relatively small so I'm guessing (hoping?) that rebasing it on top of theseus won't be too bad ๐
Regardless we'll get it as close to merge as possible - with the cycles AlexCB has left after dockerfile2dagger, and then we can see when we actually want to merge
workspace itself (which depends on lockfile) is not 100% ready anyway
Yeah in terms of lines of code changed that conflict, it's probably like 90% conflicting ๐ , but in terms of actual conceptual conflicts, there's none. So that's good, it's easy, just needs careful incorporation in terms of refitting the gears into the new engine, so to speak.
I more just fear death by a thousand rebase papercuts. But sounds like we're on the same page in terms of priority ๐
It'll be easier to deal with that in lockfile than in theseus I'm sure. We'll make it work!
Plus it's rebasing on the promise land ๐
@ocean marlin should we proactively rebase lockfile & workspace onto your theseus branch?
if we already know for sure that's the sequence we want
I'm working on final big set of patches and also rebasing on main, so not quite yet. In the next day or so though, I'll let you know