generate + check

[ocean goblet]

maybe related: I have added a // +check function for each of my functions that would be a // +generate function (assuming i've guessed the use of dagger generate correctly) that ensures that its Changeset is empty.

not sure how you'd do it with a good UX, but it'd be nice if I didn't need to create a "stub" check function for each generate function

maybe if the function returns a Changeset, is a check function, and is a generate function, then dagger automatically ensures that the Changeset is empty?

here's an example "stub" function that I'm referring to:

// +check
func (m *Example) IsGenerated(ctx context.Context) error {
    if empty, err := m.Generate(ctx).IsEmpty(ctx); err != nil {
        return err
    } else if !empty {
        return fmt.Errorf("source is not generated (run `dagger call generate`)")
    }

    return nil
}

[final yoke]

Here's how we plan on addressing that:

1. Add first-class dagger generate support
2. Add a builtin check function, always available in dagger check, called check-generated. This will automatically call generate and fail if the changeset is not empty

Desired end state: dagger check by default always checks that your generated files are up-to-date, without requiring any explicit +check on your part

[ocean goblet]

sgtm

[final yoke]

We have the exact same pattern in our own dagger module at the moment 🙂 Once the improvements above 👆 are merged, we can remove that custom code

https://github.com/dagger/dagger/blob/main/.dagger/main.go#L18-L34