Dagger Cloud

[waxen niche]

probably yes? but now the error only happens there rather than everywhere?

[rugged geyser]

There are other errors elsewhere, I'm double-checking how many of those are also secrets-related

@waxen niche ooh for some reason, the php toolchain does this:

func (t *PhpSdkDev) WithGeneratedClient() *PhpSdkDev {
    relLayer := t.DevContainer(true).
        WithExec([]string{"dagger", "run", "./scripts/codegen.php"}).
        Directory(".").
        Filter(dagger.DirectoryFilterOpts{
            Exclude: []string{
                "vendor",
            },
        })

    t.Workspace = t.Workspace.
        // Merge rel layer inside the current workspace
        WithDirectory(t.SourcePath, relLayer)

    return t
}

Note the wrapped dagger run. Could that be the reason only that function triggers the issue?

(mm that should not be the reason, dagger run although weird in this place, should only pass through the session)

[waxen niche]

Yeah I can't imagine why that'd break in this way. It is extremely weird that the other SDKs are okay even though they also use containers with the same secret

[rugged geyser]

I'm squashing a few other unrelated bugs

[waxen niche]

ok yeah lemme know if it becomes the blocker, I wanna see if I can finish up my hunt for the sqlite hang I've been making progress on..

[rugged geyser]

https://tenor.com/view/good-hunting-chloe-rose-leslie-the-last-witch-hunter-lionsgate-gif-18245996

[rugged geyser]

@waxen niche I have 2 remaining blockers, and I am equally stuck on both 😛 so technically this 👆 is 50% of my blockers 😛

[waxen niche]

i gotta run in a few, but figured out the sqlite thing so I'll take a look at this quick, will continue next week if needed

[rugged geyser]

Nice, at least one of us made some progress 😛 Thanks

You don't even want to know about the 2nd blocker... I already know it's going to be wildly infuriating once I finally figure out the root cause

@waxen niche don't ruin your evening over it!

[waxen niche]

I noticed one very suspicious difference between php and the other SDKs, which is that for PHP the installClient step happens in a different function (the constructor) than the call to generate (here)

i.e. vs. typsescript where it happens in generate (here), and seems same for all non-php sdks

Which to be clear would indicate a bug in the engine, but I'd bet $5 that's what's triggering the bug

[rugged geyser]

I figured out my other blocker... It's exactly as dumb as I imagined

Add one to the "slightly wrong ignore filter in A silently causes a seemingly unrelated explosion in B" category

• cmd/dagger/shell_completion_test.go uses modules/wolfi as test data
• modules/wolfi is ignored in engineDev() constructor.
• Test still runs, silently fails to load modules/wolfi, shell auto-completion no longer includes wolfi functions: only core functions
• As a result a small number of shell autocomplete tests fail because eg. a<tab> only offers address and not [address, alpine]

[waxen niche]

so if you need a quick workaround you could re-arrange that code to run installClient in generate instead, I'll make a fix on monday

[waxen niche]

oof, yeah the lack of errors when a dep doesn't compile bit me recently too. thought I was losing my mind for a while

[rugged geyser]

Definitely doing that... thanks!!