#@vito There's a problem with the dang
karmic helm
Opening a thread to keep track of our investigation
And /cc @left cosmos sorry I forgot to add @
left cosmos
I just did
diff --git a/dagger-sdk/entrypoint/main.go b/dagger-sdk/entrypoint/main.go
index b5702d1..affe53f 100644
--- a/dagger-sdk/entrypoint/main.go
+++ b/dagger-sdk/entrypoint/main.go
@@ -440,11 +440,11 @@ func createFunction(dag *dagger.Client, mod *dang.Module, name string, fn *hm.Fu
}
// TODO: enable once checks ship
- for _, directive := range mod.GetDirectives(name) {
- if directive.Name == "check" {
- funDef = funDef.WithCheck()
- }
- }
+ //for _, directive := range mod.GetDirectives(name) {
+ // if directive.Name == "check" {
+ // funDef = funDef.WithCheck()
+ // }
+ //}
args := fn.Arg().(*dang.RecordType)
for _, arg := range args.Fields {
to a branch and point the dang SDK in cmd/codegen/dagger.json to this branch and it works (if anyone wants to try, github.com/eunomie/dang/dagger-sdk@no-with-check)
One surprising thing to me is the PRs on dagger/dagger are affected the same way, but commits on main are good 🤔
overall I think we should first release main with the new checks implementation (to have access to WithCheck then we can use this version of the dang sdk
karmic helm
I tried to run dagger develop with a dev engine built from friday on vito/dang/dagger-sdk and it generated the WithCheck.
@left cosmos We could also pin the dang sdk to a commit prior to the check
Yep it works
The commit after checks seems to be related to repo's internals so it should be fine to pin
I'm opening a PR
karmic helm
One surprising thing to me is the PRs on dagger/dagger are affected the same way...
Maybe it's because the CI relied on a cache build of the dang SDK?
This is the trace of the dangSDK loading on our latest commit on main: https://dagger.cloud/dagger/traces/073e4aafa1705c622a5d2f36696f0343?span=558359bd811a1225
Sadly I'm not able to find the commit of the dang SDK in that specific build :/
karmic helm
Merged
short granite
ah yep. sorry probably should have done a look around to make sure all the usage sites are pinned before merging the checks branch into dang main