#@Erik Sipsma [less of a nerd snipe and
1 messages · Page 1 of 1 (latest)
WithChanges is wrapped in DagOp, so that shouldn't be an issue: https://github.com/sipsma/dagger/blob/0c0028796eb5252e373196dfa4964f07295ab546/core/schema/directory.go#L185-L185
hmmm ok, was wondering if it might be clashing somehow but i guess not
also that error might be cut off, lemme see if i can repro or dig up a trace
Not sure but I'd suspect the fact that it's hitting this codepath involving env might be part of the problem: https://github.com/sipsma/dagger/blob/0c0028796eb5252e373196dfa4964f07295ab546/core/modulesource.go#L647-L647
could be related to the whole issue in https://github.com/dagger/dagger/pull/11350 but env-flavored rather than plain ol' contextual dir related
maybe
- i noticed the first iteration of that PR (having IDs re-compute digests too) was also a path I went down on the LLM side of things, specifically for env workspaces. so this all feels very related
in my case it was because I wanted to be able to encode unpinned IDs and have them load with the fresh context on every use
as an implementation detail of saving/restoring LLM sessions
ah ha - I ended up adding a flag for it to IDs: https://github.com/vito/dagger/commit/e80d4c1838df775bd1394083fb4cc47b96525fcd (this is not in main)
Yeah that approach was a real rabbit hole. I'm sure it could work with enough effort but every time I fixed something somewhere something else broke. It's tricky because there's times where you want to recompute digests and times where you really really don't or else stuff will break horrendously, which becomes a mess
yeah exactly haha. I tried all sorts of heuristics and shit kept breaking
so i just added a flag for it instead and used it in the LLM code
oh right, this comment https://github.com/dagger/dagger/pull/11264#discussion_r2453445886