dagger-in-dagger + registry network error

[thick falcon]

I believe those would be the integration tests.

I haven't dug into how the underlying codegen and client provisions work yet, so I haven't touched those tests much other than to group them as integration.

The PhpSdkDev's Test method can take a group argument, if it's set to "unit" then it will only run the tests that don't directly rely on Dagger.

We could set it here and then those flaky ones shouldn't be an issue.

That said, now that we have core integration tests for modules, we can probably just delete the sdk/php/tests/integration directory entirely without penalty.

@steep kernel I know you didn't write them either, but does them sound reasonable?

[steep kernel]

mm, i mean the tests don't seem to be testing a whole lot

but also, the fact they only fail in dagger-in-dagger doesn't bode well to me

i would be worried about a bigger underlying issue

[thick falcon]

I was worried it might be worrying.

I'll be honest, I'm not entirely sure where everything begins, these are the steps I understand:

1-?: ???
? + 1: Reads a graphql schema
? + 2: Generates PHP Code from it
? + 3: Uses code

I can read PHP, but without knowing what I'm looking for exactly, it's a time consuming task so I've not gotten round to it.

[hollow sentinel]

I don't think it's an issue with php or the php tests tbh

it's just the only way I found how to trigger it

[hollow sentinel]

yes 100%

[hollow sentinel]

dagger-in-dagger + registry network error

copying <@&946480760016207902>, I think I will need help on this one... spent a couple hours last night, no idea where to look next

[cursive hearth]

what's the command to repro?

[hollow sentinel]

dagger -m github.com/shykes/dagger@ci-checks call \
 playground \
 with-directory --path=./dagger --source=https://github.com/shykes/dagger#ci-checks with-workdir --path=./dagger \
with-exec --args=dagger,call,sdk,php,test

Or more simply (but slower):

dagger -m github.com/shykes/dagger@ci-checks call ci-in-ci

fair warning this may be an issue in my CI module... I just don't really understand what could even trigger this

[hollow sentinel]

@thick falcon just confirming that the actual root cause is completely unrelated to the PHP SDK