#this is it https://github.com/dagger/
1 messages ยท Page 1 of 1 (latest)
I'm trying to resurrect that SelectID but I'm quite confused by the changes you did on https://github.com/dagger/dagger/pull/10620/files#diff-b59a4572e394153eac54c0bd498ee3e02e3364646c892c15a1e709622cc5a51b
That part of the codebase is like super obscure for me
I'd take a look at the updates made in that diff to Select, as far as I can tell it should be fairly similar, just simpler since SelectID is simpler
Where are executed the tests in dagql/dagql_test.go?
Is it part of our CI?
@last cypress I cannot find the job who actually execute them.
https://github.com/dagger/dagger/pull/11277
I assumed my tests would fail but it doesn't which looks too good to be true x)
it definitely runs somewhere, the tests are just super fast and unit-y. can try em locally - go test ./dagql
(unless we accidentally excluded all non-integration tests with our test splitting scheme)
It doesn't compile on mac so I have to create the dev engine etx... x)
I'll see, maybe my tests pass so I'll push a broken version to see which job triggers it
that's suprising - what's the compilation error?
NVM, it seems it compiles if I don't try to run it from vscode
I don't understand why my code works but it does
(without even using AI) so I simply dont understand my own code x)
it's under test-everything-else because that job does go test ./... (whereas all the others do go test ./core/integration specifically)
(which isn't obvious, I just happened to have wondered the same thing in the past)
@lethal forge Hey, are you still up? I have a little weird dagql issue that I do not understand, if maybe we could pair of that (tomorrow is fine too)
I can tomorrow or if u want to send over chat here i can take a look now
I'll ask doug, we can talk tomorrow I think it's a pretty complex issue
@lethal forge Hey ๐
Let me know when you are free so we can have a look ๐
Or maybe @last cypress you are free? It's a pure dagQL issue haha
yep I'm around!