#go.mod changes broke build?

1 messages · Page 1 of 1 (latest)

prime rose
#

My suspect:

commit 898dc0797a239f5fbc9ab5b7271f1e12207526b4
Author: Solomon Hykes <solomon@dagger.io>
Date:   Mon Oct 20 14:17:34 2025 -0700

    review

diff --git a/.dagger/go.mod b/.dagger/go.mod
index f1c51b354..a0d8c17fb 100644
--- a/.dagger/go.mod
+++ b/.dagger/go.mod
@@ -5,6 +5,7 @@ go 1.24.4
 require github.com/dagger/dagger/engine/distconsts v0.19.2
 
 replace (
+    github.com/dagger/dagger => ..
     github.com/dagger/dagger/engine/distconsts => ../engine/distconsts
     github.com/dagger/dagger/sdk/typescript/runtime => ../sdk/typescript/runtime
 )
@@ -63,5 +64,3 @@ replace go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp => go.opente
 replace go.opentelemetry.io/otel/log => go.opentelemetry.io/otel/log v0.14.0
 
 replace go.opentelemetry.io/otel/sdk/log => go.opentelemetry.io/otel/sdk/log v0.14.0
-
-replace github.com/dagger/dagger => ..
diff --git a/cmd/dagger/.dagger/go.mod b/cmd/dagger/.dagger/go.mod
index 2bb6a714b..481383052 100644
--- a/cmd/dagger/.dagger/go.mod
+++ b/cmd/dagger/.dagger/go.mod
@@ -2,7 +2,10 @@ module github.com/dagger/dagger/cmd/dagger/.dagger
 
 go 1.24.4
 
-replace github.com/dagger/dagger/engine/distconsts => ../../../engine/distconsts
+replace (
+    github.com/dagger/dagger => ../../..
+    github.com/dagger/dagger/engine/distconsts => ../../../engine/distconsts
+)
 
 require (
     github.com/99designs/gqlgen v0.17.80
@@ -52,5 +55,3 @@ replace go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp => go.opente
 replace go.opentelemetry.io/otel/log => go.opentelemetry.io/otel/log v0.14.0
 
 replace go.opentelemetry.io/otel/sdk/log => go.opentelemetry.io/otel/sdk/log v0.14.0
-
-replace github.com/dagger/dagger => ../../..
diff --git a/cmd/engine/.dagger/go.mod b/cmd/engine/.dagger/go.mod
index 46ec5174b..f505f1367 100644
--- a/cmd/engine/.dagger/go.mod
+++ b/cmd/engine/.dagger/go.mod
@@ -8,6 +8,7 @@ require (
 )
 
 replace (
+    github.com/dagger/dagger => ../../..
     github.com/dagger/dagger/engine/distconsts => ../../../engine/distconsts
     github.com/dagger/dagger/sdk/typescript/runtime => ../../../sdk/typescript/runtime
 )
@@ -65,5 +66,3 @@ replace go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp => go.opente
 replace go.opentelemetry.io/otel/log => go.opentelemetry.io/otel/log v0.14.0
 
 replace go.opentelemetry.io/otel/sdk/log => go.opentelemetry.io/otel/sdk/log v0.14.0
-
-replace github.com/dagger/dagger => ../../..
#

Seems like a no-op to me? 🤔

prime rose
#

@spiral bridge repro:

dagger -m github.com/dagger/dagger@26604a4a70c42a4808a575783f593d8f59509531 call dev with-exec -- dagger -m github.com/dagger/dagger@26604a4a70c42a4808a575783f593d8f59509531
prime rose
#

Update: after reverting the cosmetic go.mod changes, the dev-engine check still fails... It seems unrelated

#

There are 2 suspect commits on main, which I rebased on before the failure appeared. Investigating

prime rose
brazen widget
#

looking into this now, i would like to not merge a revert

#

i suspect there's some additional flakes introduced by this pr - which would potentially make sense, we're now parallelizing tests + checks that were previously run in separate jobs

#

not really sure, just gonna have to keep an eye out

#

it's green now anyways, so please hit merge if the changes i made lgty

brazen widget
prime rose
#

yeah to be clear I was not suggesting that we merge the revert

prime rose
#

Thanks for picking it up @brazen widget !

#

(the word "attempt" makes me wonder)

brazen widget
#

yes please, there's some sort of fix in there

#

it'll get squashed on merge

prime rose
#

"some sort of fix" 😄

#

I know exactly what you mean, that was my whole evening

#

Did you get a definitive answer on why a commit that only updates go.mod somehow combines with my PR to cause a codegen fail, only when loading our module with dev engine?

brazen widget
#

nooooOOOpe

prime rose
#

OK makes me feel better 😛

#

merged!