0.18.11 enums breaking | Dagger | Page 1

stoic sky Jun 25, 2025, 3:25 PM

#

This is my enum

type Proximity string

const (
    // Local proxy also known as on-prem proxy.
    Local Proximity = "LOCAL"

    // AWS proxy should be always used within AWS.
    AWS Proximity = "AWS"
)

Publish

func (r *MyModule) Publish(
    ctx context.Context,
    user *dagger.Secret,
    pass *dagger.Secret,
    // Whether this is a local or cloud (AWS, Azure) Dagger engine
    // Options: LOCAL, AWS
    // +optional
    // +default="aws"
    proximity Proximity,
) ([]string, error) {

indigo whale Jun 25, 2025, 3:29 PM

#

aha

#

"aws" should definitely be "AWS"

#

in the default

#

that said, yeah, this shouldn't be breaking

stoic sky Jun 25, 2025, 3:30 PM

#

ooh!

indigo whale Jun 25, 2025, 3:32 PM

#

the previous behavior definitely wasn't intentional lol

#

but i guess we should still support it

stoic sky Jun 25, 2025, 3:32 PM

#

ok that fixed it. I had 3 different instances of mismatched cases.

#

And how it's working now makes sense. As long as you make it clear that it's breaking 🙂

indigo whale Jun 25, 2025, 3:33 PM

#

sigh 😦 welp thanks ❤️
i guessed that we'd accidentally break something with this change 😄

stoic sky Jun 25, 2025, 3:34 PM

#

Wait so does that mean I could have a "AWS" and a "aWs" and a "aws" as enums?

#

Just that I have to match the +default with the exact case..

indigo whale Jun 25, 2025, 3:35 PM

#

🤔 one moment

#

dammit

indigo whale Jun 25, 2025, 3:35 PM

#

stoic sky Wait so does that mean I could have a "AWS" and a "aWs" and a "aws" as enums?

wait okay, no this won't work

#

so now, the enum NAME, is based on the variable name.

so if i have Foo Proximity = "bar"

#

then that exact enum pairing should appear in codegen (instead of previously Bar Promixity = "bar"

#

on the cli you pass the name - i.e. Foo (which matches how we do function or type naming)

stoic sky Jun 25, 2025, 3:38 PM

#

Ah, and the +default should also match that (Foo)

indigo whale Jun 25, 2025, 3:39 PM

#

well

#

for go specifically

#

we allow matching by name or value

stoic sky Jun 25, 2025, 3:39 PM

#

gotcha, but it's case sensitive

indigo whale Jun 25, 2025, 3:39 PM

#

in python or typescript we can be much more normal about it, since you can do arg=Proximity.Foo

#

but in go, we have this weird pragma-y thing

indigo whale Jun 25, 2025, 3:40 PM

#

stoic sky gotcha, but it's case sensitive

mmmm, looking into this now

#

I can't quite work out why this used to work at all

stoic sky Jun 25, 2025, 3:41 PM

#

yeah.. like in my case, what I had didn't match the case of either the name or the value

AWS Proximity = "AWS"

So that's confusing. I'm also confused why I didn't match it myself lol

indigo whale Jun 25, 2025, 3:41 PM

#

i'll put together a regression fix

#

you won't be the only one 😄

stoic sky Jun 25, 2025, 3:41 PM

#

for sure

indigo whale Jun 25, 2025, 3:41 PM

#

thanks for upgrading so quickly and catching it 😄

stoic sky Jun 25, 2025, 3:42 PM

#

Haha! I can't help living on the edge 😄 Do you want me to open an issue to track?

indigo whale Jun 25, 2025, 3:43 PM

#

go for it 🙏

#

actually!

#

might be worth holding

#

turns out. you can't actually call that function and rely on the default value

#

even in 0.18.10

#

the module "works" - until you try and call it

#

e.g.

const (
    // Local proxy also known as on-prem proxy.
    Local Proximity = "LOCAL"

    // AWS proxy should be always used within AWS.
    AWS Proximity = "AWS"
)

// Returns a container that echoes whatever string argument is provided
func (m *Test) Test(
    // +default="aws"
    p Proximity,
) *dagger.Container {
    return dag.Container().From("alpine:latest").WithExec([]string{"echo", string(p)})
}

#

❯ dagger call test
❯ DAGGER_LEAVE_OLD_ENGINE=1 dagger-v0.18.10 call test
▶ connect 0.2s
▶ load module: . 1.0s
● parsing command line arguments 0.0s

● test: Test! 0.0s
✘ .test: Container! 0.2s ERROR
! failed to set call inputs: failed to convert arg "p": invalid enum value "aws"

stoic sky Jun 25, 2025, 3:45 PM

#

oh? but I do call it

indigo whale Jun 25, 2025, 3:46 PM

#

if you fill in the default it'll work

#

but if you leave it blank to rely on the default it'll fail

stoic sky Jun 25, 2025, 3:46 PM

#

gotcha!

#

Yes I provide it every time

indigo whale Jun 25, 2025, 3:46 PM

#

we should amend the release notes - but i think ensuring that the default values are validated is fairly reasonable

stoic sky Jun 25, 2025, 3:46 PM

#

Yes I agree.

indigo whale Jun 25, 2025, 3:47 PM

#

we don't need bug for bug compatibility 😢

stoic sky Jun 25, 2025, 3:54 PM

#

Hm, does this break compat though? I updated the +default but kept the module engine version 0.18.9 and updated the CLI/engine version to 0.18.11 and that threw a compiler error for dagger.gen.go

indigo whale Jun 25, 2025, 3:54 PM

#

yes this would break compat

stoic sky Jun 25, 2025, 3:54 PM

#

good call out I guess for notes

indigo whale Jun 25, 2025, 3:58 PM

#

https://github.com/dagger/dagger/pull/10642

GitHub

chore: update v0.18.11 changelog to include enum defaults breaking ...

As discovered by @nipuna-perera in discord.
This behavior is technically breaking? Which is a bit annoying, but also, this was still an error case - it just wasn't consistently an error cas...

stoic sky Jun 25, 2025, 4:04 PM

#

hm, does breaking compat mean it breaks the whole chain? Say I have module A and B

A is dagger 0.18.9
B is dagger 0.18.11

If A has an enum and B calls A, is that supposed to break?

#

I see this when I try to run. I actually don't see it when I do dagger develop (ModuleAType is made up to mask real type name)

10:58:24  internal/dagger/dagger.gen.go:11779:8: ModuleAType (type) is not an expression
10:58:24  internal/dagger/dagger.gen.go:11798:2: ModuleAType redeclared in this block
10:58:24      internal/dagger/dagger.gen.go:11747:6: other declaration of ModuleAType

indigo whale Jun 25, 2025, 5:40 PM

#

hm, this one looks different

#

do you have the definition of ModuleAType?

#

we do have a test to check this exact scenario, i suspect something a little weird is happening

#

(to clarify, sounds like a real regression here)

stoic sky Jun 25, 2025, 6:45 PM

#

oh? When I upgraded ModuleA to 0.18.11 the issue went away though. Let me get you the def

#

It looks a lot like the other one

// ProxyType is the type of proxy to be used for the container.
type ProxyType string

const (
    // Default value, no proxy.
    None ProxyType = "NONE"

    // Local proxy also known as on-prem proxy.
    Local ProxyType = "LOCAL"

    // AWS proxy should be always used within AWS.
    AWS ProxyType = "AWS"
)

#

So, are you saying my ModuleA can remain 0.18.9 while B is 0.18.11?

indigo whale Jun 26, 2025, 10:30 AM

#

rip, okay, lol

#

so this is actually because AWS name and value matches

#

and this breaks

indigo whale Jun 26, 2025, 10:31 AM

#

stoic sky hm, does breaking compat mean it breaks the whole chain? Say I have module A and...

this is a pretty easy fix - this scenario should be supported

indigo whale Jun 26, 2025, 10:59 AM

#

https://github.com/dagger/dagger/pull/10647

stoic sky Jun 26, 2025, 12:26 PM

#

Ooh! I'm glad that's the case. Is this a hotfix worthy fix? Or should I hold my upgrade to 0.18.11?

indigo whale Jun 26, 2025, 1:08 PM

#

working on a collection of stuff in https://github.com/dagger/dagger/pull/10647

GitHub

Various enum member followups by jedevc · Pull Request #10647 · d...

Follow-up to #9518.

There was an issue where old dagger versions would create an invalid typedef when the enum name equaled the enum value
Reported by @nipuna-perera in discord.

stoic sky Jun 26, 2025, 2:46 PM

#

I'm going to hold off on updating and maybe even skip 0.18.11

indigo whale Jun 26, 2025, 3:02 PM

#

sounds good 😅 we should be shipping a v0.18.12 before the end of week, have spent all day trying to get fixes for this prepped

stoic sky Jun 26, 2025, 3:11 PM

#

You rock! Thank you for the quick follow up.

stoic sky Jun 27, 2025, 9:14 PM

#

Happy to report v0.18.12 fixed all the enum issues I had. Thank you for the quick turnaround!! ❤️

half portal Jul 1, 2025, 2:06 PM

#

@stoic sky I'm still getting this unknown enum value error in 0.18.12 - what else did you change to resolve this?

stoic sky Jul 1, 2025, 2:07 PM

#

What does your enum def look like?

half portal Jul 1, 2025, 2:08 PM

#

DV Environment = "dv"
AT Environment = "at"
PR Environment = "pr"

    // Environment code
    environment Environment,

indigo whale Jul 1, 2025, 2:09 PM

#

are you storing the enum value in a struct?

half portal Jul 1, 2025, 2:09 PM

#

No, just passing it to a few functions from the function it's an argument of

stoic sky Jul 1, 2025, 2:09 PM

#

DV Environment = "dv"
Try DV Environment = "DV"?

half portal Jul 1, 2025, 2:11 PM

#

Same error

indigo whale Jul 1, 2025, 2:12 PM

#

okay, how are you using the enum? i can't repro with the enum defs you've shared

#

dagger call do --env DV
▶ connect 0.2s
▶ load module: . 4.3s
● parsing command line arguments 0.0s

● test: Test! 0.0s
▶ .do(env: "DV"): String! 0.4s

dv

half portal Jul 1, 2025, 2:12 PM

#

It's passed to a function which accepts a parameter of type Environment

indigo whale Jul 1, 2025, 2:12 PM

#

package main

type Environment string

var (
    DV Environment = "dv"
    AT Environment = "at"
    PR Environment = "pr"
)

type Test struct{}

// Returns a container that echoes whatever string argument is provided
func (m *Test) Do(env Environment) Environment {
    return DV
}

half portal Jul 1, 2025, 2:13 PM

#

m.python(..., ..., ..., ..., environment, ...)

func (m *ServiceDeployer) python(
    ...
    environment Environment,
    ...
)

indigo whale Jul 1, 2025, 2:15 PM

#

what does dagger core version say

#

and dagger version

#

ah

#

you need to use const not var

#

i'm quite sure how you're even seeing an enum anywhere, dagger isn't detecting that

half portal Jul 1, 2025, 2:36 PM

#

dagger core version v0.18.12

#

dagger version v0.18.12

half portal Jul 1, 2025, 2:37 PM

#

indigo whale you need to use `const` not `var`

You mean var not const? Your example uses var

#

Moving it to var doesn't work, same error

#

There's something else going on here @indigo whale, if I replace that enum with strings and update the functions that accept that as a parameter it still errors on unknown enum value

indigo whale Jul 1, 2025, 2:52 PM

#

are there any other enums?

half portal Jul 1, 2025, 2:52 PM

#

facepalm

#

Yes

#0.18.11 enums breaking