#engine devex: regenerating docs on rebase?

1 messages · Page 1 of 1 (latest)

inland moon
#

this got buried and nobody saw it... maybe @pure wasp or @trail mortar have thoughts?

#

engine devex: regenerating docs on rebase?

trail mortar
#

I have no idea what that's about. I've never had to resolve any conflicts in that file, but just off the file path it's surely the PHP reference docs. Do we commit the result of the build? Why not build on CI before publishing? That's what happens with the other SDKs. Not the CLI reference though, but that produces markdown. Is there a particular part of that file that you hit more conflicts? Like a random hash for a class name or something that's different every time.

pure wasp
#

ah @narrow socket, we've talked about this before - we should just be able to cleanup the JSON after generation

pure wasp
#

they should 👀

#

but given the way we deploy through netlify, i'm not sure how feasible it is without changing some of the flow 🤔

narrow socket
pure wasp
#

I think we've discussed cleaning up the format right? so it's less likely to trigger merge conflicts (it's all in one line, so everything always conflicts)

inland moon
#

i'll have to look at what the conflicts actually look like, it's certainly plausible that pretty formatting of that file will avoid most conflicts

#

can we expand on "the way we deploy through netlify" ? presumably netlify is reacting to changes in a static committed file or something?

pure wasp
# 
[build]
  command = "yarn run docusaurus build"
#

that's what our docs build looks like - anything that's not built by that command is built and committed to the repo

narrow socket
pure wasp