#0.18.5 still works so it is a regression

1 messages · Page 1 of 1 (latest)

rustic sage
#

okay good to know, based on the error message you are hitting this when trying to use a module from a private github repo, right?

#

we do have integ tests that do exactly that, so not sure what the delta is

#

based on the connection timed out error I wouldn't be surprised if it had something to do w/ corp networks

untold remnant
#

Yeah that's my guess too, usually that happens when the proxy blocks something

#

The config for git is pulled from the host and it works with 0.18.5 so it must be something new 0.18.6 is trying to do

rustic sage
#

Gonna see if I can discern which op specifically would hit that endpoint w/ git-upload-pack set, based on our integ tests that do this

rustic sage
#

I haven't found anything yet, but my best guess is that somehow or another we are running a git command w/out proxy config set correctly, but it's unclear how that could be

@untold remnant just to do a sanity check, can you confirm that the v0.18.6 engine you were hitting this in has proxy config set as expected? i.e. HTTPS_PROXY.

I'm presuming that is required and is set in your v0.18.5 engine, lemme know if not correct

untold remnant
#

Yes, Eric, I double checked. This is the snippet I'm running to spin up a local engine in Jenkins. I am passing the proxies.

sh """docker run -d -v \$(pwd)/ficacert/cert.crt:/usr/local/share/ca-certificates/cert.crt \\
                    |-e https_proxy=...\\
                    |-e http_proxy=... \\
                    |-e HTTPS_PROXY=... \\
                    |-e HTTP_PROXY=... \\
                    |--rm --privileged -v /var/lib/dagger \\
                    |--name dagger-engine-v${DAGGER_VERSION} \\
                    |companyregistry.com/dagger/engine:v${DAGGER_VERSION}""".stripMargin().trim()
rustic sage
untold remnant
#

fwiw, we have SSO configured with github. However, when I try to hit the https://github.com/myorg/myrepo/info/refs?service=git-upload-pack I get a web form login. Which is weird.

rustic sage
untold remnant
#

This isn't super urgent btw. Since 0.18.5 works I'm not blocked. We can wait for Justin. I wanted to get ahead of folks that may upgrade to 0.18.6 and hit this error. But I can ask them to stick to 0.18.5.

rustic sage
untold remnant
#

Thank you for looking into it Eric!

charred fiber
#

ahh thanks, yes, the actual issue is that that pr changed a silent warning that happened when failing to fetch the remote, became a real error - we were branching on whether we got an error, and you'd get different behavior. wildly confusing and ephemeral, so it's better to have it be a hard error
but now, we've got a case like this, so yeah, need to handle proxies here 🙂

#

will fix today ❤️

charred fiber