getting to merge | Dagger | Page 1

wispy field Mar 6, 2025, 3:46 PM

#

@marsh lintel 👋

#

where is the conflict ? do you need help?

marsh lintel Mar 6, 2025, 3:46 PM

#

not doing any big refactoring - the biggest thing i've done is cleared up some dead code and renamed some variables

#

nahhh, it's all in the auto-gened code

#

almost done

#

what's the incoming merge conflict?

wispy field Mar 6, 2025, 3:48 PM

#

I removed bbi/

marsh lintel Mar 6, 2025, 3:48 PM

#

oh lol uh, where's it gone 👀

#

but yes, that'll be fun

wispy field Mar 6, 2025, 3:48 PM

#

a much smaller llm_env.go

#

not done yet

marsh lintel Mar 6, 2025, 3:48 PM

#

oh fine! yeah, if you hit merge conflicts, happy to help solve those (if you push it somewhere)

wispy field Mar 6, 2025, 3:49 PM

#

slight schema change in LlmMiddleware

marsh lintel Mar 6, 2025, 3:49 PM

#

yee, no worse than the other ones today

#

pushed!

#

linting should be passing now

marsh lintel Mar 6, 2025, 4:14 PM

#

wispy field I removed bbi/

(fyi i already removed bbi/gql since it way completely failing to even compile)

wispy field Mar 6, 2025, 4:18 PM

#

yeah it was dead code for sure

#

thanks

wispy field Mar 6, 2025, 4:42 PM

#

@jed my wip branch is pushed on my fork if you want

marsh lintel Mar 6, 2025, 5:14 PM

#

oop, will not get time to look anymore at this today (or this week actually, since i'm off tomorrow and this weekend to show my cousins round my home town)
but if it's not done before then, i'll pick it up when immediately when i get back!

marsh lintel Mar 6, 2025, 5:45 PM

#

related - https://github.com/dagger/dagger/pull/9649
this pr will let us not need to constantly keep updating the README to say llm.X, we'll just be able to say llm and it'll pick the latest

wispy field Mar 6, 2025, 6:26 PM

#

fantastic 🙂 thank you!

#getting to merge