#Shell: Bubbletea-ify shell

1 messages · Page 1 of 1 (latest)

merry pelican
#

@soft canopy, have you seen my comment on the cropped output? Does it happen for you?

soft canopy
#

With mouse input enabled, scrolling would svroll the progress, and holding shift would yield that cropped scrolling outer terminal behavior

merry pelican
#

Oh, maybe I misunderstood what's on the description.

#

Is it up to date?

soft canopy
#

it's up to date, but a bit confusing - when it says "currently" i means main / v0.15 / etc, not the PR

merry pelican
#

I meant this part:

Option B is implemented by this PR

So everything in that option applies in the PR?

soft canopy
#

yep - mouse handling is disabled, so to "scroll" the progress you currently have to hit Esc and use the keyboard

#

I'm leaning towards undoing that, and maybe implementing scrolling as a proper pager instead of the current "hop between spans" navigation behavior

#

but, that's kind of hard

#

either that or printing things to the scrollback as they complete, and you just can't navigate around things that already completed

#

basically removing the navigation feature altogether and leaving it as just a prompt

merry pelican
#

Maybe it's my mac's keybindings? I can't see clipped output. I can scroll, but the output is clipped.

soft canopy
#

are you using arrow keys / hjkl?

#

to be clear, scroll wheel does not work at all in the current configuration

merry pelican
#

I don't mean the progress, it's output from the shell.

soft canopy
#

those are one and the same

merry pelican
#

Arrow keys / hjkl don't work.

#

I mean when it's not doing progress

soft canopy
#

and you hit Esc first to leave input mode and swap to nav mode?

merry pelican
#

yup

#

This is my height. If I hit the nav keys, the "move" item goes white, but nothing happens.

soft canopy
#

ah - yeah, probably because it's a single item with a ton of output. that's what I meant by switching to a pager

merry pelican
#

If I scroll up, I can see this:

soft canopy
#

right now the TUI arrow keys/hjkl hop between spans, which really just tells it to render that span and then render outward until the screen is full

#

in this case it's one span that's taller than the screen

#

so, the fix would be to switch to pager-style scrolling i.e. line-by-line, while somehow preserving the original behavior for efficiency reasons (can't just render the entire scrollback on every frame)

#

or, we throw out the progress navigation feature altogether and just print spans to the scrollback as they complete

merry pelican
#

👌

merry pelican
#

I'm still getting cropped output. I thought you fixed it, was it only in the llm branch?