#access to private test modules
kind valley
similar change in public repo: https://github.com/dagger/dagger-test-modules/pull/6
oh seems like we need this change pushed in multiple repos (also seems like they are all same repos, just pushed to multiple git providers with varying visibility)
dusty wind
@lime otter I think you can help here, can't you?
lime otter
Yes 👌
kind valley
Hi @lime otter, pls let me know once you had a chance to look at this.
lime otter
Hi <@274903880343748619>, pls let me know once you had a chance to look at this.
Once PR is approved and merged I'll push on other repos
lime otter
Or, if Marcos is ok I'll give your a private SSH key that has write access on those repos and you'll be able to force push
I still havent taken the time to finish the pipeline to make this automatic
kind valley
sure. i am fine with either. First step is to get the approval though 🙂 @atomic nymph I think you are the best person to review that PR as you have most context of changes i am making there.
atomic nymph
On PTO today, will look through tomorrow 🙏
kind valley
oops, sorry. thank you.
dusty wind
@kind valley I'm here now
dusty wind
we did a quick sync with @kind valley and he'll make some minor changes in the code so we can keep the WithSDK API in a backwards compatible way which will not require any changes to the test suite 🙏
kind valley
an update, it seems what we discussed worked @dusty wind (to keep things backward compatible). I think the issue i was running into was because I had not regenerated the SDK codegen stuff, and the client/engine were not seeing same api.
dusty wind
an update, it seems what we discussed worked <@336241811179962368> (to keep thin...
that's great to know Rajat
atomic nymph
left comments in https://github.com/dagger/dagger/pull/9454
hopefully that's helpful, imo really not far off, we should be able to ship this soon
fyi @nocturne canopy @kind valley - looks like you're modifying similar code here with module loading.
https://github.com/dagger/dagger/pull/9505
https://github.com/dagger/dagger/pull/9454
Just flagging, I think that probably we want to try and merge Rajat's work soon, so he can be unblocked on the private go module access work - it doesn't look like a significant conflict, it should just be updating the ModuleSource.SDK value in @nocturne canopy's PR to be a ModuleSource itself