#Hi, not sure if I should post it to this
1 messages ยท Page 1 of 1 (latest)
the call is this one:
return await (
dag.
gha().
with_existing_pipeline(
"This is the name",
dag.
gha().
with_pipeline(
"This is the name",
"mycommand"
).
pipeline("This is the name").
with_strategy_max_parallel(10).
with_strategy_fail_fast(True).
with_strategy_matrix(
"version",
["10", "11", "12"],
)
).
config()
)
the new function: https://github.com/heuritech/gha/blob/strategy/main.go#L520
Hey! Can you confirm which version of gha you have installed in your Python module? It should be pinned in dagger.json. I'm wondering if you're targetting a different branch or commit that doesn't have that method included.
oh I thought if I install a module with the same name will override it but with another source it will work
I was trying to use my fork
{
"name": "pipeline",
"sdk": "python",
"dependencies": [
{
"name": "gha",
"source": "github.com/heuritech/gha@strategy",
"pin": "7ccaae96101a5c180029fc394d398873fa7e6226"
},
{
"name": "gha",
"source": "github.com/shykes/gha@bf36a0b37a75882e4a985179f090d86d2ad1dfb4",
"pin": "bf36a0b37a75882e4a985179f090d86d2ad1dfb4"
},
{
"name": "git-files-changed",
"source": "github.com/valorl/daggerverse/git-files-changed@e8b25b9c6589f13b362dcaf94acda967f26f6700",
"pin": "e8b25b9c6589f13b362dcaf94acda967f26f6700"
}
],
"source": ".",
"engineVersion": "v0.13.6"
}
I had that
but when I remove the gha which is not my fork I had to delete my folder sdk because it was not correctly updated with dagger develop
with this dagger.json I had a strange effect because the function with_existing_pipeline was missing but in the code gen I was able to find calls like with_strategy_XXXXXX which come from my fork
so it seems it did a kind of mix or I don't know
Hmm.. I also think it should override. This may be due to recent work on pinning dependencies. \ping @inner beacon @restive thorn
Huh, I really don't know what should happen if you have two modules with the same name
But yeah I would imagine that removing one of them shoouuuld correct it
That's so odd, I wonder how that's possible, it does sound similar to an issue me and @inner beacon hit the other day
Yeah so this one is a known bug, I'll file this one tomorrow - you should be able to do this, you currently can't.
If you have both... weird things will happen, we should probably try and explicitly error - I'll file a bug for this one too
But after you reset the dagger.json to have only one gha module, does it work properly? @true spoke?
I don't think this a regression - when looking at this code when helping with the dagger uninstall scoping, I realized the logic for this only matches by the source field, not the name
no I had to remove the sdk folder in my python function don' t know why, I tried to run dagger develop but it was not fixing the codegen
Just to clarify, did you see it in gen.py? Or through your ide's auto complete? I've seen weird things before where regenerating a file doesn't update the language server that powers auto complete
That's so so strange, I'll try and repro tomorrow
Yeah, if it was a PHP module, which creates one file per type, I would understand. But Python regenerates into the same file. I suspect it was possibly the IDE like Justin is saying. If it happens again, you can open sdk/src/dagger/client/gen.py to confirm what's actually there.
It was both, I thought my IDE was failing to do the auto complete, so Indid a search in the codegen
I will try to reproduce it
That's so odd, I wonder how that's possible, it does sound similar to an issue me and @Rajat Jindal hit the other day
in our case the dependency was getting removed completely from dagger.json for some reason.
I'm able to reproduce the issue I have a mix of the module all my method beginning with with_strategy_XXXX are generated but not the with_existing_pipeline
if you need something else I can share
What I meant was assuming you only have one dependency with the same name. It seemed that you were saying that even after removing from dagger.json the other duplicated entry, running dagger develop alone didn't work. You had to also wipe the sdk directory. Maybe you didn't do things in this order, which explains why you felt the need to delete sdk?
sorry I forgot to test this step ... I'm testing right now
ok now I can find it maybe yesterday I did in naother order but I'm pretty sure I did several dagger develop but I can't reproduce it
opened an issue for the weird name conflicts: https://github.com/dagger/dagger/issues/8821
cc @inner beacon, if you want to pick this one up, let me know ๐
i know it's inline with all the other uninstall/upgrade things you've been doing, so feel free to fold it in as part of that
YeH, sounds good. I think i should be able to cover this as part of one of those tickets