#🚀 v0.13.6 - 24th October 2024
chrome hemlock
Proposing the 17th for a release.
Here's the milestone: https://github.com/dagger/dagger/milestone/65
cc <@&946480760016207902>
me and @solid crest would like to get the shell pr (https://github.com/dagger/dagger/pull/8611) merged asap, so we can start getting feedback from users (under an experimental flag)
imo lots of the tasks on the pr should be moved into future prs, since just any feedback will be really useful here
chrome hemlock
I don't think we've had anything major feature-wise/bug-wise merged? So not really worth running tomorrow?
https://github.com/dagger/dagger/compare/dagger:dagger:v0.13.5...main
So gonna push this into next week I think
chrome hemlock
✨ v0.13.6 - ???
chrome hemlock
✨ v0.13.6 - 24th October 2024
let's go for the 24th - that's thursday 🙂
we should have some good enough stuff in to justify making a release now 🙂
sinful sail
cc @slim reef re our docs discussion
chrome hemlock
oop just realized tomorrow is release 😄 @solid crest are we shipping anything dsh-wise for this, or can we push it out to the next one?
cc @torpid python @cyan sequoia in case you have anything in flight you want in
we've got some good optimizations that will be good to get in, i think even just those will be good to have
torpid python
nothing here, still pushing my boulders
solid crest
oop just realized tomorrow is release 😄 <@768585883120173076> are we shipping a...
We could release something. I'm just doing final cleanups and inline documentation (comments) before committing changes. However I haven't added any new tests and need to document how to use it. Lot's of polish remaining but that's why it's experimental. We can also skip this release to polish it a little bit more, so I'm good either way.
chrome hemlock
We could release something. I'm just doing final cleanups and inline documentati...
I'm happy to merge without tests - as long as this is marked as experimental, and hidden, I think having something is actually kinda good
I got trust we'll get to adding them later 🎉
sharp swift
I vote for merging the shell as-is, hidden + experimental. Would be very useful to start getting mileage. Including internally, I'm playing with from within dev terminal, but would prefer to do it native
chrome hemlock
👋 morning all, could use a hand with an approval on https://github.com/dagger/dagger/pull/8763 to fix a broken ci job
approved https://github.com/dagger/dagger/pull/8708 @solid crest, but looks like Arg is still used in some tests
anything i can do to help on dsh?
solid crest
anything i can do to help on `dsh`?
Yeah, I need to fix that and index-url on the dependabot PR too. I'm just finishing off fixing the failing checks on dsh and will open for review.
I was going to add tests for command substitution but will prioritize fixing the Python PR.
Ok, dsh is ready for review
chrome hemlock
Ok, dsh is ready for review
will do this now 
chrome hemlock
for dsh - is it intended that I can run external commands in it?
$ dagger shell
Dagger interactive shell. Type ".help" for more information.
> whoami
jedevc
Yep, it's on purpose.
If the first command doesn't match a module function, nor a core function, it falls back to executing on host.
For the dependabot PR, there's an issue with index-url, but I'm going to fix it now. If it hasn't been fixed yet and it's the only thing holding up the release we can skip, just check back with me in case it's 2 mins away or something.
chrome hemlock
If the first command doesn't match a module function, nor a core function, it fa...
neat okay 🙂 i would kind of like to discuss about this in the future, but happy to ship what we have now as experimental 🎉
looking into dsh test failures, i think they're a result of the tui stuff i played with before
chrome hemlock
looking into dsh test failures, i think they're a result of the tui stuff i play...
yup, was this - pushed my fix
chrome hemlock
For the dependabot PR, there's an issue with index-url, but I'm going to fix it ...
oop, sorry sorry, i merged this pr by accident
i meant to get the other one that was open
solid crest
Oops
chrome hemlock
should i revert? or should i hold for your fix? either works
solid crest
I was just about to commit and push the fix, so I'll just create a new PR.
solid crest
All good, happens to the best of us 🙂
chrome hemlock
once tests are passing on dsh, good to merge?
prep pr ready to go in https://github.com/dagger/dagger/pull/8770
chrome hemlock
grrr accidentally managed to fat finger a rebase-merge of the dsh pr instead of a squash merge
looks like the default option is whatever you merged last, and since i rebase-merged https://github.com/dagger/dagger/pull/8715 yesterday, then that's been my default today 😢
@solid crest around for a re-review of the prep pr?
sharp swift
If the first command doesn't match a module function, nor a core function, it fa...
can we disable this please? It's important that scripts are 100% reproducible, so no host execution should be possible (since we don't know what's available on each host)
chrome hemlock
can we disable this please? It's important that scripts are 100% reproducible, s...
is this release blocking?
sharp swift
no, since it's all hidden anyway
chrome hemlock
prep pr ready to go in https://github.com/dagger/dagger/pull/8770
could i get an approval on, then i can kick off the release 😄
thaaaanks @sharp swift ❤️
chrome hemlock
pushing out the release till tomorrow - i haven't got enough time left in my day to run it
solid crest
Then I'll disable host commands in the shell 🙂
chrome hemlock
merged release notes, going to tag in a few minutes
chrome hemlock
tagging now
sinful sail
I don't think that this will impact releasing, but we keep seeing Dagger CLI sha256 checksum mismatches errors for the main CI runners only.
This works as expected locally, it seems like an AWS-only issue.
Still investigating, but wanted to mention it here just in case.
chrome hemlock
ah
interesting
i saw something like this the other day in a ci job
i wonder if we're caching a file somewhere?
head is the only case where it's not content-addressed - so the cache policy on that might need to be different
sinful sail
Yes, that is very likely. Trying a fix now.
chrome hemlock
let's move that conversation to #infrastructure?
sinful sail
Indeed: #infrastructure message
chrome hemlock
on the releasing note: @sinful sail @keen obsidian @brittle swan, can we update daggerverse?
we could also do the playground, but given the discussion yesterday, there's no real need to?
sinful sail
No need to upgrade Playground indeed. Yes to Daggerverse. One thing at a time 🙂
chrome hemlock
Removing it from RELEASING then 🎉
dagger-for-github pr here: https://github.com/dagger/dagger-for-github/pull/154
cc @winged shell
chrome hemlock
@winged shell wdyt about https://github.com/dagger/dagger-for-github/pull/153 ? in starting to automate more of that action, was thinking having some general sanity tests would be good?
winged shell
<@933501536624054272> wdyt about https://github.com/dagger/dagger-for-github/pul...
I'm a fan. We didn't have any outputs before, so adding one shouldn't affect anyone. 👍
I'm off to PTO soon, so won't have time to test today, but perhaps @woeful stump can do a review 🙏
chrome hemlock
ahh, are both you and @sinful sail off on holiday? (didn't see you on the #pto-feed)
winged shell
FYI whoever looks at the Daggerverse upgrade today, please ensure the preview env runners also get updated. @keen obsidian when Kyle and I were testing the other day with 0.13.5, the preview was still on 0.13.3
chrome hemlock
if so, maybe let's hold until at least one of you are back - i have a funny feeling that the output could present issues, super big outputs can cause some very strange failures
winged shell
ahh, are both you and <@796825768600141844> off on holiday? (didn't see you on t...
oh, thanks! I'm prob doing something wrong to not show up there.
chrome hemlock
🚀 v0.13.6 - 24th October 2024
sinful sail
<@933501536624054272> wdyt about https://github.com/dagger/dagger-for-github/pul...
I'll take a look at this, no worries.