🚀 v0.13.4 - 9th October 2024

[dusty anvil]

👋 <@&946480760016207902>

It's been a while - a few weeks, eek.

I'd like to get this release out ASAP - it has a few very important things: https://github.com/dagger/dagger/compare/v0.13.3...main

• We should get a big performance boost in file uploads from @summer sundial's work in https://github.com/dagger/dagger/pull/8436
• Improved annotations support in https://github.com/dagger/dagger/pull/8543
• Some improved error messages that will help in debugging our flaky CI from @brittle basin in https://github.com/dagger/dagger/pull/8553
• Typescript timeout issues should be fixed by @summer sundial in https://github.com/dagger/dagger/pull/8549
• Fix for unusable npm package by @summer sundial in https://github.com/dagger/dagger/pull/8560
• Improved ref parsing for a performance boost on some hosts from @magic rune in https://github.com/dagger/dagger/pull/8551
• Keep git dirs everywhere (also useful for context dir) https://github.com/dagger/dagger/pull/8318

And probably other stuff I'm missing

The milestone is here: https://github.com/dagger/dagger/milestone/63

@shrewd pollen if you're picking up the tmpfs mount one, does that one look achievable in your day today? If not, @brittle basin can this one be moved to the next milestone (or is there some urgency?)

@worthy blade should https://github.com/dagger/dagger/pull/8641 be milestoned? I think this one is blocking (since we have a priority request for it)?

I don't think there's anything else that needs to be in urgently? Should hopefully be a pretty calm release 😄

[summer sundial]

https://github.com/dagger/dagger/pull/8576 very important too if it actually works for our user (it should)

[worthy blade]

Sure - I think I can land something for the release if it's tomorrow

[dusty anvil]

we can push the release further out if neccessary, but would like to get those git + typescript fixes in asap 🙂

[shrewd pollen]

I don’t have a valid read on time estimates at this point. If it needs to fit into this release perhaps Erik and I could pair on it today

[dusty anvil]

yeah no worries, don't mean to chuck you right into the deep end 😄

[shrewd pollen]

no worries i like the deep end lol, i will just tell you straight up i am treading water and am not aware of how deep it actually is

erik will show up with scuba gear, taking the metaphor until it breaks

[split island]

@dusty anvil anything in here that we should have the Commanders test out? I can send a message to them today, but I need the info on how they can test.

[dusty anvil]

nothing particularly interesting feature wise here, so think we can give this one a pass

but we really should make it very easy to test out a preview release, will try and put some instructions for that together

[split island]

That would be awesome, thank you!

[brittle basin]

Oh I just realized that the 9th is tomorrow lol, I will knock out https://github.com/dagger/dagger/issues/8513 quickly in that case ( @shrewd pollen already has a PR for the tmpfs mounts that should be mergeable today or tomorrow pre-release)

[azure plaza]

I know @eternal bough has several PRs in flight waiting on review. Just flagging that here in case we can get some of these in

#maintainers message

[brittle basin]

first was merged, third was closed, second is pending bikeshedding since it's changing the default source dir to .dagger https://github.com/dagger/dagger/pull/8557#issuecomment-2399502533

[azure plaza]

I think we're good to go as far as I'm concerned on .dagger. The only open question I see in the PR is "should we ignore anything when deciding if the dir is empty". I can't think of anything, but we should probably merge and we can always follow up

[brittle basin]

Support for disabling the automatic init here https://github.com/dagger/dagger/pull/8656

[dusty anvil]

morning 👋 - starting to go through the milestone now, with an aim to cut the release later this afternoon

@summer sundial can we close https://github.com/dagger/dagger/issues/8524 ? think we've confirmation that this is fixed right?

[dusty anvil]

currently investigating the docs deployment failure - looks like this started failing after merging the expand functionality

got an idea of what this is, i think this is around the use of { in the output, which is somehow getting translated into mdx directly? and then failing in an internal build place

[summer sundial]

Yes we can close it!

[timid pecan]

I'm seeing a weird error in the docs build related to the TS SDK reference doc generation

6:00:04 PM:         Error: Can't render static file for pathname "/reference/typescript/modules/api_client_gen"
            at generateStaticFile (/opt/build/repo/docs/node_modules/@docusaurus/core/lib/ssg.js:119:15)
6:00:04 PM:             at runNextTicks (node:internal/process/task_queues:60:5)
6:00:04 PM:             at process.processImmediate (node:internal/timers:447:9)
6:00:04 PM:             at async /opt/build/repo/docs/node_modules/p-map/index.js:57:22 {
6:00:04 PM:           [cause]: ReferenceError: VAR is not defined
6:00:04 PM:               at _createMdxContent (server.bundle.js:75437:37)

https://app.netlify.com/sites/devel-docs-dagger-io/deploys/670676c71e7dc0458c026dba

ah, just reading above...i think you're seeing the same thing @dusty anvil ?

[dusty anvil]

yeaa

so there's an option to escape this

but it's only in a newer version of the plugin

and upgrading the typedoc plugin is very frustrating

but getting someway towards it

[eternal bough]

looks like this started failing after merging the expand functionality
got an idea of what this is

apologies that this is triggering failure. is there anyway we could have caught this in regular CI?

[dusty anvil]

yeah, the netlify job was failing and i mistook it for a flake

we should run docs site in our ci pipeline

that would have caught this (the netlify job is pretty flaky)

[timid pecan]

do you mean the netlify deploy preview? i know it used to be flaky, but i've found it fairly reliable over the last 6-7 weeks. it does sometimes fail and that's invariably because the netlify cache is stale

[dusty anvil]

yeah, fair enough - i think this is just a fuck-up on my part 😄 i think i've got a fix, gonna open a PR asap

[timid pecan]

np, lmk if i can help

[dusty anvil]

side-note - the typedoc docusaurus plugin docs are terrible

the options you provide are from: the docusaurus typedoc plugin, typedoc itself, the typedoc markdown plugin, the typedoc frontmatter plugin - and they're all entirely on different pages, and even different domains

</rant>

[dusty anvil]

https://github.com/dagger/dagger/pull/8660

this should be the docs fix ^ (cc @timid pecan)

[timid pecan]

approved, thanks!

[dusty anvil]

release prep pr in https://github.com/dagger/dagger/pull/8661

[dusty anvil]

anyone around to approve? @worthy blade @summer sundial @quaint trail (sorry for the pings)

[worthy blade]

approved!

[dusty anvil]

tagging now 🙂

[dusty anvil]

engine release done, now doing sdks/etc

• sdks done
• helm chart done
• docs done

@winter panther @quaint trail @magic rune @lofty girder daggerverse and playground can be updated 🙂

[azure plaza]

if you had to pick one small thing to automate after this release, what would it be @dusty anvil ? 😁

[dusty anvil]

dagger-for-github pr here: https://github.com/dagger/dagger-for-github/pull/150 (cc @zenith urchin @quaint trail)

improvement pr here: https://github.com/dagger/dagger/pull/8664

[dusty anvil]

SDK release notes are a nice low hanging fruit for next time - atm, we still need to manually click the release button on those, but this is simple to fix, so i'll take this one for next time 🙂

I feel like the points where our automation really sucks is the "last-mile" bits - the dagger-for-github pr, and the daggerverse update specifically

ideally, we should have a dagger action that does this step for us entirely - opens up all the prs in all the right places
but i'm not sure the current state of that (cc @quaint trail)

[dusty anvil]

i also think that we probably want to consider automating the tagging of sdk releases entirely once we do this - there's no reason to have to do this manually anymore - the tags we produce here are really just artefacts of the old published sdks, they're not important at all for modules

[azure plaza]

how do you feel about adding a checkbox "automate one thing you just did manually" at the end of the checklist, and starting with this release?

[dusty anvil]

yup, sounds reasonable - as long as it's not attached to the improve-releasing pr (or the releasing process in general), ideally we get those in as quick as possible

[azure plaza]

I didn't understand that, sorry

[dusty anvil]

it shouldn't be part of https://github.com/dagger/dagger/pull/8664

because that one bumps the version of dagger in our ci

and we want to start using the newest release version right away to maximize our bug catchment 😄

(automation is gonna be my first task tomorrow, i'm running towards eod right now)

[azure plaza]

ah I see! 👍

[zenith urchin]

I'll update the major version tag

git tag --sign -m "2024-10-09" v6 --force
git push origin v6 --force

[dusty anvil]

❤️ thanks!

[dusty anvil]

first issue found in #daggernauts message

thoughts on doing another follow-up release tomorrow to patch this? since it can cause a panic when loading certain old modules

cc @brittle basin ^ (finished debugging the thing we just chatted about)

[brittle basin]

There appears to be a legit test failure due to the fact that the client can't even connect when it's version 0.9.9, poking at it since it's past EOD for you

[dusty anvil]

Ah it doesn't need to be that old - just before 0.12.0 actually

But yeah, I guess we might not be able to do a direct query approach here

[brittle basin]

That's the thing, min client got bumped to v0.12.5: https://github.com/sipsma/dagger/blame/0896a3cbbd06e92f7867217ca9a631b002fb509a/engine/version.go#L29-L29

So wondering if that min version on tree of v0.12.0 even makes sense anymore

[dusty anvil]

Min client can be 0.12.0 while the module version it calls can be lower 😭

[brittle basin]

Right right, so just need to refactor the test to use modules

I can do that quick

[dusty anvil]

Perf 👌

Does it justify a follow up release this week? Or is it niche enough of a case to wait till next week?

[brittle basin]

Not sure, bu tI'm sort of inclined to "just release it" since in the past when I thought something was obscure within a few days 3 people had hit it and just decided to do the release; would have been less painful to not wait in the first place

I can run it tomorrow if others agree

If we chip away at automating every release it will get less and less painful

[dusty anvil]

Sounds good, I'll do my automation pr tomorrow so it'll be sliiiightly better 🙂

[brittle basin]

Made a new thread here: #1293647062549921854 message

Pushed the test fix to your PR, will approve and merge on green

[brittle basin]

Merged it, worth a double check on your end the test looks good to you now too when you are online tomorrow

[zenith urchin]

Seems nobody grabbed daggerverse upgrade yet...

[dusty anvil]

looks good 👍

[dusty anvil]

my improvement: https://github.com/sagikazarmark/daggerverse/pull/183
need to hold on mark's review etc, so might not be quite ready for this release (we could always temporarily fork it?)

🚀 v0.13.4 - 9th October 2024