#π v0.13.2 - 20th September 2024
1 messages Β· Page 1 of 1 (latest)
π§΅
cc @dark abyss <@&946480760016207902>
just noticed with @dark abyss that we've got a weird tui regression in v0.13.1 where we accidentally seem to output loads of empty lines
potentially caused by https://github.com/dagger/dagger/commit/def0b1e9c9f22d5c196952e0024c76f25168fb6e#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R105, which downgrades midterm
potentially considering if we should run a hotfix release either today/tomorrow? to fix both this and https://github.com/dagger/dagger/pull/8491
pretty sure it's that, yeah - I changed the RenderLine to not include the trailing linebreak a long while back, meaning the caller has to print it, so now that we've downgraded they're both printing it: https://github.com/vito/midterm/commit/118a6fd3b6bd953fa202979bbce0701888af6366
we can probably go right ahead to v0.2.0 which also has some perf improvements
yeah, that sounds good to me π€
although if we're doing a quick urgent release, i think a rollback to the one that definitely works would potentially be safer?
i'm towards the end of my day here, so can't run anything today, but could tomorrow?
yeah we can save v0.2.0+ for later
@native vapor @dark abyss would either of you want to run it? if not, i can pick it up first thing tomorrow
i really want to avoid releasing next week, given we're off to san diego the week after
although there's also https://github.com/dagger/dagger/pull/8447, which would be great to bring in so we get to use the update notification
I can do it tomorrow, today's a bit busy for me
i'll make sure that gets in if it's not already π
just gimme a ping if things get out of control for timing, i should have a spot of time tomorrow morning to get it done if you want me to
dependabot also does this insanity for buildkit, it has no idea what the most recent version is somehow, and keeps trying to upgrade us from master to the latest release on a release branch (which is likely a downgrade, since only some commits get cherry-picked over to it)
@acoustic tree can we move https://github.com/dagger/dagger/pull/8436 out of the milestone? we're going to v0.13.2 today, and i'm not sure if it's ready?
The Pr is good, I'll just remove the commented code, add a release note and we're good
^
I also would love to merge that one: https://github.com/dagger/dagger/pull/8476 I did the test dashboard, everything's okay, it only update a benchmark workflow, so could I merge it for 0.13.2?
why does it need to be merged for the release? it runs every night right?
it's not in the release, so doesn't need to follow the same timeline (same applies to all our ci)
@formal crag was reviewing that one, so I would let him have another glance given there's not a rush for the release
I see
manually confirmed that the new version annotations in the manifest are working as expected! https://github.com/dagger/dagger/pull/8447#issuecomment-2363415402
v0.13.2 should appear as user notifications
Reviewing it later today β doesnβt need to be in the release
π
I'm around, can kick off the release in a bit!
i think it should be good to go whenever π
@dark abyss i also downgraded grpc btw: https://github.com/dagger/dagger/pull/8507
i might reconsider the way we bump dependencies for the engine π’
cause this was a bit annoying
weird, did they break something in grpc?
there was some very weird bug, it looks very much like https://github.com/grpc/grpc-go/issues/7641
What version of gRPC are you using? 1.66.2 But seen on all versions of 1.66.x so far. Issue did not occur on 1.65 What version of Go are you using (go version)? N/A What operating system (Linux, Wi...
we get this weird internal error received 4294967270-bytes data exceeding the limit 65535 bytes from a user, and i've not seen it before π¦ so yeah, downgrading in the meantime feels like a safe bet
why cant i rerun a failed job when another job is still running
what's up with all these failing [sdk]-dev jobs? is this just spot instances being spotty?
Spot instances yup, I know @nova mulch is on this one
someday i hope for a rerun to land on an instance that doesn't immediately detonate 
ok to be fair a few of these are something else - random network issues fetching modules:
github.com/containerd/console: github.com/containerd/console@v1.0.3: Get "https://proxy.golang.org/github.com/containerd/console/@v/v1.0.3.zip": stream error: stream ID 19; PROTOCOL_ERROR
feels like this happens more often than it should
#infrastructure message That was the earliest I started seeing this.
Never see it locally (does anyone else)? I figured at the time it was just some ephemeral infra networking issue, but it's odd it seems persistent
"Persistent" in that it pops up at least a few times a week ephemerally, as opposed to "happened for a day once and went away forever"
but also you'd expect to see way more networking errors all over the place if it was something low-level, not just go module downloading
got a googlewhack from it π
maybe it's something specific to QUIC/HTTP2/whatever fancy protocol Google is using everywhere
there's also this message: protocol error: received DATA before a HEADERS frame (https://dagger.cloud/dagger/traces/6396fba9fb2f11272cc2c2f2781e28ad?span=aa6848d845aae4d0#aa6848d845aae4d0:L17)
ok, green (enough, macos publish still errors, assuming that's not fixable atm) - tagging following RELEASING.md πΌ !
Oh nice, that leads to https://github.com/golang/go/issues/69544 opened 12h ago by bradfitz
Go version go1.23.1 Linux (on GitHub Actions CI runs) What did you do? A ton of our GitHub CI jobs started failing today with http2 protocol errors from proxy.golang.org while fetching modules. e.g...
pushed v0.13.2 tag
everything's shipped! time to bump Daggerverse and friends, cc @cold tangle @lapis oxide @nova mulch @native vapor @fast mantle
new version released π https://github.com/dagger/dagger-for-github/releases/tag/v6.10.0
bumping daggerverse and the playground now
https://discord.com/channels/707636530424053791/1286784922534809725 - for fixing the version nag being too naggy
thanks for the merge on dagger-for-github, but please move the major tag to latest π doing now
https://github.com/dagger/dagger/blob/main/RELEASING.md#:~:text=Force update the major version
done β