#๐ v0.13.1 - 18th September 2024
1 messages ยท Page 1 of 1 (latest)
๐งต
milestone here: https://github.com/dagger/dagger/milestone/60
No fixes in particular or anything like that -- I have this chicken and egg problem described here: https://github.com/dagger/dagger/pull/8396
mm, agreed
I'll just wait out for 13.1 to come out before being able to use WithAnnotation in our pipelines, so we can use it and hopefully 13.2 will be annotated and that's where we'll be able to use version checks
i feel like some time next week would be good to aim for
Alternatively ... run dagger in dagger for the publish pipeline, but that's a big undertaking
๐ค if we're confident in the logic
we could potentially ship the cli changes in v0.13.1
and so it'll notify for v0.13.2
SGTM also
We need to have a way to test it before chucking it into the wild tho, is there a way of pointing the version check image to a custom place?
That way, at least we can manually confirm
I've been testing by changing the code, but I could add an env variable
ugh, actually no because to test we also have to remove the DevEngine check (it won't check version if it's a dev CLI)
We can manually override the --tag when testing so we can "make it" a prod engine
I've split the PR into:
- CLI changes (can ship IN v0.13.1): https://github.com/dagger/dagger/pull/8396
- CI changes (requires v0.13.1 to be released before merging): https://github.com/dagger/dagger/pull/8447
let's aim to land this release on wednessday, the 18th - there's still a few fixes open on the milestone that would be good to get in!
โจ v0.13.1 - 18th September 2024
@covert harness I'm happy to run this release since you did the last one (or two?)
thanks! that would be great, i think the RELEASING guide is up-to-date, though there are some more recent changes to be aware of (everything gets tagged on one commit, and the sdk releases are all automatically made)
i think all the things that need doing are milestoned, there shouldn't be any surprises sitting around
Merged the SSH AUTH SOCK improvements PR @still pewter
About to merge the fix to autoselecting secret plaintext once CI is done: https://github.com/dagger/dagger/pull/8468
After that looks like a handful of python PRs from @silver tusk, will review + merge them today if possible. Otherwise just want to make sure everything is merged tomorrow PST morning ๐
<@&946480760016207902> milestone is empty so starting this release in a few
@ruby elk do we need to wait for this release at all if we are about to ship the docs changes?
no
Making sure CI is green on main first, seems to have just been spot instance cancellations + the flake with go build cache bug but re-running everything to be sure
Changelog + version bump PR here: https://github.com/dagger/dagger/pull/8488
thanks thanks again for taking this one โค๏ธ
of course! โค๏ธ
Merged that, CI is green other than the macos provisioning tests: https://github.com/dagger/dagger/issues/7980#issuecomment-2359169720 We've had problems installing docker (not even at dagger steps yet) for a long time with those and from what I can tell it's degraded even more to the point where I can't see the last time on main we actually successfully installed docker in that step...
So just gonna have to move forward, nothing new, just noting that whatever the issue is with the macos runners it seems to be even worse now.
publish engine v0.13.1 job here: https://github.com/dagger/dagger/actions/runs/10928282725
should we just hookup a mac mini in a closet somewhere?
Honestly yeah that would be more useful than the current state. Same with a Windows box
we actually have a Windows NUC that was lying around in a closet, I gave it to @still pewter last week, of course it has a defect fresh out of the box but he's on it
His plan was not to keep it running non stop as a CI server though, might use a lot of power, but if it solves a hair on fire problem he could just expense the power cost ๐
or @granite prism could host it since he ate a lot of veggies and got tons of fiber ๐
We'll keep having Windows bugs until we get it, so hair may not be on fire per-se but definitely smoldering continuously
yeah I know, internet is quite useful nowadays ๐
(issue: https://github.com/dagger/dagger/issues/3462, also past attempts have proven it to not be tenable w/ GHA runners, which seems to be what is slowly happening w/ macos too now: https://github.com/dagger/dagger/pull/8029)
I have the option of 2gbps internet now at my new house, so I also could use this as an excuse to upgrade ๐
we can spin up windows machine on aws fwiw, we have an account dedicated for the CI
Can we get bare metal machines?
That's the main blocker with the GitHub workers for GitHub
Oh right I forgot about the bare metal need, AWS has those but not sure if for windows and they are usually incredibly expensive anyways
(every time I think of them I reminisce when I worked on Firecracker at AWS and had no choice but to use a bare metal ec2 instance for my dev machine, 100+ cpus and like 512 GB of RAM
)
Release is moving forward, Go+Python SDKs published so far, working on the rest
Okay sdks+helm-chart are all published, I am gonna check on our separate docs channel before updating the website (which bumps install instructions from v0.13.0->v0.13.1) since there are apparently docs changes in flux
All good there, install instructions updated https://docs.dagger.io/install
Need to update Playground, Daggerverse + Cloud now (cc @upbeat anchor @rotund yacht)
dagger-for-github bump: https://github.com/dagger/dagger-for-github/pull/147
FWIW I've had decent experience with MacStadium - they gave me a free Mac Mini for Bass since it's open-source, just had to put their logo in my readme ๐
I say "decent" because I randomly got locked out once, but hey, it was free
nix auto updated already
Pending:
- [x] dagger-for-github
- [x] playground, daggerverse + cloud updates
- [ ] homebrew autoupdate PR is merged https://github.com/Homebrew/homebrew-core/pull/191142
- [x] get approval and merge improve releasing PR https://github.com/dagger/dagger/pull/8490
helping with 1 and 2 here
1 done. If I could get a quick ๐ on https://github.com/dagger/dagger.io/pull/3968, we can close 2
:sus:
Oh yeah I mentioned that here too #infrastructure message IIRC we sometimes need to cycle out older runners to make room for newer ones?
yes, just found something
trying to unblock now
one of the jobs in my PR just unblocked, so seems to be working ๐ https://github.com/dagger/dagger/actions/runs/10928652308/job/30338811345?pr=8490
ok, we should be good now
I got this interesting stray "check for updates" check in GH on the improve releasing PR: https://github.com/dagger/dagger/pull/8490
check for updates โ failed to resolve image: GET https://registry.dagger.io/v2/engine/manifests/latest: MANIFEST_UNKNOWN: manifest unknown
Links to a check in cloud traces that doesn't actually show anything
https://dagger.cloud/dagger/traces/0c246d82f057a14b09418328a86a54a4
Guessing this is a side-effect of the CLI check here https://github.com/sipsma/dagger/blob/a0f7ed3385bcfbc65278228e69f8ea06980f57cd/cmd/dagger/version.go#L86-L86
I'll just ignore for now so that PR can be merged and then https://github.com/dagger/dagger/pull/8447 can be rebased on it
Need a shipit on https://github.com/dagger/dagger/pull/8490 btw whenever anyone has a asec
known issue - i can put up a quick fix to just remove that span. it's tricky to integrate because it happens before we actually set up the root span, so right now it ends up being its own little root span outside of everything (resulting in a whole extra dummy trace just for it)
Makes sense, thank you!
Only pending thing left is homebrew pr being merged https://github.com/Homebrew/homebrew-core/pull/191142
Otherwise everything done and looking good so far!
Was merged last night ๐
๐ v0.13.1 - 18th September 2024
@feral oracle are we good to close this thread ?
Oh I "closed it" by changing the emoji from โจ->๐ haha
I can discord-close it too if helpful for clearing out noise