🚀 v0.12.7 hotfix release - 2nd September 2024 | Dagger | Page 1

fast pulsar Sep 2, 2024, 10:22 AM

#

🧵

#

cc @vestal forge @haughty otter @quasi fable

#

today is a us holiday - so a bit sad to do this today, but unfortunately i think this is a big enough regression to justify it now

royal fjord Sep 2, 2024, 10:34 AM

#

~~I was trying this right now, and was wondering why its not working~~

nvm, my scenario is a little different. I was trying dagger init --name testme --sdk github.com/dagger/dagger/sdk/rust and its failing with a different error msg.

vestal forge Sep 2, 2024, 11:50 AM

#

LGTM! I'm around & available to help push it through. Ping for any reviews, etc. 💪

fast pulsar Sep 2, 2024, 11:58 AM

#

spent way too long trying to understand the root cause, and trying to put together a minimal patch
i'm also going to follow-up with some more complex changes, i think this code needs to be made more readable, and should ideally rely much more heavily on the git primitives in buildkit (since they handle a ton of very difficult edge cases)

#

pr fix https://github.com/dagger/dagger/pull/8298

GitHub

fix: make Git.tags url parsing consistent with Git.tree by jedevc ·...

Fixes #8291.
Previously, extracting the git tags from a URL skipped a level of url pre-processing that was in buildkit (essentially, one that allowed no protocols in URLs). We need to add this leve...

#

starting release prep now in parallel

fast pulsar Sep 2, 2024, 1:44 PM

#

release prep pr here: https://github.com/dagger/dagger/pull/8299

fast pulsar Sep 2, 2024, 1:46 PM

#

fast pulsar spent *way* too long trying to understand the root cause, and trying to put toge...

hm, yeah, i still don't fully understand why this didn't appear without the versioned case - i'm gonna follow-up with some refactoring prs as well (with less urgency) - one of them is needed in buildkit: https://github.com/moby/buildkit/pull/5293

fast pulsar Sep 2, 2024, 2:33 PM

#

tagging 🎉

honest arch Sep 2, 2024, 2:49 PM

#

just saw it

fast pulsar Sep 2, 2024, 2:52 PM

#

no worries, all handled, it's the day off 🙂

#

sdks+helm all done 🎉

#

@magic flame @cunning saddle @vestal forge cloud/daggerverse/etc ready to update

#

dagger-for-github bump here: https://github.com/dagger/dagger-for-github/pull/145

honest arch Sep 2, 2024, 3:10 PM

#

fast pulsar <@336241811179962368> <@628392087880073217> <@796825768600141844> cloud/daggerve...

Had a PR working locally for the 0.12.6: https://github.com/dagger/dagger.io/pull/3919, which could be used as a foundation for the 0.12.7 bump on daggerverse .
Preview failed and didn't know how to debug it cc @magic flame

fast pulsar Sep 2, 2024, 3:59 PM

#

improvement pr: https://github.com/dagger/dagger/pull/8303

fast pulsar Sep 2, 2024, 4:00 PM

#

fast pulsar improvement pr: https://github.com/dagger/dagger/pull/8303

looks like some of the jobs are pending waiting for a worker 😢

#

🚀 v0.12.7 hotfix release - 2nd September 2024

vestal forge Sep 2, 2024, 4:57 PM

#

honest arch Had a PR working locally for the 0.12.6: https://github.com/dagger/dagger.io/pul...