#docs PR fail

1 messages · Page 1 of 1 (latest)

warm wadi
serene urchin
#

hm, okay, odd - so, in this case, we just did the release recently, and mayyybe some of these weird things should have cleared up 🤔

#

so i've hit the update with rebase button on your pr:

warm wadi
#

looks like the same two tests failed?

#

Weird - DCO passed, but then it mentions unverified here.

serene urchin
# warm wadi looks like the same two tests failed?

yeah, okay, bleh - i'm gonna approve it from my pov anyways, it's clearly not this change that's causing the issue - we're experiencing a bit of a ci instability, i'll be diving into some of that today, but we don't need to block the pr on that

serene urchin
#

it essentially just declares that you're the author of the commit

#

but the "unverified" bit in github refers to using gpg signing of commits - this generally happens when one of the users has configured gpg signing, but hasn't actually signed that specific commit

#

(it's not an issue, we're not strict about this, i don't consistently gpg sign commits either)