#8042
fierce sleet
traces for failing pipelines:
It seems to be mostly this error @winged plaza @timid maple :
failed to collect IDs: failed to collect IDs for field "Python": expected *ModuleObject, got <nil>
winged plaza
will dive in, yup
we have consensus on everything
i think there's a few points about.daggerfrom folks in https://github.com/dagger/dagger/issues/8123
it seems there's a few people with concerns around it
that said - since it's not in module urls, we can easily change it later
so not a blocker
fierce sleet
Yeah that's not a blocker. It's easy to revert (doesn't break any imports) and we're going to use it as bikeshedding for https://github.com/dagger/dagger/issues/8123, which is a decision that will affect everyone.
So merging this will actually help the bikeshedding discussion in 8123
winged plaza
yup nice nice
timid maple
I have a few things to wrap up before going away but let me know if you need help resolving a merge conflict.
winged plaza
will dive in, yup
working on fixing ci now
fierce sleet
mostly I'm stuck on that weird "failed to collect IDs" error
winged plaza
@fierce sleet just noticed the README has gone - i'd like to keep it, it's got valuable info for new contributors, where should we put it?
timid maple
Btw, we still have a bug in the find up logic where if a module in a subdir of the repo fails to load (e.g., syntax error in module code), it’ll continue the find up and runs a "parent" module if it finds one. Nothing to do with dependencies, just parent dir with a dagger.json. So this change will bring those errors back. Justin, do you have bandwidth to try and solve it in the next few days? Doesn’t have to block this PR.
winged plaza
yeaaaa, i can find some spare bandwidth
i mean, i already got so distracted from dag.Self on autogenerated sync methods
what's one more distraction
timid maple
I know the feeling!
fierce sleet
<@488409085998530571> just noticed the `README` has gone - i'd like to keep it, ...
It's in .dagger like the rest
winged plaza
It's in `.dagger` like the rest
oh bleh
you're right, git didn't notice it as moved
fierce sleet
Maybe because of too many edits?
winged plaza
It seems to be mostly this error <@488718750690967563> <@768585883120173076> :
...
found it
looks like a sorta legitimate bug, will open an issue/pr for that as well
fierce sleet
thank you!
winged plaza
aight 🎉 just gonna head off and go to some lunch and will get back to it asap 😄
winged plaza
merged 
winged plaza
It seems to be mostly this error <@488718750690967563> <@768585883120173076> :
...
@slim nest i opened a pr with just a test in it for this: https://github.com/dagger/dagger/pull/8132
i think it's potentially something to do with the secret scanning in objects we introduced?
slim nest
<@949034677610643507> i opened a pr with just a test in it for this: https://git...
Pushed an extra commit with the fix! I'll approve it once CI is done. It feels like an awkward "self-approved PR" so will wait to merge unless it's blocking anyone actively