SDK aliases | Dagger | Page 1

dusky moth Jul 31, 2024, 11:54 AM

#

It would be really cool to not have the whole github.com/dagger/dagger/... required in dagger.json
Technically it's merged upstream, and we should have a way of making it "special" - will also avoid typos, etc.

#

We shouldn't bundle it (at least for now) - that takes up lots of space, it should just be for the core sdks that are relatively stable

#

But we could have aliases - <prefix>/php and <prefix>/elixir would be really cool

#

cc @timber grove @pearl saffron @pure tinsel

potent atlas Jul 31, 2024, 11:56 AM

#

contrib or x (for experimental)

dusky moth Jul 31, 2024, 11:56 AM

#

i like both of those

#

x is common in go, but might not be elsewhere?

timber grove Jul 31, 2024, 11:57 AM

#

Yeah, we used to use /x/ in the cue days for user contributed packages that weren't stable enough to go in our stdlib.

#

It was our "universe", before the "daggerverse". 🙂

potent atlas Jul 31, 2024, 11:58 AM

#

or could use dag/ for official but not bundled sdks

timber grove Jul 31, 2024, 11:59 AM

#

contrib is more common outside of Go. I've seen that in projects on different programming languages.

#

It usually means exactly what it is for the PHP SDK.

pure tinsel Jul 31, 2024, 11:59 AM

#

contrib is also the naming convention for one of Debian's package repositories

timber grove Jul 31, 2024, 12:01 PM

#

Pinging @indigo obsidian for ecosystem.

pure tinsel Jul 31, 2024, 12:02 PM

#

I like x because it's short, but I personally have not seen that before and wouldn't have known what it meant without the explanation.

I like contrib because it's quite clear what it is, but it is a bit longer. (And I might be bias because I have seen that one before)

That's my thoughts at least

dusky moth Jul 31, 2024, 12:03 PM

#

another option is community/<sdk> - that's another fairly common one

pure tinsel Jul 31, 2024, 12:05 PM

#

community is very clear, I don't think anyone could misconstrue that one.

That naming convention is used in Blender for the same reason.

pearl saffron Jul 31, 2024, 12:13 PM

#

vote for community 🙂

dusky moth Jul 31, 2024, 12:16 PM

#

will throw something together then 🎉

dusky moth Jul 31, 2024, 12:49 PM

#

https://github.com/dagger/dagger/pull/8067

GitHub

feat: add community sdk aliases by jedevc · Pull Request #8067 · da...

This allows users to use community/elixir to use the elixir SDK, and community/php to use the php SDK, without needing the full github.com/dagger/dagger/sdk/<sdk>/runtime@<version> URL ...

#

it depends on another pr i've been working on so we can get the version pinning working correctly 🙂

potent atlas Jul 31, 2024, 12:52 PM

#

that was ⚡ fast

#

@dusky moth minor comment to resolve on that

#

My understanding is that you can now do --sdk=community/php but the full git url will be put in the dagger.json for the module?

dusky moth Jul 31, 2024, 1:05 PM

#

potent atlas My understanding is that you can now do --sdk=community/php but the full git url...

tested this, nope, the dagger.json will have community/php

#

which is nice, since it'll stay up-to-date

potent atlas Jul 31, 2024, 1:06 PM

#

oh, that's perfect

dusky moth Jul 31, 2024, 1:09 PM

#

@pearl saffron mentioned we should allow explicitly pinning it though, i like that idea - you should be able to do community/php@specific-version if you want

potent atlas Jul 31, 2024, 1:20 PM

#

that makes sense

dusky moth Jul 31, 2024, 1:21 PM

#

potentially this is kinda cool as well - you could pin to a future version of an sdk if you can't upgrade for whatever reason (so i guess we should be a bit more conservative in updating engineVersion values for the sdks so we don't close that avenue)

pearl saffron Jul 31, 2024, 4:58 PM

#

Is it support a commit like community/php@<commit> ? Seeing from the PR, it should work out of the box.

dusky moth Jul 31, 2024, 5:02 PM

#

yup, added that support after your suggestion 😄

pearl saffron Jul 31, 2024, 5:04 PM

#

Love it! 😄

#SDK aliases