#๐ v0.12.4 - 2nd August 2024
1 messages ยท Page 1 of 1 (latest)
๐ looking at running a release this Thursday, with a fewer bigger pieces to land: https://github.com/dagger/dagger/milestone/55
There's a few things in the milestone that have to do with improving the release process itself:
- https://github.com/dagger/dagger/pull/7858 which ensures that all dev releases are going to get nice semver versions
- https://github.com/dagger/dagger/pull/7705 which changes the release process to avoid the difficult bump-engine PR which slows things down
additionally, we also have some smaller fixes to cli/tui progress and secrets
@native citrus do you have an update on the context directory work?
cc @upbeat lava @dire crane @cosmic tiger @dawn hull @safe pendant @frozen sundial @native citrus @mortal nova @wise shadow
yes, by changing the argument in normalizeCallerLoadedSource, it breaks some config things, I'm trying to fix that too to do more progress.
I'm about to just add a field RootRelPath to moduleSource that will be the relative path based on the contextDir to avoid these issues but it looks like a hack and not an actual solution
Too good! Will check out these most likely tomorrow. ๐ช @stone nymph
Thanks @stone nymph !
@native citrus @upbeat lava for the two items that mention "changelog" in the milestone, do you think we should cover those in next week's community call at all?
Also, is there any way to add @stone spoke to the tag list when these threads are made? Would be good for him to get the alert when releases are going out too.
Thanks!
if context directories make it in, then i think worth bringing in the community call - don't think the bug fix needs one though
Yeah, hopefully I can show the context dir, can I give a confirmation tomorrow?
๐ hallo, any update here?
fyi, there are a few more prs in the milestone that need reviews, any help from anyone is appreciated ๐
the aim is still to go tomorrow
Hey, I did a lot of work on it tomorrow, seems like changing the path isn't enough, it introduces other bug so I'm working on another way to fix that, still need to make it work but it more likely to make it work if it goes as expected
This part of the code is super super shady btw
I made it work!!! I fix one last error handling case and it should be good ๐
@stone nymph @dire crane @upbeat lava Context directory: https://github.com/dagger/dagger/pull/7744 is complete and passes all tests on local CI.
Let me know when I can get a review! ๐
@dawn hull I think I can do a quick demo tomorrow if you want
I could also demo https://github.com/dagger/dagger/pull/7864 if we have multiple slots open
Great! Yes, a demo of both during the community call next week would be great. The community enjoys seeing these updates.
Note that we will be live streaming the community call next week, so please try to start with a "why should I care?" section before you demo, so a new Daggernaut has some more context about why it is cool
Okay!
Ran out of time today, need to give this one a close read, will carve out time tomorrow night!
Yes please
going to move it out of the milestone, since i would still like to have the release today if we can ๐
starting to merge things in the milestone ๐
@frozen sundial wdyt about merging https://github.com/dagger/dagger/pull/8067 ?
or do you think it needs more time for bikeshedding?
This allows users to use community/elixir to use the elixir SDK, and community/php to use the php SDK, without needing the full github.com/dagger/dagger/sdk/<sdk>/runtime@<version> URL ...
Let me know when you reviewed my PRs so I can update them if necessary
if anyone has a moment, i made a small mistake in a previous pr for the releasing workflow: https://github.com/dagger/dagger/pull/8073
just need a quick sign-off on that
Approved
thanks thanks ๐
Just a moment, I want to see if I can get a deprecation in. I'll review afterwards. I think we should to bring it up in the prod dev meeting, but also don't see a problem releasing it before then as I don't expect any push back.
let's play this one safe - we can push it into the next milestone, I think the idea of discussing at proddev is good (solomon might also have thoughts when he's back)
since if we do it we have to support that value indefinitely to not break the daggerverse ๐
@frozen sundial looking at your deprecation now
could you quickly glance at https://github.com/dagger/dagger/pull/7956 ? it should be a pretty simple change, but should help clean up messy output users have complained about recently
Yeah, already on it.
โค๏ธ
@stone nymph Feel free to review https://github.com/dagger/dagger/pull/7744 whe you have a minute
API changes
This PR updates the Function and FunctionArg from our engine API to support defaultPathFromContext
Function
withArg(
"""
If the argument is a Directory or Fi...
@frozen sundial Same for https://github.com/dagger/dagger/pull/7864
Not forgotten, but no time to get in time before release. It's not an quick review, both of them. I do plan on doing them either today or tomorrow.
Okay not a problem! Hopefully it will be ready for the next release then!
release notes pr using the new process: https://github.com/dagger/dagger/pull/8077
still blocked on https://github.com/dagger/dagger/pull/8076 though
all good.
question - how does the automated homebrew-core PR work? we need to add a new -X github.com/dagger/dagger/engine.Tag=v#{version} flag to the build for v0.12.4
but it should be updated at the same time as the version bump
should i pr the change in before we start the release?
main is now green, and we're pretty much ready to cut - however, i don't feel comfortable doing all the remaining bits today, so this will get pushed out a day
anyone with homebrew insight would be appreciated on the above as well ^
going to open the pr, since the extra flag doesn't break if there is no var with the right name: https://github.com/Homebrew/homebrew-core/pull/179252
homebrew suggested that we should have a way of checking the new engine.Tag has been correctly filled: so opened this to handle that: https://github.com/dagger/dagger/pull/8081
Got back, couple of significant comments (https://github.com/dagger/dagger/pull/7744#discussion_r1701286158 and https://github.com/dagger/dagger/pull/7744#discussion_r1701317137)
API changes
This PR updates the Function and FunctionArg from our engine API to support defaultPathFromContext
Function
withArg(
"""
If the argument is a Directory or Fi...
okay, just need a review on the release notes: https://github.com/dagger/dagger/pull/8077
then i can start tagging ๐
everything is green, going to tag ๐
just finishing up the sdks now - and my only comment so far is that this is much smoother than expected ๐
really enjoying not having to do the extra pr step, that shaved off a lot of time
sdks+helm+docs now done
dagger playground can now be updated @unborn siren @midnight maple @cosmic tiger
daggerverse can also be updated @unborn siren @midnight maple @ionic oxide
@cosmic tiger @midnight maple we also need to re-deploy install.sh/ps1, there have been some changes there
no homebrew-core update yet: https://github.com/Homebrew/homebrew-core/pulls?q=sort%3Aupdated-desc+is%3Apr++is%3Aopen+dagger
Playground: https://github.com/dagger/dagger.io/pull/3893
Daggerverse: https://github.com/dagger/dagger.io/pull/3894
Cloud API + Magicache: https://github.com/dagger/dagger.io/pull/3895
think it's mostly a wrap ๐ going to keep a close on eye on this, but heading to get some lunch ๐
โจ v0.12.4 - 2nd August 2024
on it
done
Thanks!
๐ v0.12.4 - 2nd August 2024