#🌲 v0.12.2 - 22nd July 2024

1 messages · Page 1 of 1 (latest)

somber onyx
#

Kicking off a release thread for the always-green-checks issue (https://github.com/dagger/dagger/pull/8001). I don't think we should sit on this one for too long, but if you have any other fixes worth bringing in, let me know in the next hour or so.

#

🌲 v0.12.2 - 22nd July 2024

#

cc @young wasp @quasi garden @old stump @plush condor

plush condor
somber onyx
quasi garden
#

Unless @old stump @plush condor already covered that, just a drive-by thought

zinc cliff
# plush condor Yes, this fix is ready: https://github.com/dagger/dagger/pull/8000

Hm that reminds me of https://github.com/dagger/dagger/pull/7938 (I hadn't considered user modules being able to hit this case, so didn't think of it as particularly important, but I guess it's possible)

GitHub
sdk(typescript): handle required enum options by jedevc · Pull Requ...

🍒 Cherry-picked out of #7438, since that one is kinda stalled, not really sure what to do with it.
In the process of the above PR, I'd attempted to add a required enum arg, which the typescript...

#

Not urgent, it also needs a test case

somber onyx
quasi garden
plush condor
somber onyx
plush condor
#

Can anyone help with this? https://github.com/dagger/dagger/blob/2d6390b1d673f8ac7f53a76a61b049017c04b78f/.github/workflows/engine-and-cli-publish.yml#L326-L335

I'm on family time and I'm not familiar enough with GHA that'll require me to research how to do this, so I'll just describe what needs to happen in case I can't get it done, someone else can.

      - uses: actions/setup-python@v4
        with:
          python-version: "3.11"
          cache: "pip"
          cache-dependency-path: "sdk/python/requirements.txt"
      - name: "Test Python SDK"
        run: |
          cd sdk/python
          pip install -r requirements.txt .
          pytest -xm provision

Basically, Python is no longer needed to be installed, nor pip install -r requirements.txt. This is what needs to happen:

      - name: "Test Python SDK"
        run: |
          cd sdk/python
          uv run pytest -xm provision

Instead of uses: actions/setup-python@v4 we need something with uv installed:

# it's installed on $HOME/.cargo/bin
curl -LsSf https://astral.sh/uv/0.2.27/install.sh | sh

Or from docker image if better (ghcr.io/astral-sh/uv), or homebrew on mac if it's available there.

cache-dependency-path would be sdk/python/uv.lock.

EDIT: Also, sdk/python/requirements.txt should be deleted. It's only referencing requirements-dev.lock which doesn't exist anymore.

quasi garden
# somber onyx <@949034677610643507> Did you want to get this in? <https://github.com/dagger/da...

That fix is for our test flakes (technically a user could hit it, but it's outrageously obscure and no user has hit it that we know of despite existing since basically forever). The fix is just complicated enough (creates new state files on client hosts to give them a persistent unique id) that I'd say lets just skip it for this patch release and get merged asap after. Not quite worth the risk, would prefer a more thorough review on it.

somber onyx
plush condor
somber onyx
plush condor
#

I think it'll only run provision tests on main. Let's merge and iterate if needed.

somber onyx
#

hmm. gonna try re-running I guess, it's green on previous commits, no idea what it would have to do with this one

#

yep, passed on a rerun notsureif

#

think we're good to go now

somber onyx
#

all 🌲 (and not just because of the bug) - tagging!

somber onyx
#

Looking good now

quasi garden
somber onyx
#

Pushing Go SDK tag now (oh, after waiting for 🌲 on main)

somber onyx
#

Gonna avoid blocking on that and just go ahead and start tagging

somber onyx
#

Go SDK released, moving on to Python

#

Huh. Got past the SDKs, but for some reason the Helm version didn't get bumped in helm/dagger/Chart.yaml, not sure where/how that's supposed to happen.

@quasi garden's engine bump commit for v0.12.1 has this change: https://github.com/dagger/dagger/commit/78fd31cf2cfb5c010c7b65ddf27fdc4eedf3450b#diff-5d1b3093eee42b4e50b00a1a1a8cce2d60d6be6d1998976e4320545d4f0ae177

But mine doesn't - only the changelogs: https://github.com/dagger/dagger/commit/1ed939590738c349bcb34afc2620fd5b1a2e5547#diff-6df9c40f2229da7eeb25929e41a720500c42a7ab39829c0006e113a80ac2f389

The only mention of helm before this point in RELEASING.md is the changie stuff, which was done (confirmed in my shell history)

quasi garden
somber onyx
#

aaaand it finished before I was done typing that

#

Deploying docs now, and poking @proud patrol @gusty kindle @quasi garden since Playground + Daggerverse + Cloud are bump-able 🙏

Also install.sh and install.ps1 - it mentions to ping Gerhard but he's PTO, not sure how to bump the S3 bucket myself

quasi garden
#

If not then nothing should be needed

somber onyx
#

oh, guess not, I guess it doesn't hardcode a version?

quasi garden
somber onyx
shy hearth
#

I'll look. No, I cut a release with the full tag using the auto-release notes that GitHub produces and then I move the major tag to point to that same commit, e.g. v6

somber onyx
shy hearth