Typescript yarn deps issue | Dagger | Page 1

sharp peak Jul 9, 2024, 10:35 AM

#

👋

autumn obsidian Jul 9, 2024, 10:35 AM

#

I don't think it's a good idea to force users to use a specific package manager, most already got their habit and dagger should not change that, instead it should just keep their expererience as smooth as possible

sharp peak Jul 9, 2024, 10:35 AM

#

fyi @bleak acorn @solar wind

#

also @cloud hearth since he helped manage when we hit this before

autumn obsidian Jul 9, 2024, 10:36 AM

#

Yarn is great but sometime super unstable, also the workspace manager isn't as great at go.work

sharp peak Jul 9, 2024, 10:36 AM

#

autumn obsidian I don't think it's a good idea to force users to use a specific package manager,...

right agreed - but it looks like we're in a position of needing to run a hotfix release today

autumn obsidian Jul 9, 2024, 10:36 AM

#

I remember having issues with yarn while everything was fine with npm

#

Oh I see, until v0.12, I missread

#

My bad

sharp peak Jul 9, 2024, 10:36 AM

#

yeah yeah

autumn obsidian Jul 9, 2024, 10:36 AM

#

Yeah that's perfectly fine to do that

sharp peak Jul 9, 2024, 10:37 AM

#

i don't wanna estimate the time to v0.12 too much, but it's "imminent"

#

let's do this for now - if we get the 2 field package.json pr together, then once we've reviewed+merged, we can determine whether we would want to branch and release v0.11.10 with that pr to fix this issue

#

i don't think we can ship the downgrade pr in v0.11

#

in the meantime, could you create a tracking issue in github with the suggestion to use yarn in the meantime that we can point users to?

autumn obsidian Jul 9, 2024, 10:39 AM

#

The PR is already merged

#

For the downgrade

#

You wanna revert?

sharp peak Jul 9, 2024, 10:39 AM

#

sharp peak i don't think we can ship the downgrade pr in v0.11

yes, but, we're not going to release v0.11 off of main again

autumn obsidian Jul 9, 2024, 10:39 AM

#

Oh I see

sharp peak Jul 9, 2024, 10:40 AM

#

the next release off of main will be v0.12.0

#

if we do v0.11.10 it'll be branched off of v0.11.9

autumn obsidian Jul 9, 2024, 10:40 AM

#

Ok I'm creating the issue

sharp peak Jul 9, 2024, 10:40 AM

#

with only this patch

#

thanks for taking this ❤️

autumn obsidian Jul 9, 2024, 10:44 AM

#

https://github.com/dagger/dagger/issues/7851

GitHub

💡 Suggesting using yarn as package manager with TS SDK · Issue #785...

As the TS runtime is using yarn as package manager to download SDK & user's dependency, it's best to use yarn as package manager until we ship a way to configure the package manager ins...

#

Issue opened, I'm starting to work on this right now,

First: pinning a runtime version
Second: changing the package manager, I'm going to open 2 different PR for that

autumn obsidian Jul 9, 2024, 11:31 AM

#

@sharp peak https://github.com/dagger/dagger/pull/7852

GitHub

feat(ts-sdk): add runtime version configuration by TomChv · Pull Re...

#

To pin a runtime version

#

I tested locally with integration test, works fine, I'm waiting for the CI to be green, writing a changelog note and we're good

sharp peak Jul 9, 2024, 11:38 AM

#

nice nice ❤️ 🎉

autumn obsidian Jul 9, 2024, 11:54 AM

#

@sharp peak I updated based on your comment, feel free to approve if you think that's good enough

sharp peak Jul 9, 2024, 11:59 AM

#

Brb just gone for lunch 🙂

autumn obsidian Jul 9, 2024, 12:03 PM

#

Okay

#

Have a good lunch

#Typescript yarn deps issue