#SDK sources in runtime module

1 messages Β· Page 1 of 1 (latest)

simple mauve
#

Hey @open grove πŸ‘‹ Just coming back. I had a sense you were working on something to make even bundled sdks be accessible via a git ref, or am I mistaken?

open grove
# simple mauve Hey <@949034677610643507> πŸ‘‹ Just coming back. I had a sense you were working on...

No just proposed that we do that, not working on it at this time. Gonna talk about it in the prod-dev meeting on thursday https://github.com/dagger/dagger/issues/7585

GitHub

Background: the root cause of #7583 was lack of pinning deps in the typescript sdk (one of the unpinned ones updated out of band and broke every ts module in all previous engine releases) but it wa...

simple mauve
#

Ah, that's it. Gonna read that carefully, thanks. Yeah, we need a solution to fix the current situation with experimental SDKs.

#

That issue doesn't seem to address the problem I just mentioned. It has to do with the runtime module having access to the SDK's sources. How do you suggest we fix that, other than contextual modules?

#

I'm thinking the simplest thing would be a simple convention of putting the runtime module in a runtime subdirectory of the sdk. That way the sources are the directory itself, without that subdir. So you'd point the --sdk to the path of sdk/php, for example rather than sdk/php/runtime.

somber rain