🚀 v0.11.7 - 11th June 2024 | Dagger | Page 1

dreamy linden Jun 6, 2024, 2:58 PM

#

Hallo all 🙂 just going to start a release thread, since we've not done one this week.

I'd like to aim to release something next week, though not sure what. It feels like we're getting close to a v0.12.0, with some larger changes in the pipeline (lots of api breaking things we'd like to do, and maybe the telemetry changes that @brazen wave, depends on how breaky that is) is working on.

That said, not sure what's "ready". I think maybe we aim for at least one more release in the v0.11.X series, and then, aim to do a bunch of breaking changes/etc for v0.12.0?

For context:

v0.11.7 milestone: https://github.com/dagger/dagger/milestone/48
v0.12.0 milestone: https://github.com/dagger/dagger/milestone/45

#

cc @brazen wave @bitter seal @winged oak @frail idol @formal dust @left willow @sick dragon

#

If we're going for v0.11.7 next week, I'd probably say we should aim for Tuesday/Wednesday.

brazen wave Jun 6, 2024, 11:18 PM

#

@bitter seal @dreamy linden Done addressing all feedback on https://github.com/dagger/dagger/pull/7452! thanks again 🙏

As @dreamy linden mentioned it would be good to have https://github.com/dagger/dagger/pull/7031 in the same release since the OTel changes will make an outdated client hang. (Looked into a fix for backwards compat. and it's a bit complicated, wouldn't want to keep it for long, so kind of just delaying the inevitable.) Taking a look at that now but getting near EOD

bitter seal Jun 6, 2024, 11:48 PM

#

brazen wave <@949034677610643507> <@488718750690967563> Done addressing all feedback on <htt...

Will take a quick look again later today!

#

I'd really like to get https://github.com/dagger/dagger/pull/7315 in too. Needs to come after OTEL and is another doozy of a PR but will be good to review once OTEL is in main (currently has all the commits from Alex's PR).

It also creates incompatibilities with old CLIs (due to changes to the engine's API it serves, just pure http now rather than insane grpc tunneling), so same story of ideally having 7031

dreamy linden Jun 7, 2024, 9:08 AM

#

✨ v0.11.7 - 11th June 2024

#

cool! let's go for a v0.11.7 release, and intentionally break our client-server incompat 😄 i'll revive 7031, and add some tests 🎉

#

i'm also pulling in https://github.com/dagger/dagger/pull/7474 to the milestone, not really any huge changes here, just some progress tidy-ups, and making the cloud url a bit more prominent

dreamy linden Jun 7, 2024, 9:32 AM

#

🗒️ note! please add your issues/prs to the milestone! if they're on the milestone, they'll make it into the release, and the release will block until we can get them fixed/merged 🙂
also please add any release notes if applicable (it saves me so much time)

dreamy linden Jun 7, 2024, 2:50 PM

#

woo 🎉 finally rebased https://github.com/dagger/dagger/pull/7031 (and added some automated tests) - from manual testing as well, this works all the way back to v0.10.X, which is kinda neat 😄
(potentially we might also be able to deprecate+remove checkVersionCompatibility for v0.12 as well 🎉)

GitHub

Introduce better versioning compatibility guarantees by jedevc · Pu...

See the rationale in #7013, #7001 (comment). TL;DR, during the release of v0.11.0, we broke compatibility with older clients, but didn't really have the tooling to make sure that this errored c...

bitter seal Jun 7, 2024, 5:05 PM

#

Just FYI that afaict right now all TS module users (including those on any previous release) are broken atm unless they happen to have cache for the npm install -g tsx step in the TS SDK: #maintainers message

#

Options are either A) open an issue on the tsx repo and hope they fix it or B) do an engine release ASAP

bitter seal Jun 7, 2024, 6:12 PM

#

Thought of an option C, which is a wrapper of the TS SDK that works as a git ref and can be used in the meantime before we do the release: #maintainers message So unless there's any objections I say we go with that (I'll post to the TS channel and such) and just do the engine release ASAP early next week

brazen wave Jun 7, 2024, 6:20 PM

#

bitter seal Thought of an option C, which is a wrapper of the TS SDK that works as a git ref...

Sounds good to me! Pretty unlucky but seems better than rushing a release on a Friday. If we did that I'd want to do a hotfix, since my OTel PR is merged, but not the version compat. check PR yet

bitter seal Jun 7, 2024, 6:21 PM

#

brazen wave Sounds good to me! Pretty unlucky but seems better than rushing a release on a F...

Yeah exactly I'm just ruling out doing all of that by EOD essentially, doesn't quite reach the threshold of fire to call for that if there's a workaround

bitter seal Jun 7, 2024, 8:21 PM

#

Also, we can postpone https://github.com/dagger/dagger/pull/7315 for the subsequent release in the interest of getting it all out faster, was nice to have but not worth blocking on given it will take some time to review

bitter seal Jun 8, 2024, 1:32 AM

#

bitter seal Also, we can postpone https://github.com/dagger/dagger/pull/7315 for the subsequ...

That being said, I did fill it out the PR description and took it out of draft, so if anyone wants to review it, it's ready 😄

dreamy linden Jun 10, 2024, 4:02 PM

#

a few prs/issues still in the milestone need reviews/work: https://github.com/dagger/dagger/milestone/48

#

@hot rivet i took https://github.com/dagger/dagger/issues/7490 out of the milestone, though someone should find time to do it eventually 😢

#

i keep thinking i will get to it, and it never seems to happen

dreamy linden Jun 11, 2024, 2:21 PM

#

going to cut the release soon

hot rivet Jun 11, 2024, 2:28 PM

#

dreamy linden going to cut the release soon

sending PR in a bit

#

to fix: https://github.com/dagger/dagger/issues/7599

GitHub

🐞 initial `connect` o a newly spawned engine "sometimes" takes a lo...

What is the issue? I have observed that sometimes when calling Dagger the first time (engine gets started) the connect step takes an excessive amount of time. ref: https://discord.com/channels/7076...

dreamy linden Jun 11, 2024, 2:37 PM

#

awesome, will pull this fix into the release

dreamy linden Jun 11, 2024, 3:28 PM

#

tagged v0.11.7

dreamy linden Jun 11, 2024, 4:20 PM

#

hitting some weird instability in the new engine: #infrastructure message

#

going to keep going, and get all the sdks out

#

retriggered the jobs, it could be a flake (doesn't seem to be)

#

fyi @brazen wave @bitter seal

bitter seal Jun 11, 2024, 4:29 PM

#

Will be online in a few, does this happen at all locally when provisioning the new engine version the first time?

dreamy linden Jun 11, 2024, 4:30 PM

#

we seem to hit it in the test/lints, looks like it's at the end of a job related to that

#

we bumped to the latest buildkit version - could maybe be related to that

#

or maybe something service-y again

#

@hot rivet @pine oyster we should be good to update the playground

#

dagger-for-github here: https://github.com/dagger/dagger-for-github/pull/132

GitHub

chore: bump default dagger version to v0.11.7 by jedevc · Pull Requ...

dreamy linden Jun 11, 2024, 4:56 PM

#

dreamy linden we seem to hit it in the test/lints, looks like it's at the end of a job related...

yeah this is definitely weird, doesn't seem service related: https://github.com/dagger/dagger/actions/runs/9469086782/job/26086942090?pr=7616

#

we seem to not be getting the end of the initialize span somehow

bitter seal Jun 11, 2024, 4:58 PM

#

Seeing if I can repro locally, pulled the improve releasing PR locally and running those sdk lint jobs, no hangs so far

dreamy linden Jun 11, 2024, 5:00 PM

#

turned on the cloud token for those "waiting steps", kinda curious what the traces look like for them

bitter seal Jun 11, 2024, 5:04 PM

#

For this typescript failure: https://github.com/dagger/dagger/actions/runs/9469257837/job/26087498583?pr=7616

Why are we running golangci lint in the middle of it? exec golangci-lint run -v --timeout 5m thinkspin

#

No idea if related, but certainly odd

dreamy linden Jun 11, 2024, 5:05 PM

#

ah we're linting the typescript runtime

bitter seal Jun 11, 2024, 5:05 PM

#

ohh okay, that makes sense

#

Actually I just hit an attempt locally of running call sdk typescript lint that seems to hang, looking at it

pine oyster Jun 11, 2024, 5:10 PM

#

Playground: https://github.com/dagger/dagger.io/pull/3785 cc @hot rivet

dreamy linden Jun 12, 2024, 9:51 AM

#

@frail idol when you're around, noticed that the go/php sdks are having some issues - context and fix in https://github.com/dagger/dagger/pull/7631

GitHub

ci: fix git publish (for go and php) by jedevc · Pull Request #7631...

Fixes #7630.
Introduced in 8421636 (#7554).
This caused the https://github.com/dagger/dagger-go-sdk read-only copy to include the full dagger/dagger repo, instead of the filtered one.

frail idol Jun 12, 2024, 10:55 AM

#

Done!

dreamy linden Jun 12, 2024, 10:55 AM

#

again, will take an action to work out why our provisioning tests didn't catch this

#

~~am i good to retag the go and php onto that merged pr? requires a force-tag push, but since there are no changes to those sdks it should be "alright"~~ ah you mentioned you'd do it, nvm

frail idol Jun 12, 2024, 3:31 PM

#

The PHP SDK was good: https://github.com/dagger/dagger-php-sdk/releases/tag/v0.11.7

#

The Go SDK had to be force updated: https://github.com/dagger/dagger-go-sdk/releases/tag/v0.11.7 - this is good now

dreamy linden Jun 12, 2024, 3:33 PM

#

wonderful 🎉

frail idol Jun 12, 2024, 3:35 PM

#

The problem is that the Go package did not pick up this new version: https://pkg.go.dev/dagger.io/dagger@v0.11.7

#

Also, we seem to have published a bunch of other packages that does not look right - like this one: https://pkg.go.dev/github.com/dagger/dagger

dreamy linden Jun 12, 2024, 3:36 PM

#

frail idol Also, we seem to have published a bunch of other packages that does not look rig...

we don't publish these - go picks them up automatically

frail idol Jun 12, 2024, 3:37 PM

#

Do we expect this to be resolved? https://github.com/dagger/dagger/issues/7630

dreamy linden Jun 12, 2024, 3:37 PM

#

frail idol The problem is that the Go package did not pick up this new version: https://pkg...

indeed - it might refresh - that would be nice

frail idol Jun 12, 2024, 3:37 PM

#

We now have the right tag in place

dreamy linden Jun 12, 2024, 3:37 PM

#

if it doesn't - we could tag v0.11.7+1

#

or something like that

frail idol Jun 12, 2024, 3:38 PM

#

Trying to pull it explicitly in case that fixes it

#

I am still seeing the same error as reported in that issue. Moving the discussion there: https://github.com/dagger/dagger/issues/7630#issuecomment-2163374092

frail idol Jun 12, 2024, 3:56 PM

#

A separate issue which I have noticed is that PHP SDK v0.11.7 did not get published. Publishing now manually:

frail idol Jun 12, 2024, 4:32 PM

#

TL;DR we will not be able to fix the v0.11.7 Go SDK release. Publishing v0.11.8 as soon as we address some of the edge cases that we discovered sounds most reasonable to me.

dreamy linden Jun 12, 2024, 4:33 PM

#

if we publish v0.11.8 - we will be making an intentionally broken release - are we alright with that? cc @brazen wave @bitter seal

#

there is a legitimate timeout of testdev on main

frail idol Jun 12, 2024, 4:34 PM

#

Where does the breakage come from?

dreamy linden Jun 12, 2024, 4:34 PM

#

Probably an old version, v0.11.5 or so

brazen wave Jun 12, 2024, 4:34 PM

#

could we re-release just Go "0.11.7" as 0.11.8? or are we keen to keep the versions in lock step

dreamy linden Jun 12, 2024, 4:35 PM

#

We could release v0.11.8-1 or something (v0.11.8-rc1 would also work)

#

That's a prerelease

#

Then we don't do a whole new release, just one new tag

brazen wave Jun 12, 2024, 4:35 PM

#

might not get picked up by Go versioning (not sure)

dreamy linden Jun 12, 2024, 4:36 PM

#

dreamy linden Then we don't do a whole new release, just one new tag

And it'll be replaced by v0.11.8 when it arrives

frail idol Jun 12, 2024, 4:36 PM

#

Also, I was not able to get the PHP SDK to force update to v0.11.7 . Still not sure what is happening with that one, but both SDKs are affected. The Go one is definitely far more important to get fixed.

dreamy linden Jun 12, 2024, 4:37 PM

#

The other issue with doing an engine released now, is we just merged a large pr that refactored a lot - I was hoping to give it more time to settle to avoid just hitting similar issues in several days again

frail idol Jun 12, 2024, 4:37 PM

#

Yes, we could try tagging v0.11.8-rc1 for Go only. Even if it will use Engine v0.11.7, that should be OK.

dreamy linden Jun 12, 2024, 4:39 PM

#

It should upgrade automatically in the same way, we don't have a version conflict when we do v0.11.8, it sounds good to me

#

We could push it directly to the go-sdk repo as well (same for php)

frail idol Jun 12, 2024, 4:40 PM

#

OK, how about this?

let's retract v0.11.7 explicitly since it's broken
once this is merged & sync'ed to dagger-go-sdk, we can tag sdk/go/v0.11.8-rc.1 on dagger/dagger and let the workflow do the rest

WDYT?

#

OK, let me put together a PR that implements this.

dreamy linden Jun 12, 2024, 4:43 PM

#

Fyi, I'm going to be at a tech meetup in a few minutes, so will have slower response times

frail idol Jun 12, 2024, 5:05 PM

#

PHP SDK is now fixed, v0.11.7 showing as expected https://packagist.org/packages/dagger/dagger

dreamy linden Jun 13, 2024, 12:42 PM

#

working on the mixed up tags/branches thing now

dreamy linden Jun 13, 2024, 1:17 PM

#

https://github.com/dagger/dagger/pull/7648

GitHub

ci: fix git publish tag confusion by jedevc · Pull Request #7648 · ...

Follow up to #7631
This is fairly fiddly to do correctly. Essentially, we need to be able to handle at least these inputs:

Branch names, like main
Tag names, like v0.11.7
Full refs, like refs/pull...

#🚀 v0.11.7 - 11th June 2024