#Dagger module in monorepo
1 messages · Page 1 of 1 (latest)
Starting a thread to talk about our plan to resolve this @gentle bison
the most urgent is supporting include/exclude when passing directories to the cli
When we talked about this in last week's zenith call, two ideas were:
- respecting .gitignore
- a global
~/config/dagger/dagger.jsonthat could specify default excludes
How feasible are either of these and do they address this specific problem with include/excludes?
What's important here, is to decouple the problem of include/exclude, from the problem of having to explicitly pass every argument every time. We'll deal with both, but in a layered way. So it's OK to solve the first without solving the second. That will probably open up more options.
@lost sphinx
@safe lotus follow-up to the "best way to add include/exclude" conversation...
How does the CLI actually implement the conversion of a local path to a Directory object? Presumably it still needs to call dag.Host().Directory(), right? So we still have a hard dependency on that call continuing to exist outside a module. Right?
Yep - the way it works is Host.Directory() actually syncs the files over and returns a Directory referenced via blob(sha256:...) instead, which is how we're able to pass "local" directories around between modules. Provided there was some other way to kick off a file sync, theoretically we could cut straight to blob() if we really wanted to get rid of that API for whatever reason