#Mark can't upgrade to 0.9.9 (part 1)

1 messages · Page 1 of 1 (latest)

opaque nova
#

So, if I look at archivist, you want to know how to depend on arc, right?

{
  "name": "archivist",
  "sdk": "go",
  "dependencies": [
    {
      "name": "arc",
      "source": "../arc"
    }
  ],
  "source": ".",
  "engineVersion": "v0.9.9"
}
pure jewel
#

Correct. Locally it works, but it fails to install.

opaque nova
#

Got it. If you git clone... and from archivist/ run dagger call... it works, but you can't go create a new module and dagger install github.com/sagikazarmark/daggerverse/archivist, right? ( trying that right now)

pure jewel
#

yes

opaque nova
#

And it doesn't make sense for arc to be a standalone module, right?

Error: failed to generate code: input: resolve: moduleSource: withDependencies: resolveFromCaller: asModule: failed to create module: failed to update module dependencies: failed to initialize dependency modules: failed to initialize dependency module: failed to create module: failed to update module dependencies: failed to load module dependencies: failed to load pre-configured dependencies: failed to resolve dependency: module dep source path "/arc" escapes root
pure jewel
#

What do you mean? As far as I can tell, it is a standalone module

#

Arc is what I consider a "low-level" module that wraps a specific tool. Archivist is a "high-level" module implementing some logic (archiving files in this case), but arc is an implementation detail.

opaque nova
#

Could you try

"dependencies": [
    {
      "name": "arc",
      "source": "github.com/sagikazarkmark/daggerverse/arc"
    }
  ],
#

instead of

"dependencies": [
    {
      "name": "arc",
      "source": "../arc"
    }
  ],
pure jewel
#

Sure, I suppose that would work as a temporary workaround. But is that how it's supposed to work?

I mean, referencing local modules used to work before.

opaque nova
#

I think it might work if the local module was within or below the directory level of the parent module...

pure jewel
#

I doubt most people implement their daggerverse repo that way though

#

I noticed I deleted dagger.json from the repo root (not sure if it was accidental). Could that be a problem?

opaque nova
pure jewel
#

These are all from last November though, way before 0.9.8 and 0.9.9. Before moving to 0.9.9, this worked.

opaque nova
#

yep. tracing the changes

pure jewel
#

It even worked with 0.9.8 with the root-for hack. So this must be a very recent change (within a week or two)

opaque nova
pure jewel
untold pier
#

sorry about this @pure jewel . Yes local dependencies are supposed to work with .. in the path also . As long as it's the same git repo.

ivory lantern
#

checked discord while Alice was out w/ friends and I was sitting around doing nothing, saw this and realized it's just a dumb bug specific to the case of installing a git module that itself has local relative deps, so fixed it quick: https://github.com/dagger/dagger/pull/6645

Sorry about the hassle here, the integ tests cover installing deps pretty thoroughly but didn't have coverage of installing git modules yet (https://github.com/dagger/dagger/issues/6623) which was important for this bug to trigger. That PR adds a stopgap test though that just uses your daggerverse repo Mark (pinned to a commit), just to hold us over until we've setup our own repo.

#

(re-entering vacation mode now lurk will need someone else to approve and merge PR)

untold pier
untold pier
#

@steel mountain @fathom topaz @teal field I think we're going to need to get this 👆 in a patch release... we're supposed to call for more testers monday morning pacific time, but without this fix, it might stop testers in their tracks. I'll check in in the morning, we can make a go/no-go call. Option 1 we move forward either with the plan Monday. Option 2 we push back 24h.

untold pier
#

And thank you very much Mark for the testing 🙏 very appreciated

fathom topaz
#

we shouldn't push back 24h if we don't plan to cut a release before then

steel mountain
steel mountain
# untold pier <@796825768600141844> <@488718750690967563> <@768585883120173076> I think we're ...

It's reasonable to move 0.9.10 sooner than initially planned and get the fix out. There are a few other things which we could get in too: https://github.com/dagger/dagger/milestone/35 . @fathom topaz is on top of it 🏎 #1206562345892057179 message (private thread)

@pure jewel if you have a minute, can you please check that this fixes your issue? https://github.com/dagger/dagger/pull/6645#issuecomment-1937955132

@ashen mulch your ✅ would make the merge even more comfortable: https://github.com/dagger/dagger/pull/6645#discussion_r1486012753

pure jewel
steel mountain
fathom topaz
steel mountain
pure jewel
#

Looks like it works

fathom topaz
#

🎉

#

wonderous!