is this a known issue when upgrading

[wild fern]

I had something similar to that I think. Can you paste your tsconfig.json?

[lusty knot]

{
  "compilerOptions": {
    "target": "ES2022",
    "moduleResolution": "Node",
    "experimentalDecorators": true,
    "paths": {
      "@dagger.io/dagger": ["./sdk"]
    }
  },
}```

generated by mod init in 0.9.5

[wild fern]

does removing the trailing comma on the second last } fix it?

[lusty knot]

yes 😅

thank you

[wild fern]

Haha, I had the same thing but assumed I messed something up. Is this already tracked somewhere @tranquil acorn ?

[dull merlin]

Thanks, @wild fern is the idea that our 0.9.5 version of dagger mod init created that problem?

   }
  },
}

and didn't complain about it, but now 0.9.7 does

[wild fern]

yup! and it seemingly worked before

[dull merlin]

Got it. Thinking we should provide a better error message at the least.

[wild fern]

Yeah it's coming from pretty deep. It took me a minute to figure out the source. Ideally if anything is fixed we can just rewrite that tsconfig or go back to however it was being parsed before that worked

[dusk crypt]

That was fixed in https://github.com/dagger/dagger/pull/6433

[tranquil acorn]

Basically, this PR is updating the TS config if necessary, so it parse it using JSON.parse, but in the previous init, the tsconfig.json had an extra comma that break the function JSON.parse.
So you need to remove that comma so the JSON can be valid and successfully parsed!

[wild fern]

Got it! So if you have an existing typescript module, you'll have to edit the tsconfig to make it work for 0.9.7+, correct?

[dusk crypt]

You don't even need tsconfig.js if you use tsx (https://github.com/dagger/dagger/issues/6143). Unless you're using some custom config. For context: #1176864211683528714 message

[wild fern]

For zenith specifically, dagger mod init generates one

[dusk crypt]

That's because there's custom stuff there, for ./sdk.