noisy dagger-runner checks | Dagger | Page 1

cedar crest Aug 24, 2023, 4:20 PM

#

FWIW I think I know how to fix the failing test, but until there's time to fix that, I'd prefer that we find a way to have experimental checks be a bit less disruptive going forward

sharp quiver Aug 24, 2023, 4:21 PM

#

@proven parrot added them. I'll turn them off for now. I'm curious what the fix is. 🙂

cedar crest Aug 24, 2023, 4:22 PM

#

A ha, thanks!

The fix is pretty hokey, it's because of the 256-char limit on search ... in /etc/resolv.conf. That particular infra starts with a larger set of search domains, so the test isn't able to nest as deeply as it could in other environments

#

I think the proper fix might be to just see what's initially in /etc/resolv.conf, see how long each additional domain is when nesting, and do 🪄 math 🪄 to figure out the effective nesting limit

sharp quiver Aug 24, 2023, 4:24 PM

#

cedar crest A ha, thanks! The fix is pretty hokey, it's because of the 256-char limit on `s...

Ah, gotcha. That makes sense.

#

@cedar crest https://github.com/dagger/dagger/pull/5692

GitHub

Disable dagger-runner by jlongtine · Pull Request #5692 · dagger/da...

Disabling this, so we don't continue to train people to ignore these errors. Let's fix the issue and re-enable after that.

cedar crest Aug 24, 2023, 4:30 PM

#

What's confusing for me is this looks like a totally separate workflow, does this somehow modify the other ones to use these 3 workers? thinkies

#

here's the one I'm mainly concerned with, AFAICT this should be test.yml

sharp quiver Aug 24, 2023, 4:31 PM

#

engine:test runs _hack_make.yml: https://github.com/dagger/dagger/blob/main/.github/workflows/test.yml#L21-L24

which has the three different jobs within it.

#

  engine:
    uses: ./.github/workflows/_hack_make.yml
    with:
      mage-targets: engine:test

#noisy dagger-runner checks