releasing v0.3.14 | Dagger | Page 1

dull basin Feb 28, 2023, 4:13 AM

#

summarizing the conversation after this msg: the feature flag works, but the fix doesn't, but the issue might not affect many people; still investigating

update: issue tracked down to MTU mismatch between docker bridge network and the 'real' network

#

releasing v0.3.14

random berry Feb 28, 2023, 9:21 AM

#

ouch. Good ol MTU. What was it set to?

jagged totem Feb 28, 2023, 1:16 PM

#

Ping me when you are ready to do it @dull basin . I am keen on trying out some ideas regarding PR tags & better release notes. Follow-up to #1079728730055921694 message

#

FWIW https://github.com/dagger/dagger/pull/4657#issuecomment-1448180613

dull basin Feb 28, 2023, 2:51 PM

#

random berry ouch. Good ol MTU. What was it set to?

their interface was 1450, and our bridge CNI plugin defaulted to 1500. tale as old as time.

random berry Feb 28, 2023, 2:52 PM

#

Oh, it was the discussion with morlay?

dull basin Feb 28, 2023, 2:52 PM

#

yup!

jagged totem Feb 28, 2023, 4:11 PM

#

How are we looking on the release? @twin plume would like to get this in before the release goes out: https://github.com/dagger/dagger/pull/4642

twin plume Feb 28, 2023, 4:12 PM

#

I need to rebase that real quick and we can merge.

dull basin Feb 28, 2023, 4:23 PM

#

@jagged totem I hesitated since the scope of the breakage seems somewhat limited now and I'm working on an actual fix, but we can just ship anyway, always good to get more reps in 😛

#

will wait for the go-ahead from @twin plume 👍

jagged totem Feb 28, 2023, 4:25 PM

#

If we don't need to rush anything out, then we can wait a few more days. Fridays make great release days :D. That will also give me time to make progress with a bunch of things (Mondays & Tuesdays are by design full of interrupts for me).

dull basin Feb 28, 2023, 4:29 PM

#

yeah not sure. so far only two users seem to be affected. it could also be nice to get more folks trying it and noticing breakage; it's a bit more turbulent but probably more feedback than we'd get with making it opt-in, and it could make for a better v0.4.0. 🤔

#

have a meeting, will keep pondering; @warm geyser feel free to decide for us 😛

twin plume Feb 28, 2023, 4:32 PM

#

dull basin will wait for the go-ahead from <@768585883120173076> 👍

On my end PR is merged.

warm geyser Feb 28, 2023, 5:04 PM

#

https://tenor.com/view/coin-toss-coin-toss-gif-5017733

Tenor

coin toss

▶ Play video

dull basin Feb 28, 2023, 6:33 PM

#

jagged totem FWIW https://github.com/dagger/dagger/pull/4657#issuecomment-1448180613

I like the idea, how does it work? Will something automatically scan for the <summary><details> bit?

#

my first instinct is that it'd be nice if it just took the PR body to save redundancy, but I can see how that might have too much information. maybe we could standardize on keeping the first comment (the PR "body") focused on release notes, and keep progress reports and TODO lists etc. in a separate comment, but maybe that's too disruptive

#releasing v0.3.14